search

sign / translate

Effortless Real-Time Sign Language Translation
https://sign.mt
Other
414 stars 74 forks source link

[BUG] Videos generated on iOS are not valid #120

Closed AmitMY closed 5 months ago

AmitMY commented 8 months ago

Current Behavior

When building the iOS app, on iOS 17.2, the videos generated (either via screen recording or using the VideoEncoder https://github.com/sign/translate/commit/31673206948669637b1f0cf897cb784bbd255d8d) don't show. When "shared", the videos are empty.

Expected Behavior

Videos generated on all platforms should be playable

Steps To Reproduce

npm run build && \
npx cap sync && \
npx cap run ios

and write "test". Wait for the video to be generated.

Environment

AmitMY commented 6 months ago

Possibly a part of #127

AmitMY commented 5 months ago

fixed by https://github.com/sign/translate/commit/786046697d19b16b0971f2a65440c5aaec4e6dd8