search

signaflo / java-timeseries

Time series analysis in Java
MIT License
195 stars 49 forks source link

Why are getters in ArimaCoefficients package-private? #6

Closed twiechert closed 6 years ago

twiechert commented 6 years ago

It would be nice to be able to inspect the ARIMA coefficients after fitting. Unfortunately, the getter methods in the above mentioned class are package-private. Is there a reason for that?

twiechert commented 6 years ago

Not present in the master.

signaflo commented 6 years ago

@twiechert, why did you close this one? I believe the getters in the master branch are package-private still. I make everything as private as possible by default, and then wait for a compelling reason to make anything public. This has annoyed me as well when playing around with it in JShell. Currently the only way to see the coefficients is through the toString method.

Right now, with the streaming ARIMA idea, I'm also considering refactoring the coefficients. It might make sense to create a coefficient object that wraps both the value and its associated standard error. The coefficients class could then store a list of these coefficient objects instead of primitive arrays. Potential performance impact is my only concern.