search

signalapp / Flock

Private contact and calendar sync for Android.
https://signal.org/blog/flock
358 stars 80 forks source link

Crashes on nexus 7 (grouper) due to fragment intro layout #101

Open patcon opened 9 years ago

patcon commented 9 years ago

Heyo! Loaded up flock onto my grouper wifi tablet (no gapps), and it closes on first boot.

Looking at the catlog, a NullPointerException was raised at <etc>IntroductionFragment.initDescription(IntroductionFragment.java:76): https://github.com/WhisperSystems/Flock/blob/33fe753b91f2526ab578af71d5faafb137a5ea40/flock/src/main/java/org/anhonesteffort/flock/IntroductionFragment.java#L76

I was able to fix it by setting the screen dimensions manually:

~/repos/chef-textsecure (master ✘)✹✭ ᐅ adb shell wm size reset   
~/repos/chef-textsecure (master ✘)✹✭ ᐅ adb shell wm density reset # crashes
~/repos/chef-textsecure (master ✘)✹✭ ᐅ adb shell wm density      
Physical density: 213
~/repos/chef-textsecure (master ✘)✹✭ ᐅ adb shell wm size         
Physical size: 800x1280
~/repos/chef-textsecure (master ✘)✹✭ ᐅ adb shell wm size 798x1280 # doesn't crash
~/repos/chef-textsecure (master ✘)✹✭ ᐅ adb shell wm size 799x1280 # crashes

So yeah, seems it crashes only when the minimum width is around 800 (and for some reason that includes 799..?)

Anyhow, might mess around later and submit a PR if I fix it

patcon commented 9 years ago

fwiw, it's only the first screen that it crashes on :)