Allow local contact import to work on Cyanogen.

signalapp / Flock

Private contact and calendar sync for Android.

https://signal.org/blog/flock

358 stars 80 forks source link

Allow local contact import to work on Cyanogen. #102

Closed patcon closed 8 years ago

patcon commented 9 years ago

Fixes #85

AOSP uses a null ACCOUNT_TYPE for local contacts, whereas it seems CM uses com.android.localphone.

I don't have an android dev environment set up on my current workstation, so this is untested :(

patcon commented 9 years ago

Had to disable to nonplay build flavor (#94).

OK, guess that seemed too easy -- the correct contact count shows up on the import screen, but the the service doesn't actually seem to import anything. Guessing the null accounttype assumption is elsewhere :) I'll try digging a big more later

patcon commented 9 years ago

OK, reading through, wondering whether you would have any objection to treating CM's approach as the "right" one, and treating AOSP's "assume null is local" approach as the thing we work around? I feel like that might read a bit more sensibly