search

signalapp / Flock

Private contact and calendar sync for Android.
https://signal.org/blog/flock
358 stars 80 forks source link

German translation #37

Closed scento closed 10 years ago

scento commented 10 years ago
rhodey commented 10 years ago

Thanks for this @scento

I will make it my goal for tomorrow to improve Flock according to the localization best practices and merge this pull :)

scento commented 10 years ago

This request is mergeable without any codebase changes. It seems as if the announced refactoring needs some time, so I would appreciate a quick merge to extend the possible userbase by breaking language barriers.

rhodey commented 10 years ago

Sorry for the hold up @scento, I wasn't able to work on the project at all for the past few days. Back to full time now!

rhodey commented 10 years ago

@scento I spent some time yesterday removing unused strings from the project and modifying existing strings to use placeholders as you recommended, see a479eaa9c888a08d4bb4cee3b17f21fe3625b00d. Thanks again for your contribution :) if you are interested in continuing to help with the German localization please consider checking out the Flock Transifex page.

Even though the German translations for Flock are complete I cannot myself upload them to Transifex because then I would be in charge of maintaining the translation, a task I'm not very qualified for. If you were to open a German language request on the Flock Transifex project I would certainly approve it, this would would allow you to upload strings within the /values-de/strings.xml file you authored as well as provide translations for any future strings added to the app.

"It would be nice if the UI designers respect the long words in some non-English languages" - In reviewing strings.xml I noticed that the Server Tests UI has a lot of problems with this, I think this UI is already pretty poor so will keep the string length in mind when redesigning.