search

signalapp / Flock

Private contact and calendar sync for Android.
https://signal.org/blog/flock
358 stars 80 forks source link

Multiline notes in contacts only import first line of note. #45

Closed cyanfr closed 10 years ago

cyanfr commented 10 years ago

This is similar to closed issue #24. If a contact has a note with multiple lines, only the first line will import successfully. It appears to be ok on initial import. But connecting on a different device with no contact to same flock account shows that only the first line of the note actually makes it into flock.

rhodey commented 10 years ago

For some reason all the popular VCard and iCal libraries seem to have issues with multi-line data. To solve #24 I used base64 encoding to remove any possibility of line break bugs, I bet the same will work for resolving this. Will try out the base64 encoding fix in an hour or two then hopefully have a patch to master soon after.

Thanks for the bug report! Please do continue to submit issue for anything you come across and I will get to them asap :)

cyanfr commented 10 years ago

I can test builds if needed or if it will help.

rhodey commented 10 years ago

Thanks for the offer @cyanfr

I just tried and am able to reproduce your issue, will hopefully push a branch "issue-45" to the github repo in a few minutes. Should be a straightforward test but I'll let you know if I could use another :)