search

signalapp / Flock

Private contact and calendar sync for Android.
https://signal.org/blog/flock
358 stars 80 forks source link

Flock fails gracefully on sync since last update (0.8.7) #70

Closed bjoli closed 9 years ago

bjoli commented 9 years ago

Flock has started telling me that something went wrong and that I should submit my debug logs to you. The log is found here: https://gist.github.com/anonymous/58b1d07ffc40589608e7 and contains my username (and hopefully not anything compromising).

The errors related to jackrabbit (starting at row 10 and 774) have been there for earlier versions as well, and things seem to have worked quite well. CM tells me that the calendar is synced successfully, but that the contacts sync "has problems, try again later", but works about half of the time anyway.

I don't really know programming in general, or java in particular, but what looks interesting in the log to my eyes are:

row 759: W/org.anhonesteffort.flock.sync.AbstractDavSyncWorker(24318): sync result has errors, will not save remote CTag to local collection

row 874: E/org.anhonesteffort.flock.sync.AbstractDavSyncAdapter( 308): BAD MAC IN SYNC!!! 0.o

and the same thing on row 895.

Best wishes Linus

rhodey commented 9 years ago

Hey @linusbergl, thanks for submitting this debug log and issue report :)

Yesterday I received one other debug log which showed the same issue that I'm seeing in your debug log. There seems to be a (now reproducible) bug where Flock attempts to read the display name of address books when the display name is not actually set so the decryption fails (IE "bad mac").

Every calendar has a name which can be modified using the "My calendars" activity. Every address book also has a name but because Flock users are limited to one address book there is no real reason to ever show this address book to the user or let them name it. For some reason Flock seems to be reading the name of an address book when the name doesn't exist.

I started working on a patch for this last night and plan to finish it and release an update today, so as soon as that update hits the Google Play Store and you update this error should disappear. Looking at your log I see no other cause for concern, should be clean syncs again after this :)

Sorry for the trouble and thanks again for sending this along!