signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.47k stars 6.1k forks source link

Volume buttons change media volume in open conversations without any media playing #10130

Open hwinnemoe opened 3 years ago

hwinnemoe commented 3 years ago

Bug description

Using the volume buttons on the device, the media volume is changed in open conversations without any media playing. The notification volume should be changed instead. This still works correctly in the conversation list.

Steps to reproduce

Actual result: The media volume is changed. Expected result: The notification volume is changed.

Screenshots

see comment below

Device info

Device: Sony Xperia Z2 Android version: 6.0.1 Signal version: 5.0.5

Link to debug log

[can be sent upon request]

mfb commented 3 years ago

Here's a screenshot: volume-bug

LeKoe commented 3 years ago

Same problem here Shiftphone 5me Android 8.0 Signal Version 5.4.12

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

mfb commented 2 years ago

This is still a bug on current version.

I suppose it could make sense to be able to change media volume before you play a media item, but the volume buttons change media volume even if I'm on a new thread that doesn't have any playable media at all.

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

LeKoe commented 2 years ago

Still a Bug. Is there anyone with an idea how to solve this?

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

cody-signal commented 2 years ago

@LeKoe are you still running Android 8? I think the volume adjustment varies based on OS version. Like on my device running Android 12, the volume rocker always adjust media volume regardless of where I am (home, signal, gmail, etc.)

mfb commented 2 years ago

I'm on Android 12 and I have the "Use Volume keys for media" setting turned off (it can be overridden by apps). The volume buttons control ringtone in home and most apps, except in e.g. Signal and VLC they control media volume. For VLC this makes sense as it's a media player, but not imho for Signal, unless there is an audio/video message playing or at least visible on screen (I suppose maybe you want to adjust media volume before tapping play?).

cody-signal commented 2 years ago

Thanks for the extra info @mfb. If you are in Signal app settings do the keys work as expected and the issue occurs only on Conversation List and Conversation screens?

This is likely due to the fact we start up a media session to help with voice note playback on these two screens and the phone thinks we are in a media session when we are not.

mfb commented 2 years ago

Yep the volume buttons work as expected (ringtone volume) on the Signal settings screen.

I find myself fairly often in the situation of wanting to control ringtone volume while on Signal conversation/conversation list screens (either to make sure I hear a notification or to quiet them down). At this point I've gotten used to going back to home screen or some other app to control ringtone volume, but if there's any way to resolve the issue it would be a nice improvement.

cody-signal commented 2 years ago

Thanks for confirming, we'll look into ways to not start up the voice note service each time if possible.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.