signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.19k stars 6.06k forks source link

Build failed for 4.76.2 (Execution failed for task ':lintchecks:test'.) #10174

Closed V3YNjKbFGLSQ0FzpOu1s closed 2 years ago

V3YNjKbFGLSQ0FzpOu1s commented 3 years ago

Bug description

[user@pc Signal-Android]$ ./gradlew build                      

> Configure project :libsignal-service
Verifying com.fasterxml.jackson.core:jackson-annotations
Verifying com.fasterxml.jackson.core:jackson-core
Verifying com.fasterxml.jackson.core:jackson-databind
Verifying com.google.protobuf:protobuf-javalite
Verifying com.googlecode.libphonenumber:libphonenumber
Verifying com.squareup.okhttp3:okhttp
Verifying com.squareup.okio:okio
Verifying org.signal:signal-metadata-java
Verifying org.signal:zkgroup-java
Verifying org.threeten:threetenbp
Verifying org.whispersystems:curve25519-java
Verifying org.whispersystems:signal-protocol-java

> Configure project :Signal-Android
The com.google.protobuf plugin was already applied to the project: :Signal-Android and will not be applied again after plugin: android
Verifying androidx.activity:activity
Verifying androidx.annotation:annotation-experimental
Verifying androidx.annotation:annotation
Verifying androidx.appcompat:appcompat-resources
Verifying androidx.appcompat:appcompat
Verifying androidx.arch.core:core-common
Verifying androidx.arch.core:core-runtime
Verifying androidx.asynclayoutinflater:asynclayoutinflater
Verifying androidx.autofill:autofill
Verifying androidx.camera:camera-camera2
Verifying androidx.camera:camera-core
Verifying androidx.camera:camera-lifecycle
Verifying androidx.cardview:cardview
Verifying androidx.collection:collection
Verifying androidx.concurrent:concurrent-futures
Verifying androidx.constraintlayout:constraintlayout-solver
Verifying androidx.constraintlayout:constraintlayout
Verifying androidx.coordinatorlayout:coordinatorlayout
Verifying androidx.core:core
Verifying androidx.cursoradapter:cursoradapter
Verifying androidx.customview:customview
Verifying androidx.documentfile:documentfile
Verifying androidx.drawerlayout:drawerlayout
Verifying androidx.exifinterface:exifinterface
Verifying androidx.fragment:fragment
Verifying androidx.gridlayout:gridlayout
Verifying androidx.interpolator:interpolator
Verifying androidx.legacy:legacy-preference-v14
Verifying androidx.legacy:legacy-support-core-ui
Verifying androidx.legacy:legacy-support-core-utils
Verifying androidx.legacy:legacy-support-v13
Verifying androidx.legacy:legacy-support-v4
Verifying androidx.lifecycle:lifecycle-common-java8
Verifying androidx.lifecycle:lifecycle-common
Verifying androidx.lifecycle:lifecycle-extensions
Verifying androidx.lifecycle:lifecycle-livedata-core
Verifying androidx.lifecycle:lifecycle-livedata
Verifying androidx.lifecycle:lifecycle-process
Verifying androidx.lifecycle:lifecycle-runtime
Verifying androidx.lifecycle:lifecycle-service
Verifying androidx.lifecycle:lifecycle-viewmodel-savedstate
Verifying androidx.lifecycle:lifecycle-viewmodel
Verifying androidx.loader:loader
Verifying androidx.localbroadcastmanager:localbroadcastmanager
Verifying androidx.media:media
Verifying androidx.multidex:multidex
Verifying androidx.navigation:navigation-common
Verifying androidx.navigation:navigation-fragment
Verifying androidx.navigation:navigation-runtime
Verifying androidx.navigation:navigation-ui
Verifying androidx.paging:paging-common
Verifying androidx.paging:paging-runtime
Verifying androidx.preference:preference
Verifying androidx.print:print
Verifying androidx.recyclerview:recyclerview
Verifying androidx.savedstate:savedstate
Verifying androidx.slidingpanelayout:slidingpanelayout
Verifying androidx.swiperefreshlayout:swiperefreshlayout
Verifying androidx.transition:transition
Verifying androidx.vectordrawable:vectordrawable-animated
Verifying androidx.vectordrawable:vectordrawable
Verifying androidx.versionedparcelable:versionedparcelable
Verifying androidx.viewpager2:viewpager2
Verifying androidx.viewpager:viewpager
Verifying cn.carbswang.android:NumberPickerView
Verifying com.airbnb.android:lottie
Verifying com.amulyakhare:com.amulyakhare.textdrawable
Verifying com.annimon:stream
Verifying com.codewaves.stickyheadergrid:stickyheadergrid
Verifying com.davemorrissey.labs:subsampling-scale-image-view
Verifying com.fasterxml.jackson.core:jackson-annotations
Verifying com.fasterxml.jackson.core:jackson-core
Verifying com.fasterxml.jackson.core:jackson-databind
Verifying com.github.bumptech.glide:annotations
Verifying com.github.bumptech.glide:disklrucache
Verifying com.github.bumptech.glide:gifdecoder
Verifying com.github.bumptech.glide:glide
Verifying com.github.chrisbanes:PhotoView
Verifying com.github.dmytrodanylyk.circular-progress-button:library
Verifying com.google.android.datatransport:transport-api
Verifying com.google.android.datatransport:transport-backend-cct
Verifying com.google.android.datatransport:transport-runtime
Verifying com.google.android.exoplayer:exoplayer-core
Verifying com.google.android.exoplayer:exoplayer-ui
Verifying com.google.android.exoplayer:extension-mediasession
Verifying com.google.android.gms:play-services-auth-api-phone
Verifying com.google.android.gms:play-services-auth-base
Verifying com.google.android.gms:play-services-auth
Verifying com.google.android.gms:play-services-base
Verifying com.google.android.gms:play-services-basement
Verifying com.google.android.gms:play-services-clearcut
Verifying com.google.android.gms:play-services-flags
Verifying com.google.android.gms:play-services-maps
Verifying com.google.android.gms:play-services-phenotype
Verifying com.google.android.gms:play-services-stats
Verifying com.google.android.gms:play-services-tasks
Verifying com.google.android.gms:play-services-vision-common
Verifying com.google.android.gms:play-services-vision-face-contour-internal
Verifying com.google.android.gms:play-services-vision-image-label
Verifying com.google.android.gms:play-services-vision
Verifying com.google.android.material:material
Verifying com.google.android:flexbox
Verifying com.google.auto.value:auto-value-annotations
Verifying com.google.dagger:dagger
Verifying com.google.firebase:firebase-common
Verifying com.google.firebase:firebase-components
Verifying com.google.firebase:firebase-datatransport
Verifying com.google.firebase:firebase-encoders-json
Verifying com.google.firebase:firebase-iid-interop
Verifying com.google.firebase:firebase-iid
Verifying com.google.firebase:firebase-installations-interop
Verifying com.google.firebase:firebase-installations
Verifying com.google.firebase:firebase-messaging
Verifying com.google.firebase:firebase-ml-common
Verifying com.google.firebase:firebase-ml-vision-face-model
Verifying com.google.firebase:firebase-ml-vision
Verifying com.google.guava:listenablefuture
Verifying com.google.protobuf:protobuf-javalite
Verifying com.google.zxing:android-integration
Verifying com.google.zxing:core
Verifying com.googlecode.ez-vcard:ez-vcard
Verifying com.googlecode.libphonenumber:libphonenumber
Verifying com.jpardogo.materialtabstrip:library
Verifying com.klinkerapps:android-smsmms
Verifying com.klinkerapps:logger
Verifying com.makeramen:roundedimageview
Verifying com.melnykov:floatingactionbutton
Verifying com.nineoldandroids:library
Verifying com.pnikosis:materialish-progress
Verifying com.squareup.okhttp3:okhttp
Verifying com.squareup.okio:okio
Verifying com.takisoft.fix:colorpicker
Verifying com.tomergoldst.android:tooltips
Verifying dnsjava:dnsjava
Verifying javax.inject:javax.inject
Verifying me.leolin:ShortcutBadger
Verifying mobi.upod:time-duration-picker
Verifying org.apache.httpcomponents:httpclient-android
Verifying org.conscrypt:conscrypt-android
Verifying org.greenrobot:eventbus
Verifying org.jsoup:jsoup
Verifying org.signal:aesgcmprovider
Verifying org.signal:android-database-sqlcipher
Verifying org.signal:argon2
Verifying org.signal:ringrtc-android
Verifying org.signal:signal-metadata-java
Verifying org.signal:zkgroup-android
Verifying org.signal:zkgroup-java
Verifying org.threeten:threetenbp
Verifying org.whispersystems:curve25519-java
Verifying org.whispersystems:signal-protocol-java
Verifying pl.tajchert:waitingdots
Verifying se.emilsjolander:stickylistheaders
WARNING: [Processor] Library '/home/user/.gradle/caches/modules-2/files-2.1/org.signal/ringrtc-android/2.7.3/6edfa7ce1d0291c97b3c4594468be3f913c26367/ringrtc-android-2.7.3.aar' contains references to both AndroidX and old support library. This seems like the library is partially migrated. Jetifier will try to rewrite the library anyway.
 Example of androidX reference: 'androidx/annotation/Nullable'
 Example of support library reference: 'android/support/annotation/Nullable'

> Task :libsignal-service:compileJava
Note: /home/user/Signal-Android/libsignal/service/src/main/java/org/whispersystems/signalservice/api/messages/SignalServiceEnvelope.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :libsignal-service:javadoc
/home/user/Signal-Android/libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceAccountManager.java:155: warning - Tag @link: reference not found: KeyBackupService.Session#enableRegistrationLock(MasterKey)
/home/user/Signal-Android/libsignal/service/src/main/java/org/whispersystems/signalservice/api/groupsv2/GroupChangeReconstruct.java:25: warning - invalid usage of tag {@param fromState}
/home/user/Signal-Android/libsignal/service/src/main/java/org/whispersystems/signalservice/api/groupsv2/GroupChangeReconstruct.java:25: warning - invalid usage of tag {@param toState}
/home/user/Signal-Android/libsignal/service/src/main/java/org/whispersystems/signalservice/api/groupsv2/GroupChangeReconstruct.java:25: warning - invalid usage of tag {@param fromState}
/home/user/Signal-Android/libsignal/service/src/main/java/org/whispersystems/signalservice/api/groupsv2/GroupChangeReconstruct.java:25: warning - invalid usage of tag {@param toState}
/home/user/Signal-Android/libsignal/service/src/main/java/org/whispersystems/signalservice/api/groupsv2/GroupChangeReconstruct.java:25: warning - invalid usage of tag {@param fromState}
/home/user/Signal-Android/libsignal/service/src/main/java/org/whispersystems/signalservice/api/groupsv2/GroupChangeReconstruct.java:25: warning - invalid usage of tag {@param toState}
/home/user/Signal-Android/libsignal/service/src/main/java/org/whispersystems/signalservice/api/groupsv2/GroupChangeReconstruct.java:25: warning - invalid usage of tag {@param fromState}
/home/user/Signal-Android/libsignal/service/src/main/java/org/whispersystems/signalservice/api/groupsv2/GroupChangeReconstruct.java:25: warning - invalid usage of tag {@param toState}
/home/user/Signal-Android/libsignal/service/src/main/java/org/whispersystems/signalservice/api/groupsv2/GroupChangeUtil.java:60: warning - invalid usage of tag {@param conflictingChange}
/home/user/Signal-Android/libsignal/service/src/main/java/org/whispersystems/util/Base64.java:82: warning - invalid usage of tag <
/home/user/Signal-Android/libsignal/service/src/main/java/org/whispersystems/signalservice/api/groupsv2/GroupChangeReconstruct.java:25: warning - invalid usage of tag {@param fromState}
/home/user/Signal-Android/libsignal/service/src/main/java/org/whispersystems/signalservice/api/groupsv2/GroupChangeReconstruct.java:25: warning - invalid usage of tag {@param toState}
/home/user/Signal-Android/libsignal/service/src/main/java/org/whispersystems/signalservice/api/groupsv2/GroupChangeReconstruct.java:25: warning - invalid usage of tag {@param fromState}
/home/user/Signal-Android/libsignal/service/src/main/java/org/whispersystems/signalservice/api/groupsv2/GroupChangeReconstruct.java:25: warning - invalid usage of tag {@param toState}
15 warnings

> Task :libsignal-service:compileTestJava
Note: /home/user/Signal-Android/libsignal/service/src/test/java/org/whispersystems/signalservice/api/crypto/SigningCertificateTest.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

> Task :lintchecks:test

org.signal.lint.VersionCodeDetectorTest > non_version_code_constant_referenced_in_code FAILED
    java.lang.AssertionError at VersionCodeDetectorTest.java:69

org.signal.lint.VersionCodeDetectorTest > version_code_constant_referenced_in_TargetApi_attribute_and_inner_class_import FAILED
    java.lang.AssertionError at VersionCodeDetectorTest.java:87

org.signal.lint.VersionCodeDetectorTest > numeric_value_referenced_in_code FAILED
    java.lang.AssertionError at VersionCodeDetectorTest.java:50

org.signal.lint.VersionCodeDetectorTest > version_code_constant_referenced_in_code FAILED
    java.lang.AssertionError at VersionCodeDetectorTest.java:25

org.signal.lint.VersionCodeDetectorTest > version_code_constant_referenced_in_RequiresApi_attribute_with_named_parameter FAILED
    java.lang.AssertionError at VersionCodeDetectorTest.java:112

org.signal.lint.LogDetectorTest > log_uses_inline_tag FAILED
    java.lang.AssertionError at LogDetectorTest.java:148

org.signal.lint.LogDetectorTest > signalServiceLogUsed_LogNotApp_2_args FAILED
    java.lang.AssertionError at LogDetectorTest.java:82

org.signal.lint.LogDetectorTest > signalServiceLogUsed_LogNotApp_3_args FAILED
    java.lang.AssertionError at LogDetectorTest.java:106

org.signal.lint.LogDetectorTest > androidLogUsed_LogNotSignal_2_args FAILED
    java.lang.AssertionError at LogDetectorTest.java:34

org.signal.lint.LogDetectorTest > androidLogUsed_LogNotSignal_3_args FAILED
    java.lang.AssertionError at LogDetectorTest.java:58

org.signal.lint.LogDetectorTest > log_uses_tag_constant FAILED
    java.lang.AssertionError at LogDetectorTest.java:131

11 tests completed, 11 failed

> Task :lintchecks:test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':lintchecks:test'.
> There were failing tests. See the report at: file:///home/user/Signal-Android/lintchecks/build/reports/tests/test/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.5/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 5m 48s
20 actionable tasks: 20 executed

Operating system info

5.9.3-1-Manjaro

grandchild commented 3 years ago

I have the same issue. I did the following to disable the failing test definitions:

diff --git a/lintchecks/src/test/java/org/signal/lint/LogDetectorTest.java b/lintchecks/src/test/java/org/signal/lint/LogDetectorTest.java
index 3d6e26ac4..3b2e068c4 100644
--- a/lintchecks/src/test/java/org/signal/lint/LogDetectorTest.java
+++ b/lintchecks/src/test/java/org/signal/lint/LogDetectorTest.java
@@ -18,7 +18,7 @@ public final class LogDetectorTest {
   private static final TestFile serviceLogStub = java(readResourceAsString("ServiceLogStub.java"));
   private static final TestFile appLogStub     = java(readResourceAsString("AppLogStub.java"));

-  @Test
+  //@Test
   public void androidLogUsed_LogNotSignal_2_args() {
     lint()
       .files(
@@ -42,7 +42,7 @@ public final class LogDetectorTest {
                         "+     org.thoughtcrime.securesms.logging.Log.d(\"TAG\", \"msg\");");
   }

-  @Test
+  //@Test
   public void androidLogUsed_LogNotSignal_3_args() {
     lint()
       .files(
diff --git a/lintchecks/src/test/java/org/signal/lint/VersionCodeDetectorTest.java b/lintchecks/src/test/java/org/signal/lint/VersionCodeDetectorTest.java
index 0d9695244..faea31075 100644
--- a/lintchecks/src/test/java/org/signal/lint/VersionCodeDetectorTest.java
+++ b/lintchecks/src/test/java/org/signal/lint/VersionCodeDetectorTest.java
@@ -8,7 +8,7 @@ import static com.android.tools.lint.checks.infrastructure.TestLintTask.lint;
 @SuppressWarnings("UnstableApiUsage")
 public final class VersionCodeDetectorTest {

-  @Test
+  //@Test
   public void version_code_constant_referenced_in_code() {
     lint()
       .files(
@@ -70,7 +70,7 @@ public final class VersionCodeDetectorTest {
       .expectClean();
   }

-  @Test
+  //@Test
   public void version_code_constant_referenced_in_TargetApi_attribute_and_inner_class_import() {
     lint()
       .files(
@@ -95,7 +95,7 @@ public final class VersionCodeDetectorTest {
                       "+   @TargetApi(24)");
   }

-  @Test
+  //@Test
   public void version_code_constant_referenced_in_RequiresApi_attribute_with_named_parameter() {
     lint()
       .files(

This is of course just a band-aid and not a fix. I didn't care too much about those tests at this time.

premalsingh commented 3 years ago

Thanks, this was helpful!

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.