Closed V3YNjKbFGLSQ0FzpOu1s closed 2 years ago
I have the same issue. I did the following to disable the failing test definitions:
diff --git a/lintchecks/src/test/java/org/signal/lint/LogDetectorTest.java b/lintchecks/src/test/java/org/signal/lint/LogDetectorTest.java
index 3d6e26ac4..3b2e068c4 100644
--- a/lintchecks/src/test/java/org/signal/lint/LogDetectorTest.java
+++ b/lintchecks/src/test/java/org/signal/lint/LogDetectorTest.java
@@ -18,7 +18,7 @@ public final class LogDetectorTest {
private static final TestFile serviceLogStub = java(readResourceAsString("ServiceLogStub.java"));
private static final TestFile appLogStub = java(readResourceAsString("AppLogStub.java"));
- @Test
+ //@Test
public void androidLogUsed_LogNotSignal_2_args() {
lint()
.files(
@@ -42,7 +42,7 @@ public final class LogDetectorTest {
"+ org.thoughtcrime.securesms.logging.Log.d(\"TAG\", \"msg\");");
}
- @Test
+ //@Test
public void androidLogUsed_LogNotSignal_3_args() {
lint()
.files(
diff --git a/lintchecks/src/test/java/org/signal/lint/VersionCodeDetectorTest.java b/lintchecks/src/test/java/org/signal/lint/VersionCodeDetectorTest.java
index 0d9695244..faea31075 100644
--- a/lintchecks/src/test/java/org/signal/lint/VersionCodeDetectorTest.java
+++ b/lintchecks/src/test/java/org/signal/lint/VersionCodeDetectorTest.java
@@ -8,7 +8,7 @@ import static com.android.tools.lint.checks.infrastructure.TestLintTask.lint;
@SuppressWarnings("UnstableApiUsage")
public final class VersionCodeDetectorTest {
- @Test
+ //@Test
public void version_code_constant_referenced_in_code() {
lint()
.files(
@@ -70,7 +70,7 @@ public final class VersionCodeDetectorTest {
.expectClean();
}
- @Test
+ //@Test
public void version_code_constant_referenced_in_TargetApi_attribute_and_inner_class_import() {
lint()
.files(
@@ -95,7 +95,7 @@ public final class VersionCodeDetectorTest {
"+ @TargetApi(24)");
}
- @Test
+ //@Test
public void version_code_constant_referenced_in_RequiresApi_attribute_with_named_parameter() {
lint()
.files(
This is of course just a band-aid and not a fix. I didn't care too much about those tests at this time.
Thanks, this was helpful!
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Bug description
Operating system info
5.9.3-1-Manjaro