Bug: Translation of Date switches.

MorgeMoensch commented 3 years ago

[x] I have searched open and closed issues for duplicates
[x] I am submitting a bug report for existing functionality that does not work as intended
[x] I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
[x] This isn't a feature request or a discussion topic

Bug description

Sometimes the Date Translation has the wrong (-> System Language) instead of my chosen Language (-> English) on the Overview.

(I marked them on this screenshot from the Website:) grafik

Steps to reproduce

I can not really reproduce it. It occurs randomly. It diappears after entering a chat and going back to the overview.

Actual result: Sometimes the wrong language is used. Expected result: The chosen translation is always used

Device info

Device: OnePlus 8T Android version: 11 Signal version: 5.11.5

Link to debug log

https://debuglogs.org/d24319bb1059d4f86a98dd30d1e0da4922d77dee65f1c87b3a502cfc4fb993e1

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

MorgeMoensch commented 2 years ago

This still happens in Signal 5.28.10. Most of the times it happens when entering the app after a longer period of time, although I can not specify a timeframe.

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

MorgeMoensch commented 2 years ago

This issue still occurs on Signal 5.34.4

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

cody-signal commented 2 years ago

Can you clarify what your system language is, what your app language is, and what language is being shown incorrectly at random times (system or app)?

MorgeMoensch commented 2 years ago

System Language is German (Swiss), App-Language is set to English.

Sometimes the System Language (German) is shown instead of English (which is the App language -> the desired result). I only ever encounter the problem on the overview-screen, never in Chats or Settings.

(On a side note: Is a 'this issue still persists'-comment appreciated when the stale bot marks it as wontfix?)

cody-signal commented 2 years ago

Thanks, and this just happens randomly? You aren't doing anything to your system or app settings before this occurs?

Is a 'this issue still persists'-comment appreciated when the stale bot marks it as wontfix?

Yeah, lets us know the issue still persists and reminds us to look at it. I know it's annoying though.

MorgeMoensch commented 2 years ago

I think it only happens upon entering the app. And in a tendency when it was stopped manually (not just 'closed' as in it runs still in the background). I cannot reproduce it though.

And no, no changes in settings or the app were executed beforehand. Would more debuglogs come in handy?

MorgeMoensch commented 2 years ago

It still occurs on Signal 5.42.7. Here is another debug log, not sure whether this helps:

https://debuglogs.org/android/5.42.7/52bb659f16517a3839a1e6f8a3ae86a841a9905849bab56ad74e5c94b27e2e2b

cody-signal commented 2 years ago

I'm still unable to reproduce it. I acknowledge it's an issue, but everything code wise looks fine and uses the right context to fetch strings. At this point I'm curious if it's something OnePlus is doing to us since it doesn't seem to reproduce outside of you my dude?

MorgeMoensch commented 2 years ago

I was able to reproduce it on a second phone:

Samsung Galaxy Note 9
Android 10
OneUI 2.5
Signal 5.43.1

Same settings with regards to the language: System is set to 'Deutsch (Schweiz)' (German, Switzerland) and Signal to 'English'. DebugLog: https://debuglogs.org/android/5.43.1/eddf3a4a85576dd3e1a2837736e87bacc772ab4a26231f0cc491e93a5a3887b8

I changed Signals Language to English, then waited a day without opening the app (but Signal was open in the background the whole time) and then reentered.

At this point I'm curious if it's something OnePlus is doing to us

This would be a fair point, if Signals language would have been set to 'System default'. But this is not the case; so how could the OS mess with that? And - for this time - OnePlus seems not to be the troublemaker, since it appears on a Samsung Device as well.

Let me know if I can help you further. And it would be no tragedy if it doesn't get fixed either.

cody-signal commented 2 years ago

The amount of confirmed things that OnePlus has done to us is so high, that anytime we see reports that are only coming from OnePlus devices we lean that way. It's just the way it is. Thanks for trying and actually reproducing on another device, that shows for sure it's likely something else.

The logic required to change language only within the app and override the system is finicky. I'll give it another look and try to reproduce again, but that fact it takes some hoops and self resolves fairly quickly it's not going to be priority for us. Just being honest with how we typically prioritize things.

MorgeMoensch commented 2 years ago

I'll give it another look and try to reproduce again, but that fact it takes some hoops and self resolves fairly quickly it's not going to be priority for us. Just being honest with how we typically prioritize things.

That's totally okay! I'm just trying to help where I can.

Thank you for all the work you do!

MorgeMoensch commented 2 years ago

Okay, thats new: I just received a ToastMessage for the verification of the PIN in German, instead of English. The Chat Overview was correct in English though 🤔

Debug Log: https://debuglogs.org/android/5.42.8/835b2531a3c24ac654810d58604204b1e04786294b11629947992a3143c655f6

alex-signal commented 2 years ago

That sounds to me like we're using a bad context object to create the toast. Is this the verification message that says like, "Thanks, we'll remind you again in 2 weeks."

MorgeMoensch commented 2 years ago

Yes, exactly.

MorgeMoensch commented 2 years ago

This may or may not have fixed the toast (I have not yet seen it again), but it does not fix the wrongly translated dates. The issue still exists with Signal 5.44.1 on the Samsung device.

Maybe the underlying issue is the same though?

MorgeMoensch commented 1 year ago

Interestingly, the "reacted to their story" always stays in German (instead of English) on the Chat Overview, even when the Date translation is correct or gets 'fixed' by entering a chat and returning to the overview.

(Should I open another issue for this one?)

signalapp / Signal-Android