signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.59k stars 6.14k forks source link

App shortcut icons aren't adaptive #11412

Closed lokesh-krishna closed 3 years ago

lokesh-krishna commented 3 years ago

Bug description

Icons used for app shortcuts are circular irrespective of the icon style chosen in system settings.

Steps to reproduce

Actual result: Icons used for the app shortcuts are circular, embedded within the icon shape selected in system settings leading to empty space at the edges Expected result: Icons adapt to the shape picked in system settings

Screenshots

With the squircle shape selected, this is what things look like presently in Signal: signal-2021-06-27-184934

This is how Discord handles it: signal-2021-06-27-185914

Device info

Phone: Redmi Note 7 Pro Android version: 11 Signal version: 5.15.3

alex-signal commented 3 years ago

Hi! Thanks for the bug report. This should be fixed as of 5.16 which'll be rolling out soon to a beta near you!

Due to how shortcuts work, this may not fix itself instantaneously. As a workaround once you are on 5.16, I'd follow these steps:

  1. Enable screen lock in App Settings -> Privacy -> Screen Lock (this will delete all system shortcuts)
  2. Close the signal app
  3. In System app settings, clear cache for signal app (WARNING: Do not clear data. Only cache.) This will make sure Glide (the image manager library Signal uses) doesn't have any out-of-date shortcut bitmaps in it's file cache.
  4. Open the signal app
  5. Disable screen lock in App Settings -> Privacy -> Screen Lock (this will re-add all system shortcuts)

Clear cache might not be necessary, as I've also added a version number to the key that the cache system uses to locate the proper file, but it doesn't hurt.