Location Sharing From iPhones Parsed as Contacts

signalapp / Signal-Android

A private messenger for Android.

https://signal.org

GNU Affero General Public License v3.0

25.62k stars 6.15k forks source link

Location Sharing From iPhones Parsed as Contacts #11549

Closed DHerls closed 2 years ago

DHerls commented 3 years ago

[x] I have searched open and closed issues for duplicates
[x] I am submitting a bug report for existing functionality that does not work as intended
[x] I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
[x] This isn't a feature request or a discussion topic

Bug description

Signal Android cannot properly receive "current locations" sent from iPhones over MMS.

iPhones share locations over MMS via vCards. Signal interprets all vCards as shared contacts.

Steps to reproduce

Have someone with an iPhone send you their current location over MMS

Actual result: Signal interprets the vCard as a shared contact Expected result: Signal extracts the shared location data from the vCard and displays it to the user

Screenshots

Screenshot_20210816-155001_Signal

Device info

Device: Samsung Galaxy S21 Plus Android version: 11 Signal version: 5.21.2

DHerls commented 3 years ago

I can submit a PR to fix this issue, since I inadvertently caused it with PR #9667, but I would like guidance on what path to take.

Options:

Simply extract the Apple Maps URL and display it in the body of the message
Convert the Apple Maps URL to a Google Maps URL with the same coordinates
Convert the URL and also attach a Google Maps screenshot like how Signal shares locations natively

Tursko commented 3 years ago

I can submit a PR to fix this issue, since I inadvertently caused it with PR #9667, but I would like guidance on what path to take.

Options:

Simply extract the Apple Maps URL and display it in the body of the message

Convert the Apple Maps URL to a Google Maps URL with the same coordinates

Convert the URL and also attach a Google Maps screenshot like how Signal shares locations natively

~~In your other PR the Signal team wanted the experience to be as similar as possible. So, if it were me I would convert the URL and attach the Google Maps screenshot.~~ Actually since it's SMS, maybe you should just extract the Apple Maps URL. Our default map application can handle opening the link.

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.