Large backup to FAT does not warn user of unsuccessful backup

signalapp / Signal-Android

A private messenger for Android.

https://signal.org

GNU Affero General Public License v3.0

25.57k stars 6.13k forks source link

Large backup to FAT does not warn user of unsuccessful backup #11951

Open janvlug opened 2 years ago

janvlug commented 2 years ago

[x] I have searched open and closed issues for duplicates
[x] I am submitting a bug report for existing functionality that does not work as intended
[x] I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
[x] This isn't a feature request or a discussion topic

Bug description

When you create a backup of a large > 4.3 GB Signal database to an as "portable" formatted (I guess FAT32) SD-card, a partial backup file is created of 4.3 GB instead of a full backup. The user does not get a warning, and thinks that they have a good backup, which is not the case.

The restore of the partial backup did not get messages back, changed my safety number and disconnected my linked devices.

I consider this as a very severe issue, because I lost all history while I thought that I made a valid backup.

Device info

Device: Nokia 4.2 Android version: 11 Signal version: 0.0.0

Link to debug log

Meteor0id commented 2 years ago

Also (reported before) unsucesful backup files do not get cleaned up, and thus fill up the storage even further. Even disabeling backups does not clear partial backupfiles like it would with completed backup files.

Roghetti commented 2 years ago

I already opened a pull request to address this: https://github.com/signalapp/Signal-Android/pull/11900 It is about backup-chunking and splits the backup into 1GB parts to prevent to run into the FAT32-file-size-limit issue.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been closed due to inactivity.

janvlug commented 2 years ago

I'm pretty sure that this issue has not been resolved. Re-opening would be appreciated.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

janvlug commented 2 years ago

This issue is still there.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

michikommader commented 2 years ago

Still open and still a severe issue.

janvlug commented 8 months ago

I'm running again into this issue. I created a forum topic to discuss it further.