Auto video rotation on Video calls.

juli-yaa commented 2 years ago

[x] I have searched open and closed issues for duplicates
[x] I am submitting a bug report for existing functionality that does not work as intended
[x] I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
[x] This isn't a feature request or a discussion topic

Bug description

On android Signal’s auto rotate function on video call is annoying and inconsistent. The signal ignores the system's auto rotation setting and the video rotates even if my phone system's auto rotation is off. Please fix this BUG.

Allow the video to rotate only if the phone system's auto rotation function is enabled. Don't override the system’s auto-rotate setting.

Steps to reproduce

turn off phone's auto rotation 2 phone.
video call some one one Signal.
rotate one phone.
its rotate video one other end.

Actual result: on video call. if one person rotate his/her phone even auto ration is off . video gets rotate. Expected result: video should not be rotating is phone (system) auto rotation is off.

Screenshots

do not need screen shot. any one can recreate this bug.

Device info

Device: any brand Android version: 10, 11 Signal version: every Signal version Since February of last year.

Link to debug log

no need of debug log.

erajtob commented 2 years ago

Same issue here for a while too.

alex-signal commented 2 years ago

As far as I'm aware, this is consistent with how other platforms deal with rotation, and this was an intentional design decision. I've seen some recent chatter about it however, so please know at the very least it's on our radar. (But no promises)

rawlife56 commented 2 years ago

As far as I'm aware, this is consistent with how other platforms deal with rotation

@alex-signal Google Duo is the only platform which deals with it perfectly on both desktop and mobile. It would be great if we can take cues from that.

On mobile-

Duo behavior - It respects the auto rotation setting, rotates the entire system

(Signal just rotates the other person's video feed but doesn't send intent to rotate for the system. Also doesn't respect auto rotation setting.)

On desktop -

Duo behavior - Has the toggle to change aspect ratios from portrait to landscape

(Signal can only do landscape on desktop)

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

rawlife56 commented 2 years ago

Just reminding that still not fixed.

alex-signal commented 2 years ago

This is still in the design process, no timeline on a fix. However, I've marked this as acknowledged so it shouldn't get auto-closed.

signalapp / Signal-Android