search

signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.44k stars 6.09k forks source link

Push Notification on Google-Free Smartphones #12490

Closed genofire closed 1 year ago

genofire commented 1 year ago

Google independent generic push system: https://unifiedpush.org/

Switch to UnifiedPush with FCM embedded support: https://unifiedpush.org/developers/embedded_fcm/

genofire commented 1 year ago

Okay, to close an issue with no text or commant from an maintainer is also a statement.

greyson-signal commented 1 year ago

Apologies for the lack of comment, but we don't anticipate doing this work. We reserve github for bug reports not feature requests, which is why it was closed before.

Signal does work without play services. What confuses people is that we do not guarantee that Signal works with fake play services. When there's no play services installed at all, we will fallback to a persistent websocket connection to deliver notifications.

genofire commented 1 year ago

I understand that this is not direct an bug, i could formulate that as an Bug: e.g. Websocket is not (re)connected after a while.

Do you have not a default snippet for such closing?

In the End, i not feeling understand:

We do not talk about fake play services. There is an official standard called UnifiedPush, for Applications and ApplicationServer. So not every Application needs to create a Websocker, SSE, HTTP-Poll or any TCP connection (together with an Notification).

UnifiedPush has a library where is FCM inside, so that if the user has not installed/setup any UnifiedPush Provider. It will fallback to the Google Play Service.

So please do not call it fake play service, because it does not try to reimplement google - it is an open standard for push notification (which works outside of android, like Linux also). It would be really nice, that Signal use OpenStandards for Notification and do not use propriare (Google and own Websocket implementation).

metaphys commented 1 year ago

I confirm what genofire is saying, this isn’t a fake gplay but an open implementation. This means also that users could then choose their notification server or even self-host it. (nextcloud for instance offer this functionnality)

rightsaidfred99 commented 6 months ago

One wonders about open source software that still uses proprietary standards. a shame.

uberhalit commented 5 months ago

Proof enough that the original Signal app cannot be trusted. Use Molly instead: https://github.com/mollyim/mollyim-android

okias commented 2 months ago

@cody-signal

Hi. This is very much privacy related issue. This is very far from feature request in context of Signal.

While push notifications not leaking messages, it leaking important metadata. As Signal built (I hope it's still the case) on premises of open system, forced dependency on push notification from closed source implementation sounds like something undesirable (while ofc, people not caring about the privacy that seriously may be OK with it).

Thank you for consideration and for keeping Signal focused on privacy and openness.

edit: open websocket, while it's solution (I would call it more like workaround), is not really system-wide solution. Since we have standard in-the-place, I believe after 2 years it proven in multiple case, it should be reasonable investment for Signal, but please consider. @greyson-signal

rightsaidfred99 commented 2 months ago

Just use Molly with UnifiedPush support instead, it's superior app over Signal in both battery life and privacy