signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.52k stars 6.11k forks source link

[Bug] Links finishing with a parenthese before a linebreak isn't working #12648

Open metzgegu opened 1 year ago

metzgegu commented 1 year ago

Bug description

Describe here the issue that you are experiencing.

When I receive/send a message with an url finishing with a parentheses: https://fr.wikipedia.org/wiki/Griffe_(anatomie) for example and after that there is a line break, the url link will open https://fr.wikipedia.org/wiki/Griffe_(anatomie This bug occurs only on android (tested on ios and desktop)

Steps to reproduce

Actual result: Describe here what happens after you run the steps above (i.e. the buggy behaviour) image Android screenshot Expected result: Describe here what should happen after you run the steps above (i.e. what would be the correct behaviour) Capture d’écran 2022-12-02 à 16 20 28 Desktop screenshot

Screenshots

Device info

Device: Huawei Mate 20 Android version: EMUI 12.0.0 (based on Android 10) Signal version: 6.2.4

Link to debug log

https://debuglogs.org/android/6.2.4/9812afe9d5e52c0b7b2df513eae79e4d4131773a6e1a04768ed437860405e1ea

Lurikbolding commented 7 months ago

I find differents use case to complete. The other issue on same subject : https://github.com/signalapp/Signal-Android/issues/9449

For parentheses, we should work with 2 behavior, here is 2 examples :

In the same Way, we could have 2 differents behavior for final dot :

2 ideas to fix theses issues :

parenthese : without an open parenthese in URL => don't include the closing parenthese parenthese : witht an open parenthese in URL => include the closing parenthese

Final dot : always include the dot in the URL (this is a valid car pour URL), To avoid include the "sentece" dot in url : we should add a space between the end of URL and the dot.