signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.58k stars 6.14k forks source link

Call information not properly translated on Chat overview #12762

Closed MorgeMoensch closed 4 months ago

MorgeMoensch commented 1 year ago

Bug description

On the Chat overview, the info about videocalls is not properly translated.

Language: Android: German Signal: English

But instead of displaying 'Outgoing Videocall' it shows 'Ausgehender Videoanruf'. Interestingly, it is correctly displayed inside the chat.

This may be related to https://github.com/signalapp/Signal-Android/issues/11353, but I doubt it since the dates are correctly (= english) shown while the videocall is still on German. See the Screenshots below

Steps to reproduce

Actual result: Videocall-Info on Chat overview is in German Expected result: Videocall-Info on Chat overview is in English, since this is the Language set in Signal

Screenshots

Chat Overview: grafik

Inside Chat its correct: grafik

Device info

Device:OnePlus 8T Android version: 13 Signal version: 6.9.2

Sgn-32 commented 1 year ago

Can you also check other calls (incoming/outgoing voice/video calls), 'voice messages', photos, files and videos?

Seems relevant to this in ThreadBodyUtil.java

private static @NonNull ThreadBody getFormattedBodyForMms(@NonNull Context context, @NonNull MmsMessageRecord record) {

MorgeMoensch commented 1 year ago

This happens also with incoming and outcoming calls, as well as photos. Didn't test the other options, but it will probably occur there as well.

cody-signal commented 1 year ago

@MorgeMoensch I'm unable to reproduce this on the latest versions of the app (6.11.x in beta). Could you try again when a new version of Signal becomes available to you in your preferred release channel.

Sgn-32 commented 1 year ago

Tested with 6.11.2 beta. Issue still there. For testing set device language to german, french and dansk. Signal app to english. Having a voice message as last message in an conversation, shows the dansk string. Hint: the string didn't changed directly. Only after entering the conversation and going back to the conversation list.

Screenshot_1675870663


Edit: Changed device language from dansk to french and opened the Note to Self and returned back to the conversation list. Note to Self shows the french string, the other conversation still the dansk string.

Screenshot_1675871591

Sgn-32 commented 1 year ago

Tested with 6.11.4 beta on virtual device. Seems it depends on the correct order.

  1. change the language in Signal, e.g. espanol
  2. change the device language, e.g. dansk
  3. go in a conversation and than go back to the conversation list

when later the Signal language is changed to another language and repeat step 3, the string is shown correct in the new language.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

MorgeMoensch commented 1 year ago

This still happens with Signal 6.21.3

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

MorgeMoensch commented 1 year ago

Still happens on 6.27.10

alex-signal commented 1 year ago

My immediate thought is that we're storing translated string content in a thread snippet in the database (which is why it self-corrects if you enter and leave a conversation). We'll have a look.

MorgeMoensch commented 1 year ago

You're probably relating to the the reproduction-guide by @Sgn-32, but just to to make sure you're understanding correctly: For me, inside the conversation it is always in the proper language, and never in the chat list (also not when entering a conversation and returning to the overview).

alex-signal commented 1 year ago

@MorgeMoensch Is it always a group calling notification causing it? It's possible there's a missing translation somewhere or something being loaded from resources using a bad Context

MorgeMoensch commented 1 year ago

@alex-signal Nope, 1:1 Calls

MorgeMoensch commented 4 months ago

Does no longer appear in 7.8.1