signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.19k stars 6.07k forks source link

Poor audio quality on Fairphone 4 #13161

Closed Kyle0 closed 5 months ago

Kyle0 commented 10 months ago

Bug description

Audio quality is very poor when using video calling. This is always the case, regardless of whether I use mobile data or wifi. This appears to be due to a lack of background noise cancellation when video is on.

Steps to reproduce

Actual result: Poor/indecipherable audio Expected result: Good quality audio with no background noise

Device info

Device: Fairphone 4 Android version: CalyxOS 4.12.1 Signal version: 6.31.2

Link to debug log

https://debuglogs.org/android/6.31.2/b5f302065532811e1da4e256104d8cf2a1bf53b3f46a4442117fdece5fa9c98b

Fresh Debug Log

https://debuglogs.org/android/6.33.3/e51a10cc0d1afbd6bd0bfa98509019ff24114c5ec80aa214a4cbab9aeef6a81a

nicholas-signal commented 10 months ago

We have experienced similar issues in the past with the Fairphone 2, and the resolution was not relying on the hardware's automatic echo cancelation.

I've gone ahead and added the Fairphone 3 & 4 to the list, which should take effect globally in 6-12 hours. Let me know if that helps!

Kyle0 commented 10 months ago

That was a quicker response than I expected! I just tried a video call, didn't notice much improvement, tbh. Was an update required? I haven't seen an update listed on F-Droid.

nicholas-signal commented 10 months ago

It should have taken effect when the app refreshes its configuration., which usually takes place every 6-12 hours.

Kyle0 commented 10 months ago

Oh, I see. Not really familiar with the inner workings of Android. I made one or two more calls since, they seemed to have better quality audio. But I want to leave this issue open a bit longer, just in case.

Kyle0 commented 10 months ago

I have tried using video calling several times since the configuration change 2 weeks ago, but there is still excessive feedback causing a high-pitched squeaking noise. I have applied the usual recommended settings, use less data, etc. But the feedback is still there.

nicholas-signal commented 9 months ago

I see in your new logs that automatic echo cancellation is indeed disabled, but clearly that has not resolved the issue. We'll see if we can source a Fairphone 4 here in the USA.

stale[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Kyle0 commented 7 months ago

Just keeping this issue alive, as not solved. Please remove automatically added wontfix label unless there is actually no plan to fix it, in which case I would like to know from a maintainer or contributor, instead of a bot.

Kyle0 commented 7 months ago

I wondered if it might have something to do with latency of the network connection. I have a VPN on by default, which I usually forget about. I have tried calling with the VPN off and with a different VPN connection optimised for P2P. Both had much lower latency (<20 ms as opposed to 200-400 ms, based on speedtest.net under load), and the call quality on my end was much better, no audio feedback. Is there some more definitive test I could do on my device to help confirm this? Since I already have a Fairphone, would save someone having to get one just for testing purposes.

stale[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 5 months ago

This issue has been closed due to inactivity.