signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.44k stars 6.09k forks source link

Incorrect link-detection with closing bracket at the end #13468

Open MorgeMoensch opened 6 months ago

MorgeMoensch commented 6 months ago

Bug description

When sending a message that contains a link that ends on a closing bracket, the link is not entirely detected by Signal, hence opening a wrong page when pressing it. This only happens if the message contains other text after the link. I think it is also important to not break usecases like: "Studies have shown (eg. https://some.link/without-bracket) xy..". Here, the bracket should obviously not be detected as part of the link.

Steps to reproduce

Actual result: The closing bracket after (film is not underlined, and not included when opening the link by clicking on it Expected result: the full link is detected

Screenshots

grafik

Device info

Device: Google Pixel 8 Android version: 14 Signal version: 7.0.2

Neudrino commented 4 months ago

Related to https://github.com/signalapp/Signal-Android/issues/11136?

pkoevesdi commented 2 months ago

I can confirm this problem, very annoying. Still i'd like to keep the opportunity to paste links inside brackets like (https://example.com/path). So, I think the parser must look for the opening brackets too. Something like: "If an opening bracket exists, but is not part of the url (e.g. before it), don't take the last character into the url, if it's a bracket. Otherwise take it."

MorgeMoensch commented 2 months ago

I agree 100% with you @pkoevesdi

stale[bot] commented 3 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

MorgeMoensch commented 3 weeks ago

The issue is still present in 7.13.4