signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25k stars 6.02k forks source link

OKHTTP3 library is out of date. #13491

Open epachamo opened 1 month ago

epachamo commented 1 month ago

Bug description

The current version of OKHttp is 3. This should be upgraded to OKHttp 4, as version 3 hasn't received an update in almost 4 years now.

Upgrading is easy, I forked signal, made the mostly syntactic changes myself, ran the tests successfully. Upgrade instructions are given here by the library maintainers:

https://square.github.io/okhttp/changelogs/upgrading_to_okhttp_4/

nicholas-signal commented 1 month ago

We had tried to perform the 3 -> 4 upgrade back in Signal 6.32, but it caused deadlocks inside our CI pipeline. We hope to revisit it eventually.