signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.67k stars 6.17k forks source link

Some Signal domains not proxied when censorship circumvention is on #13682

Open UjuiUjuMandan opened 2 months ago

UjuiUjuMandan commented 2 months ago

Bug description

signal.org should not be dialed at all in censored countries.

Steps to reproduce

Actual result: These signal domain appeared:

Expected result: Nothing shoud appear.

svr2 appears when verifying PIN.

Note that cdsi and svr2 should be proxied as it appears in domain fronting configurations.

https://github.com/signalapp/Signal-Android/blob/5579df66ced70285446456cd05eb566ee0d48915/app/src/main/java/org/thoughtcrime/securesms/push/SignalServiceNetworkAccess.kt#L81

https://github.com/signalapp/Signal-Android/blob/5579df66ced70285446456cd05eb566ee0d48915/app/src/main/java/org/thoughtcrime/securesms/push/SignalServiceNetworkAccess.kt#L82

Screenshots

Screenshot_20240912-032202

Device info

Device: Google Pixel 7 Android version: 14 Signal version: 7.16.3

Link to debug log

N/A

Hasshu commented 1 month ago

Censorship circumvention has stopped working for me the other day; tried two different ISPs (wired and cellular) to no avail. Could this leak be part of the problem?

UjuiUjuMandan commented 1 month ago

Censorship circumvention has stopped working for me the other day; tried two different ISPs (wired and cellular) to no avail. Could this leak be part of the problem?

Not direct reason. I assume Google is not blocked on your side? Check if any of the following front domain is then.

Hasshu commented 1 month ago

I assume Google is not blocked on your side?

Fortunately, not yet! Oddly enough, the other three domains appear to be reachable from here as well.

greyson-signal commented 1 month ago

@Hasshu Any way you could get us a log? Settings > Help > Debuglog. If you can't upload it, you can save the log locally with the three-dot menu in the top right and upload it here.

Hasshu commented 1 month ago

@greyson-signal Having seen what the logs look like, I'm not sure I feel comfortable sharing that much information, even it it's not quite personally identifiable. Sorry for not being helpful here.

For what it's worth, all the outgoing messages never get past the sending phase with a throbber spinning endlessly (while everything works just fine over Tor). Also, as far as I know, I'm not the only one in these parts for whom censorship circumvention has stopped working recently. I suspect that deep packet inspection may be involved...