search

signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.62k stars 6.15k forks source link

Bug in Danish Translation #13763

Open iamjustmeithink opened 4 days ago

iamjustmeithink commented 4 days ago

Guidelines

Bug description

The "Remove Person" has a <br/ > at the end, wich should not be there.

It is only present in the Danish translation.

I have added screenshot of the English and Danish translation.

Screenshots

Danish dialog (where the bug is present): Screenshot_Danish Translation

English dialog (without the bug): Screenshot_English Translationl

Device

No response

Android version

No response

Signal version

No response

Link to debug log

No response

ismaildasci commented 4 days ago

Here’s a concise response acknowledging the issue and suggesting a quick solution:

Hey! 👋

Thanks for catching this! It looks like the extra
in the Danish translation might have been added by mistake. A quick fix would be to update the translation file to remove this line break.

If you’re open to it, feel free to submit a PR with the fix! Otherwise, I’m sure the team can address this in the next update.

Thanks for your attention to detail! 😊

mosbat commented 3 days ago

Let me know if anything else is needed

iamjustmeithink commented 3 days ago

@ismaildasci I don't know how to make a PR, but thank you for your sugestion!

@mosbat Wouw! You are fast in changing the tranlsation! I have not catched other mistakes in the translation, but if I do, I will let you know :)

Thank you :)

mosbat commented 1 day ago

@ismaildasci Seems like Signal forgot to mention that we don't handle translations for the mobile app here; so my fix was rejected since they prefer to have it done with a translation service. However, @greyson-signal who is working with Signal has confirmed that the issue will be fixed externally since they are pulling those translations from a third party.

CC: @iamjustmeithink

iamjustmeithink commented 1 day ago

Hi @mosbat ,

Ohh okay, thank you so much :)

Do you know where the translation service is? Just so I know where to add this in the future?

Thank you so much for taking your time to make the PR, even tho they dont accept translations there.

Even tho it feels like wasted time, you should know that I am very gratefull that you did it!

Have a great day :)

mosbat commented 1 day ago

Hi @mosbat ,

Ohh okay, thank you so much :)

Do you know where the translation service is? Just so I know where to add this in the future?

Thank you so much for taking your time to make the PR, even tho they dont accept translations there.

Even tho it feels like wasted time, you should know that I am very gratefull that you did it!

Have a great day :)

No worries, I'm new here and learning.

Based on what @greyson-signal said here (https://github.com/signalapp/Signal-Android/pull/13764#issuecomment-2454724025), he didn't indicate which service that is. However, I did suggest that such information regarding translations should be added to CONTRIBUTING.md (same as on the Desktop client of Signal repo).

I'm looking forward to contributing to Signal :)

iamjustmeithink commented 1 day ago

Ohh oki :)

I think you are on the right track! Just keep doing it and learn along the road :)

Best of luck in the future :)