please add option to hear message tone while on a call

[Dennisl123]

hi, please add a option to hear message tone while on a call. I can not get the vibrate to work and I'm blind so I can't see the notification in the status bar this would be useful. Your app is extremely accessible to the blind and with Google's screen reader talk back. I would be willing to donate if you add this option thank you.

[jeremymasters]

+1

[mcginty]

Hey @Dennisl123, it's really great to hear that TextSecure is so accessible for you! Would love to hear more feedback if you have any on areas for improvement.

Will look into adding in-conversation notifications as an option since it sounds like an accessibility issue.

[Dennisl123]

there are some buttons that are unlabeled for talk back. If you could double check that it would be appreciated. the ability to hear notification tones while on a call would truly be appreciated. it's very frustrating to not know if you receive a message while on a call especially when it's a important one your looking for. Thank you for your hard work. ----- Original Message ----- From: "Jake McGinty" notifications@github.com To: "WhisperSystems/TextSecure" TextSecure@noreply.github.com Cc: "Dennisl123" dennisl1982@gmail.com Sent: Tuesday, August 19, 2014 8:05 PM Subject: Re: [TextSecure] please add option to hear message tone while on a call (#1830)

Hey @Dennisl123, it's really great to hear that TextSecure is so accessible for you! Would love to hear more feedback if you have any on areas for improvement.

Will look into adding in-conversation notifications as an option since it sounds like an accessibility issue.

---

Reply to this email directly or view it on GitHub: https://github.com/WhisperSystems/TextSecure/issues/1830#issuecomment-52717351

---

This email is free from viruses and malware because avast! Antivirus protection is active. http://www.avast.com

[Dennisl123]

can you add quick reply and a option for those that want to add a signature? I also think a option if you need to email yourself a conversation would be good. ----- Original Message ----- From: "Jake McGinty" notifications@github.com To: "WhisperSystems/TextSecure" TextSecure@noreply.github.com Cc: "Dennisl123" dennisl1982@gmail.com Sent: Tuesday, August 19, 2014 8:05 PM Subject: Re: [TextSecure] please add option to hear message tone while on a call (#1830)

Hey @Dennisl123, it's really great to hear that TextSecure is so accessible for you! Would love to hear more feedback if you have any on areas for improvement.

Will look into adding in-conversation notifications as an option since it sounds like an accessibility issue.

---

Reply to this email directly or view it on GitHub: https://github.com/WhisperSystems/TextSecure/issues/1830#issuecomment-52717351

---

This email is free from viruses and malware because avast! Antivirus protection is active. http://www.avast.com

[agrajaghh]

Please don't mix up different things in one issue

[Dennisl123]

I would also like to see the message sender and the contense of the message hidden in the notification. This is how it works it would say something like new message from Dennis Long then what I wrote what I want is new message received nothing about name or what's in the message it would be grate to see my suggestions in the next version. thanks for all your hard work I truly appreciate it. ----- Original Message ----- From: "Jake McGinty" notifications@github.com To: "WhisperSystems/TextSecure" TextSecure@noreply.github.com Cc: "Dennisl123" dennisl1982@gmail.com Sent: Tuesday, August 19, 2014 8:05 PM Subject: Re: [TextSecure] please add option to hear message tone while on a call (#1830)

Hey @Dennisl123, it's really great to hear that TextSecure is so accessible for you! Would love to hear more feedback if you have any on areas for improvement.

Will look into adding in-conversation notifications as an option since it sounds like an accessibility issue.

---

Reply to this email directly or view it on GitHub: https://github.com/WhisperSystems/TextSecure/issues/1830#issuecomment-52717351

---

This email is free from viruses and malware because avast! Antivirus protection is active. http://www.avast.com

[Dennisl123]

Hi, I just got the text secure update did the ability to hear your message tone on a call make it into to 2.15? I didn't see anything that jumped out at me. I was just wondering if I missed something. Thanks for all you do. ----- Original Message ----- From: "Jake McGinty" notifications@github.com To: "WhisperSystems/TextSecure" TextSecure@noreply.github.com Cc: "Dennisl123" dennisl1982@gmail.com Sent: Tuesday, August 19, 2014 8:05 PM Subject: Re: [TextSecure] please add option to hear message tone while on a call (#1830)

Hey @Dennisl123, it's really great to hear that TextSecure is so accessible for you! Would love to hear more feedback if you have any on areas for improvement.

Will look into adding in-conversation notifications as an option since it sounds like an accessibility issue.

---

Reply to this email directly or view it on GitHub: https://github.com/WhisperSystems/TextSecure/issues/1830#issuecomment-52717351

---

This email is free from viruses and malware because avast! Antivirus protection is active. http://www.avast.com

[ghost]

I also need the ability to hear a message indicator while I'm talking on the phone. At this point, if I'm on the phone and I receive a text message, nothing is happening at all. I end up having to open TextSecure once I'm off the phone in order to know whether I received a message while I was talking. Most messaging applications, even if they don't play the set notification tone for a message while a phone call is active, do play some sort of beep or other indicator. This is the feature that is needed in TextSecure. Thanks much.

[Dennisl123]

I agree please allow for the playing of the message tone in the next version. Thank you very much.

On 3/3/2015 10:30 PM, Kyle wrote:

I also need the ability to hear a message indicator while I'm talking on the phone. At this point, if I'm on the phone and I receive a text message, nothing is happening at all. I end up having to open TextSecure once I'm off the phone in order to know whether I received a message while I was talking. Most messaging applications, even if they don't play the set notification tone for a message while a phone call is active, do play some sort of beep or other indicator. This is the feature that is needed in TextSecure. Thanks much.

— Reply to this email directly or view it on GitHub https://github.com/WhisperSystems/TextSecure/issues/1830#issuecomment-77091148.

[rhodey]

just verified that this is still and issue, assigning to myself with the intent of determining steps to resolve and then maybe I'll open a pull or pass it off to whoever.

[Dennisl123]

I would really appreciate this not getting passed back and forth. I would truly like to see it in the next version. I would also like to have the ability to hide the contense of the message and the message sender in the notification bar.

On 5/29/2015 6:55 PM, rhodey wrote:

just verified that this is still and issue, assigning to myself with the intent of determining steps to resolve and then maybe I'll open a pull or pass it off to whoever.

— Reply to this email directly or view it on GitHub https://github.com/WhisperSystems/TextSecure/issues/1830#issuecomment-106954444.

[rhodey]

I figured out that you can reliably play notification sounds layered on top of a call in progress with the following code:

Uri ringtone = Uri.parse(TextSecurePreferences.getNotificationRingtone(context));
Ringtone tone = RingtoneManager.getRingtone(context, ringtone);
tone.setStreamType(AudioManager.STREAM_VOICE_CALL);
tone.play();

note that setStreamType() was deprecated in API 21 but I found no alternatives that come anywhere near our minSdkVersion 9. we can use TelephonyManager to determine the call state and do this conditionally:

TelephonyManager telephonyManager = (TelephonyManager) context.getSystemService(Context.TELEPHONY_SERVICE);
if (telephonyManager.getCallState() != TelephonyManager.CALL_STATE_IDLE) {
  // whateva
}

the notification sound is layered on top of the audio so no pause or skip or anything like that but I'm still not sure if this should be enabled by default. @Dennisl123 is there any reason why a message tone is better than a vibrate while in call? my thought is that a vibrate would do less to interrupt the call in progress but your feedback on this would be great.

[agrajaghh]

just one thought: you might not be able to feel the vibration if the phone is on speaker

[Dennisl123]

then give me the option to turn notification while on a call on. also please give me the option to hide message sender and message contense in the notification bar. thank you for doing this I look forward to it in the next version. I am willing to test builds prior to release.

On 6/2/2015 4:46 PM, rhodey wrote:

I figured out that you can reliably play notification sounds layered on top of a call in progress with the following code:

Uri ringtone= Uri.parse(TextSecurePreferences.getNotificationRingtone(context)); Ringtone tone= RingtoneManager.getRingtone(context, ringtone); tone.setStreamType(AudioManager.STREAM_VOICE_CALL); tone.play();

note that |setStreamType()| was deprecated in API 21 but I found no alternatives that come anywhere near our |minSdkVersion 9|. we can use |TelephonyManager| to determine the call state and do this conditionally:

TelephonyManager telephonyManager= (TelephonyManager) context.getSystemService(Context.TELEPHONY_SERVICE); if (telephonyManager.getCallState()!= TelephonyManager.CALL_STATE_IDLE) { // whateva }

the notification sound is layered on top of the audio so no pause or skip or anything like that but I'm still not sure if this should be enabled by default. @Dennisl123 https://github.com/Dennisl123 is there any reason why a message tone is better than a vibrate while in call? my thought is that a vibrate would do less to interrupt the call in progress but your feedback on this would be great.

— Reply to this email directly or view it on GitHub https://github.com/WhisperSystems/TextSecure/issues/1830#issuecomment-108093760.

[Dennisl123]

I can here the message tone I may not feel the phone vibrate. I am blind I can't see the light flash so I really need the tone.

On 6/2/2015 4:46 PM, rhodey wrote:

I figured out that you can reliably play notification sounds layered on top of a call in progress with the following code:

Uri ringtone= Uri.parse(TextSecurePreferences.getNotificationRingtone(context)); Ringtone tone= RingtoneManager.getRingtone(context, ringtone); tone.setStreamType(AudioManager.STREAM_VOICE_CALL); tone.play();

note that |setStreamType()| was deprecated in API 21 but I found no alternatives that come anywhere near our |minSdkVersion 9|. we can use |TelephonyManager| to determine the call state and do this conditionally:

TelephonyManager telephonyManager= (TelephonyManager) context.getSystemService(Context.TELEPHONY_SERVICE); if (telephonyManager.getCallState()!= TelephonyManager.CALL_STATE_IDLE) { // whateva }

the notification sound is layered on top of the audio so no pause or skip or anything like that but I'm still not sure if this should be enabled by default. @Dennisl123 https://github.com/Dennisl123 is there any reason why a message tone is better than a vibrate while in call? my thought is that a vibrate would do less to interrupt the call in progress but your feedback on this would be great.

— Reply to this email directly or view it on GitHub https://github.com/WhisperSystems/TextSecure/issues/1830#issuecomment-108093760.

[Dennisl123]

here is a real simple solution have it enable message tone while on a call you check it it is on vibrate while on a call you as the user can have one or both of them checked and it will do what the user wants.

On 6/2/2015 4:51 PM, agrajaghh wrote:

just one thought: you might not be able to feel the vibration if the phone is on speaker

— Reply to this email directly or view it on GitHub https://github.com/WhisperSystems/TextSecure/issues/1830#issuecomment-108095652.

[rhodey]

thanks for the feedback @agrajaghh & @Dennisl123. @mcginty and I just tested this on Google Hangouts and WhatsApp, interestingly neither of them vibrate or play a message tone for new messages received while in call. kinda surprised me.

using the hardware volume buttons on my device I can turn the volume all the way town to vibrate only, in this setting the in call notification is silenced just like I would expect it to be while outside of a call. so that's good.

personally, I also would like to hear message tones (or vibrate) while in call but I think to be consistent we should also vibrate in call if TextSecure is set to vibrate out of call. anyone super opposed to this before I open a PR?

[agrajaghh]

one more thought: If you are on the phone and some guys start sending a lot of group messages it could be really annoying

[Dennisl123]

no I think it should as well. will this be in the next version? what about hiding message sender and the contents of the message in the notification bar?

On 6/2/2015 5:19 PM, rhodey wrote:

thanks for the feedback @agrajaghh https://github.com/agrajaghh & @Dennisl123 https://github.com/Dennisl123. @mcginty https://github.com/mcginty and I just tested this on Google Hangouts and WhatsApp, interestingly neither of them vibrate or play a message tone for new messages received while in call. kinda surprised me.

using the hardware volume buttons on my device I can turn the volume all the way town to vibrate only, in this setting the in call notification is silenced just like I would expect it to be while outside of a call. so that's good.

personally, I also would like to hear message tones (or vibrate) while in call but I think to be consistent we should also vibrate in call if TextSecure is set to vibrate out of call. anyone super opposed to this before I open a PR?

— Reply to this email directly or view it on GitHub https://github.com/WhisperSystems/TextSecure/issues/1830#issuecomment-108101863.

[agrajaghh]

@Dennisl123 pls don't mix up different issues here

[mcginty]

@Dennisl123 this probably won't be in the next version, but we're interested in implementing it to help accessibility. There's a separate issue open about notification privacy settings.

[rhodey]

1858 for notification privacy settings

[Dennisl123]

I would appreciate it as soon as you can. this would help accessibility. I also noticed some unlabeled buttons with talk back. Not having the privacy setting and the notification while on a call is preventing me from using it full time. I hope this done soon.

On 6/2/2015 5:34 PM, Jake McGinty wrote:

@Dennisl123 https://github.com/Dennisl123 this probably won't be in the next version, but we're interested in implementing it to help accessibility. There's a separate issue open about notification privacy settings.

— Reply to this email directly or view it on GitHub https://github.com/WhisperSystems/TextSecure/issues/1830#issuecomment-108104622.

[Dennisl123]

yes I would like to see the option to not display the message sender or the message contents in the notification bar.

On 6/2/2015 5:36 PM, rhodey wrote:

1858 https://github.com/WhisperSystems/TextSecure/issues/1858 for

notification privacy settings

— Reply to this email directly or view it on GitHub https://github.com/WhisperSystems/TextSecure/issues/1830#issuecomment-108104933.

[rhodey]

something else to note for anyone looking into this in the future, [NotificationCompat.Builder.setSound()](http://developer.android.com/reference/android/support/v4/app/NotificationCompat.Builder.html#setSound%28android.net.Uri, int%29) doesn't work with stream type AudioManager.STREAM_VOICE_CALL

[mcginty]

@Dennisl123 please open a new issue for the unlabeled buttons with a description of how to reproduce. Let's keep this issue's discussion specific to in-call notifications. Thanks.

[moxie0]

based on my experience with redphone, fucking with stream_voice_call will open up a world of pain

[rhodey]

ok, well I found no other ways of doing this and can't imagine a solution that wouldn't involve AudioManager.STREAM_VOICE_CALL so removing my assignment.

[automated-signal]

GitHub Issue Cleanup: See #7598 for more information.