signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.47k stars 6.1k forks source link

Sending encrypted through google voice #364

Closed yestertester closed 9 years ago

yestertester commented 10 years ago

Allow for the extra header that google voice attaches text messages and still allow decryption. currently a msg received is recognized as a text secure msg but the return key and further msgs are wont work as google uses a token text msg phone number and puts the real txt caller id in the msg as a header. text msgs to the reciever with the extra header are still encrypted

rhodey commented 10 years ago

@yestertester sounds like a nice feature, could you link to some specs or more details about Google Voice's handling of SMS so we could determine if this is possible? I'm inclined to think that keeping up with Google's changes to Google Voice might be a headache, with all the Google Hangouts nonsense-- but definitely worth looking into.

yestertester commented 10 years ago

Not sure about the specs.. but I can tell you that when you send txt msgs through google voice and the phone is a sprint phone and married to google voice, the text works with text secure. when you use a phone that is not sprint, or not married, google voice is gluing extra header onto the text which is not read correctly by the text secure app. so you only get half of a key exchchange.. ill try to post the format in the next day or 2

tildelowengrimm commented 10 years ago

For what it's worth, Google Voice's system for breaking up long messages, adding names and appending “(1/2)” or the like doesn't seem to have changed in the last few years. I've just been looking from the user side, I don't know if they've been doing anything clever under the hood.

Nonetheless I would appreciate this feature. I prefer to use my Google Voice number for no-carrier-cooperation-needed portability, but I'd rather prefer if Google couldn't read my messages.

bhyde commented 10 years ago

The frustrating aspect of this is that bootstrap fails. Bob upon receipt of a msg from Alice and is prompted to exchange keys. He cheerfully sends a request for Alice's keys. Alice replies with her keys. Bob get's two messages of encrypted garbage that aren't recognized by TextSecure. Alice then thinks all is secure and invites him to a wild party mentioning lots of salacious details. Bob gazes in frustration at these messages all of which are incomprehensibly encrypted. Alice swears to never speak to Bob again. I suspect there is something about the first message from Alice that hints that while she has TextSecure installed the channel isn't clean enough to proceed.

yestertester commented 10 years ago

whats interesting is this does work through google voice if you have sprint integration. so I use my google voice with my goog voice number, the key exchange works fine. if you don't do the integration google seems to glue some extra headers like name on the msg and can break it up. Then the key exchange that bhyde is talking about seems to go through but the txt does not decrypt on either side.

patcon commented 9 years ago

With encrypted SMS being dropped, I think this can be closed, yes?

rhodey commented 9 years ago

@patcon indeed!