signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.63k stars 6.16k forks source link

UI glitch (3.5.0 regression): Text input box height increases after clearing (caused by new voice message button) #4645

Closed Norbert80 closed 7 years ago

Norbert80 commented 8 years ago

1) Go into any chat 2) Enter any character into the text input field 3) Delete the character while watching the height of the input field: Note that the height increases slightly leading to a shift of the whole chat history. 4) Enter any character. Note that the height decreases again. 5) When deleting the character height increases again...

Note that this happens in groups and push conversations but not in SMS conversations.

Regression found in Signal 3.5.0 Android.

2-4601 commented 8 years ago

Which device, ROM and keyboard are you using? Do you have system (Android) emojis turned on or off in Signal's Advanced settings?

Cannot reproduce on Nexus 4, stock 5.1.1, system keyboard. Tried both system emojis turned on and off.

Can reproduce a similar behaviour with Huawei U8800, Android 4.0.4, system keyboard. But only when system emoji setting is turned off (or if there's a zombie emoji drawer button, see #4638). However the text input field resizing is a bit different than what @Norbert80 described. Namely:

Signal 3.5.0

Norbert80 commented 8 years ago

Samsung Galaxy Note 4

Latest official Samsung Firmware with Android 5.1.1

Default Samsung keyboard

Signal 3.5.0

EDIT in inital description: 5) "entering a" replaced with "deleting the"

Norbert80 commented 8 years ago

I think it happens when the new (in build 3.5.0 introduced) microphone button slides in and out.

zebra-ok commented 8 years ago

I'm experiencing the same bug with Signal 3.5.0 (Nexus 5 / OmniRom using the AOSP keyboard):

GIF

Norbert80 commented 8 years ago

Thanks. This is exactly what I experience. It looks like the initial smaller height is the normal height while the increased height is not normal.

Norbert80 commented 8 years ago

@moxie0 in release 3.5.1 the voice message button is missing! Did you remove voice message feature intentionally?

This makes this bug not appearing in release 3.5.1.

This finally confirmes that this bug is caused by the voice message button from release 3.5.0.

McLoo commented 8 years ago

@Norbert80 see https://github.com/WhisperSystems/Signal-Android/commit/885fc88aad2b45822bfd9734012b76a36355443f

Rolf558 commented 7 years ago

This one is fixed with build 3.23.0 that introduces voice messages again. Could someone please close it?

2-4601 commented 7 years ago

Seems to be fixed for me too. How about @Norbert80 ?