search

signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.59k stars 6.14k forks source link

Signal crashes when changing the color of a contact that is not in the address book #5704

Closed RiseT closed 8 years ago

RiseT commented 8 years ago

I have:

Bug description

When trying to change one contact's color, Signal crashed. Since then, whenever I try to start Signal, it instantly crashes. When enabling airplane mode, Signal starts successfully (that's how I was able to produce a log - thanks to @FeuRenard for the tip). When I disable airplane mode while Signal is running, it crashes again.

This could be related to the recently introduced contact color sync (with Signal Desktop).

Steps to reproduce (correctly pointed out by @FeuRenard )

  1. Pick a contact that is not in your address book (in my case a non-Signal i. e. SMS contact: a Facebook 2FA SMS with no phone number visible - just "Facebook" as the sender)
  2. Go to the contact preferences
  3. Change the contact color

    Device info

Device: Google Nexus 5 Android version: 6.0.1 Signal version: 3.19.0

Debug log

https://gist.github.com/RiseT/035f7ee2e622852a16d0c18ace62b0bf#file-signal-android-issue-5704-txt

FeuRenard commented 8 years ago

Steps to reproduce

  1. pick a Signal contact that is not in your address book
  2. go to the contact preferences
  3. change the contact color
moxie0 commented 8 years ago

=(

johanw666 commented 8 years ago

Installing 3.18.3 over 3.19.0 (with adb, AppDowngrader or other methods), then changing the color of said contact, and then upgrade to 3.19.0 again solves the crash at startup.

RiseT commented 8 years ago

I can say what doesn't work: Deleting the problematic conversation in airplane mode doesn't help.

FeuRenard commented 8 years ago

What worked for me: add the contact to your address book (maybe in airplane mode).

johanw666 commented 8 years ago

Could there be an issue with blocklists too? Since they are now also synced.

moxie0 commented 8 years ago

Can anyone confirm this works?

FeuRenard commented 8 years ago

I can confirm, that there are no crashes anymore changing the contact color of a non-address-book contact with an Android 5.1 AVD. Also if one is trapped in the permanently crashing state of Signal this update solves the problem.

FeuRenard commented 8 years ago

The current Play Store version seems to be fixed, too. Device: Fairphone 2, Android 5.1

RiseT commented 8 years ago

Confirmed. Just updated Signal from the Play Store. No more crashing after being trapped in permanent crashes for a day. Just updating, no re-installation necessary.

Thanks!

johanw666 commented 8 years ago

It works here. BTW, is 3.19.0 just cbbe25c plus a version bump?