search

signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.45k stars 6.1k forks source link

Can't update Signal standalone APK #6740

Closed leedoyle closed 7 years ago

leedoyle commented 7 years ago

I have:

Bug description

I don't have Google Play nor google services so I use the standalone Signal apk. Now I can't update the google-free standalone build from https://signal.org/android/apk/ . In the contact list there is a message saying

Your version of Signal is outdated Your version of Signal will expire in 4 days Tap to update to the most recent version

But when I tap it says:

no such app found

Prior to that Signal had been self-updating without any problems.

johanw666 commented 7 years ago

If the version expires you can update manually from apkmirror.com. They offer the Play Store version but it will work without gms just as the website version so you'll have to download each update yourself.

leedoyle commented 7 years ago

@johanw666 but it's not as secure as downloading the APK directly from the WhispersSystems server and verifying the signature. Besides, the apk I'm using does have a built-in updater, so that's clearly a bug.

johanw666 commented 7 years ago

It is not a bug, it means the apk at the website has just not been updated, and all official apk's expire after 90 days, update available or not. Apparently 90 days is too short for this project, we've had this before with 3.16.1, which was released with only change a version number bump and a new expire date.

moxie0 commented 7 years ago

The APK at the website has been updated (several times) within the last 90 days. Something must be wrong with the updater or the network, but I can't determine what is wrong without a debug log that covers the period of an update attempt.

leedoyle commented 7 years ago

Thanks for your quick response! It just occurred to me the updater might have been tampered with by Xprivacy. Yes, during these 90 days there have been a number of updates. I have seen them downloading or installing ("Signal update downloading" or something of the sort) in notifications menu and was thinking the update applied successfully. Unfortunately, I can't provide such logs as I can't even initiate that update process that I've seen proceeding in notifications menu.

P.S. There were no changes in Xprivacy settings during the last 90 days at all. P.P.S. the same thing happened on my other device, running Android 4.4

moxie0 commented 7 years ago

The update isn't applied "automatically." It will download, and then should prompt you to install (which requires manual approval). Very possible xprivacy interfered there.

johanw666 commented 7 years ago

As a fellow Xprivacy user, I have disabled it for some open source programs I trust. Signal is one of these. You can try that, or check the Xprivacy logfile if it mentions any blocked operation from Signal.

leedoyle commented 7 years ago

@moxie0 I see. I've only seen it downloading, but it didn't prompt me to install.

However, on two phones when I click on the update button, it says

No such app found

Apparently it's trying to make use of Google Store. And this bug doesn't let me pinpoint the earlier issue with failed updates as I can't initiate the update process.

johanw666 commented 7 years ago

Well you can always manually go to https://signal.org/android/apk/ and download the apk from there. Currently it offers 4.6.1.

nrizzio commented 7 years ago

Since this sounds more like an Xprivacy issue than a Signal issue, @leedoyle you should head on over to the community forum and close out this issue.

leedoyle commented 7 years ago

@nrizzio I have reasons to believe they are two separate issues, and the latter ("no such app found" while trying to force update) clearly has nothing to do with Xprivacy. It looks like an attempt to make use of Google Store that I don't have installed. And when this happens, there's nothing relevant in Xprivacy logs.

moxie0 commented 7 years ago

@leedoyle Yes that banner assumes you have Play installed, probably just going to be how it is.

leedoyle commented 7 years ago

@moxie0 well, that's not the behaviour one'd expect from a client that allegedly doesn't depend on Google to perform updates.

moxie0 commented 7 years ago

@leedoyle You should never be in that position to begin with. There's something wrong with the auto update mechanism on your device. It's either a bug in signal, or an xprivacy problem. My experience has been that xprivacy often causes serious problems (fuck with your phone, and fucked up things will happen to your phone), but I can't determine what is going on without a relevant debug log.

natrius commented 7 years ago

While i understand that moxie0 does not like that approach i have to say thanks for the non-google-version and it works like a charm here, it downloads the update and shows me that there is new version available to install. I don't use xPrivacy anymore, but i suggest you remove that one since it doesn't work anymore with android 7. anyways.

micressor commented 7 years ago

I miss the possibility to trigger the update manually.

moxie0 commented 7 years ago

@micressor You should be able to manually update at any time, the APK is here: https://signal.org/android/apk/

I haven't gotten any more details or a debug log on the original issue, so I'm going to close this as an xprivacy problem.

orblivion commented 6 years ago

I actually have the same issue and I don't have xprivacy. Maybe I have something similar? I use Cyanogenmod which has permissions controls, but everything is set to "Allowed" other than "Write SMS DB" which is "Ignored" apparently from lack of use.

orblivion commented 6 years ago

To get a debug log I'd need to set up Android Studio, right?

haffenloher commented 6 years ago

@orblivion Fortunately not. In Signal's settings, tap Advanced > Submit debug log. Done!

orblivion commented 6 years ago

Will it give me the option to review it before sending it?

haffenloher commented 6 years ago

Yes.

orblivion commented 6 years ago

Here you are: https://gist.github.com/anonymous/fcfd901fec47fe1e78ecfe67858975fb

I restarted my phone, and then tried hitting the update button a couple times. That's all the activity that this log should cover. BTW I have F-Droid, and I realized that my "No such app found." popup has the F-Droid logo, in case that's relevant.

haffenloher commented 6 years ago

To see what's going on, Moxie would need a log of the auto update mechanism failing. The auto updater gets scheduled in your log but it doesn't seem to have been executed yet.

orblivion commented 6 years ago

I see. I deliberately restarted my phone to wipe the log before trying the manual update. That's why it doesn't have the auto-update. And it's what, every 6 hours or something? I can try to grab the log first thing in the morning.

moxie0 commented 6 years ago

@orblivion It's scheduled to run at GMT: Thursday, November 16, 2017 5:00:18.320 AM, which is 30min from now.

orblivion commented 6 years ago

Does this have it? It shows one exception at least right upfront.

https://gist.github.com/anonymous/81b733df9146e65ef110b63a739a2a9c

moxie0 commented 6 years ago

@orblivion There are no timestamps in your log, so it's not possible to tell, but if you waited until the morning to capture the log, then it's very unlikely. You'll have to look at when the job is scheduled for, and then capture the log ~60 seconds after that.

orblivion commented 6 years ago

I just connected my phone to WiFi for the first time in a good while, and now I get the Signal update popup. This happened within the last 5 minutes. I don't suppose it was even scheduled to do a check during this time?

So I guess the point is moot for now, for me. Perhaps if I have time one of these days I'll disconnect from WiFi and try to get a log for you. (Is it around 5:00 UTC every day?)

For now, for anybody else having this problem: Try a different Internet connection.

WSLUser commented 6 years ago

Well you can always manually go to https://signal.org/android/apk/ and download the apk from there. Currently it offers 4.6.1

Actually it offers 4.15.5. Both the webpage and the apk file name show 4.15.5. Unless it auto-updates once installed. If that is the case, it would still be best practice to put the latest available version up every time there's an update and it makes a better user experience.

ghost commented 6 years ago

I have the same problem.

A log can be found here. Hopefuylly this one is helpful:

https://gist.github.com/e07df4c0c71a5f0bfd27a292dd8ee2b7

orblivion commented 6 years ago

Yeah, I'm having the same problem again, this time whether or not I'm connected to WiFi. I may try a different WiFi.

micressor commented 6 years ago

@nyxst @orblivion Confirm this. The file is located at

file:///storage/emulated/0/Android/data/org.thoughtcrime.securesms/files/signal-update.apk

but the popup hasn't been coming for months.

ilf commented 6 years ago

I had the same issue, again.

@micressor Thanks, the current release APK (4.17.5) was indeed at that location and - according to the timestamp - has been there for two days. A manual upgrade by clicking on the APK worked just fine. But I never saw a popup asking me for the update.

Instead, I did see Signal crashing with the error AndroidRuntime: android.os.FileUriExposedException: file:///storage/emulated/0/Android/data/org.thoughtcrime.securesms/files/signal-update.apk exposed beyond app through Intent.getData() in log. So, Signal crashes instead of updating.

See #7654 and #7405 for more.

natrius commented 6 years ago

Now i had the same issue, OnePlus 3, LineageOS 15.1, without xPrivacy.

I got the message in Signal itself "Signal not up do date, ...." and was wondering. I downloaded the new .apk directly via the homepage. So, it was working before (See: https://github.com/signalapp/Signal-Android/issues/6740#issuecomment-312273783) and it did not update automatically now.