signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.59k stars 6.13k forks source link

Signal icon does not obey the icon shape setting in Android 8.1 - icon is always circular #7373

Closed cegg1 closed 6 years ago

cegg1 commented 6 years ago

I have:


Bug description

In Android 8.1 the shape of adaptive icons can be set to circle, square, rounded square, "squircle" or teardrop. Signal, however, does not obey the icon shape setting and always shows a circle-shaped icon.

Steps to reproduce

Actual result: The Signal icon remains circular in shape. Other icons do change shape. Expected result: The Signal icon changes shape together with the other icons.

Screenshots

Available settings icon-shape-setting

Results Circle (default) circle

Square square

Teardrop teardrop

Rounded square rounded-square

Squircle squircle

Device info

Device: Google Pixel 2 Android version: Stock Android 8.1.0 - OPM1.171019.013 Signal version: 4.15.5

Link to debug log

cegg1 commented 6 years ago

In case this is relevant, the icon shape is not obeyed in LinageOS 14.1 either. A circular icon would be expected; however, Signal comes out as a square icon. Surprisingly, the square icon does not show in Android 8.1 when it is selected. lineageos Device: Google Nexus 5 Android version: LinageOS 14.1.2 NJH47F Signal version: 4.16.3

cascheberg commented 6 years ago

I had to update targetSkdVersion to 26 to make the adaptive icon work in Android Emulator API 27.

Even then the icon was still not correct, as can be seen in the screenshot below. I created a set of adaptive and legacy icons using the Android Studio Image Asset, shown in the second screenshot.

Notice that the shadow in the icon_transparent.png is different from the shadow in icon.png.

signalsquircle Squircle icon with newer targetSdkVersion

signalsquirclefixed Squircle icon generated by Image Asset Studio

Stanzilla commented 6 years ago

That is https://github.com/signalapp/Signal-Android/issues/6511 that should be reopened. @moxie0

automated-signal commented 6 years ago

GitHub Issue Cleanup: See #7598 for more information.