search

signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.45k stars 6.1k forks source link

Android 8 notification dot does not display until there are multiple threads with unread messages #7580

Closed riyapenn-signal closed 5 years ago

riyapenn-signal commented 6 years ago

I have:

Bug description

On Android 8, the notification dot does not appear on the app icon until there are unread messages in multiple conversations. Notifications still appear in the notification drop down. This issue is only for the app badge/dot that displays on the icon.

Steps to reproduce

Actual result: See notification dot only when there is more than one thread with an unread message Expected result: See notification dot for any unread message

Screenshots

N/A

Device info

User 1

Device: Samsung Galaxy S9 Android version: 8.0.0 Signal version: 4.16.9

User 2 Device: Samsung Galaxy S8 Android version: 8.0.0 Signal version: 4.17.5

User 3 Device: Samsung Galaxy S8+ Android version: 8.0.0 Signal version: 4.16.9

Link to debug log

User 1

One message received, no badge/dot: https://hastebin.com/xoyadaqazo Two threads with new messages and the badge appeared: https://hastebin.com/ixatociwez

User 2 One message received, no badge/dot: https://debuglogs.org/1d1c957eaa4a0e685b55b96a5f29bc49fca4d5c380f3a08f4c5e3f02c3941b56 Two messages received and the badge appeared: https://debuglogs.org/f385f1c6367df132ac06221ca0b238c1058fb1627f9e67d59bdf570f76cd9363

User 3 One message received, no badge/dot: https://hastebin.com/udojuhozic Two messages received and the badge appeared with a count of 2: https://hastebin.com/biwakefoda

MickMickle commented 5 years ago

As described earlier, it was only fixed temporarily for 4.31.4. I don't know if there's any way to get back to that beta version or not.

greyson-signal commented 5 years ago

I noted earlier in this thread that the fix was removed. This thread will be updated when a fix is put back in. Thanks!

thecosmicyes commented 5 years ago

It was mentioned earlier but as some people might not read the whole thread I repeat it: if you are using the Microsoft launcher anyhowe just enable Badge-support for Signal in the launchers settings. This solved the Problem for me. I heard that this ist also possible with the Nova-launcher but did not try it myself.

Edu4rdSHL commented 5 years ago

@thecosmicyes it issue is with Android, not with Microsoft.

thecosmicyes commented 5 years ago

@Edu4rdSHL I just wanted to show a possible workarround. But thanks for the hint.

MickMickle commented 5 years ago

The notification badges are working fine on my Samsung Note 8 native launcher with beta version 4.31.4, and I haven't noticed any other bugs. In Google Play Store, I have unchecked "Enable auto update" because it was a temporary intermediate beta version and is no longer available.

mathsen commented 5 years ago

Same problem on Samsung XCover 4, despite disabled energy saving options for Signal and enabled notifications. When two or more different people send messages the app message indicator appears.

SteveDun commented 5 years ago

I persuaded my 60-strong local hobby club to use Signal groups for our collaboration / conversation recently. The overall response has been very positive, with the very big exception of this badge problem. There is now increasing frustration, and agition to change over to WhatsApp. Can you please help me allay this pressure by indication when a fix for the problem might be available. Personally, I don't want to use WhatsApp, but I am only one in 60 users at the club, and likely to be outvoted if this issue continues much longer.

huettenwirt commented 5 years ago

Same here, many of my friends I persuaded to switch are complaining about the badge problem. Since it was temporarily fixed in a beta version, we would really appreciate a hint on the release date for the fix...

Best regards and keep up the great work! We need an open, secure and free counterpart to WhatsApp & Co.

JessePeden commented 5 years ago

For tracking purposes, the bug is still present in 4.32.7.

MickMickle commented 5 years ago

As posted earlier by @greyson-signal, "In the future, if you're curious, you can go to https://github.com/signalapp/Signal-Android/commits/master to see what version it's in (look for the "Bump version to x.x.x" commits and looks what's underneath them)."
You can check there periodically to see if the issue was fixed and then "bumped" to a new version. For example, you can see that "Bump version to 4.31.4" included "Fix notification badge display," and "Bump version to 4.31.5" included "Revert 'Fix notification badge display'."

SteveDun commented 5 years ago

Still hoping for a response to give an idea of when this bug might be fixed - or even if... I cannot really ask my 60 colleagues to upload a beta version (most of them will not understand what that means!!).

zell-mbc commented 5 years ago

Not sure if any additional evidence is needed but I have 4 devices which show the same behaviour.

mathsen commented 5 years ago

Just saw a bugfix is in the current 4.33.0 release, which should fix this bug - hopefully :tada:

TheShanMan commented 5 years ago

Yeah, that's the same fix that went into the beta. Perhaps the problem that caused him to revert the change last month was found to be unrelated to this change. Glad to see it's back in place! Hopefully this time for good! Thank you, @greyson-signal!

MickMickle commented 5 years ago

Just confirming that I am getting notification badges now with 4.33.0 on Samsung Note 8, Android 8.0.0. (Signal 4.33.0 is beta, so you have to join the beta channel to get it.)

SteveDun commented 5 years ago

Delighted that this bug is fixed and in beta. Look forward to general release, as my group of old codgers don't go for early release versions... Many thanks.

greyson-signal commented 5 years ago

Hey folks, I'm really sorry, but this had to get reverted again. It ended up causing a regression that can be seen in #8598.

So some background: when I first put this fix in, it was late in the beta, and we saw some beta feedback about notifications that made me nervous, causing us to revert it. These issues were different from #8598. But those issues looked like they may have been similar to long-standing issues we've seen from devices with aggressive battery optimizations, so I figured I'd try it again in this beta and see if we saw any trends. Everything looked good -- until I saw #8598. It's a bug directly caused by this fix.

That's the bad news. The good news is that I was spending some time trying to fix this again today, and I think I have a solution that fixes this issue without negative side-effects. But notifications on Android are super finnicky and change in subtle ways in almost every Android release, so I need to do more testing. Since we're starting our production rollout, I can't just throw this in there. But pending additional testing, it'll be in the next beta.

So hold in there! We'll get this fixed.

MickMickle commented 5 years ago

Ok, well. Thanks. I think I'll stay suspended at 4.33.3 with Google Play auto update for Signal disabled. Great explanation, and I appreciate your hard work!

TheShanMan commented 5 years ago

Can't wait for 4.34 then!

Edu4rdSHL commented 5 years ago

It issue is fixed in Signal 4.34.2 without affecting other notifications things. Thank you Greyson.

MickMickle commented 5 years ago

Yep. 4.34.2 works.

MickMickle commented 5 years ago

And, the badge works in version 4.34.6, which is NOT beta.

IanSpam commented 4 years ago

I started getting similar issue with 4.53.7. Just noticed when I am using the PC Signal. My phone notifies me quite fast. Otherwise no notifications arrive until I open app on phone. Seems odd, hope it helps...