Calls always income as missed ones without ringing and Signal doesn't report the call failed

szotsaki commented 6 years ago

Please, report issues only from version 5.6 upwards!

General complaints forum and user help-out on this issue: https://community.signalusers.org/t/make-signal-calls-reliably-ring-on-the-receiver-side/18510

[X] I have searched open and closed issues for duplicates
[X] I am submitting a bug report for existing functionality that does not work as intended
[X] I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
[X] This isn't a feature request or a discussion topic

Bug description

Users are welcome to re-submit bug reports

When Signal is opened in front of me on my phone and via Hangouts PC I hear the other party while his Signal is actually ringing me. My Signal shows no sign that I'm being called. At the end of ringing, when the network automatically disconnects, I immediately receive a "You have a missed call" notification in the chat.

Reproduced on three different WiFi networks with the same person.

The time difference between the two phones is approximately 5 seconds. Both phones are set to synch to carrier time.

Steps to reproduce

Make phone A call phone B in Signal
Observe that phone B gets no notification about the incoming call just the missed one.

Actual result: Call arrives as missed one. Expected result: Phone B rings.

Screenshots

Device info

Device: Sony F5121 Android version: 7.1.1 Signal version: 4.14.10

Link to debug log

Callee debug log: https://gist.github.com/anonymous/9984ab543d85a181b06b02954564c060 Caller debug log: https://gist.github.com/anonymous/5eae662fee114e5e07a72dbd02c0e92d

Original report: #7314

@moxie0:

According to the logs in the issue, the devices are not able to find a valid ICE candidate.

Please, unambiguously tell the user there is an error happening during the call and the call has never been initiated.

References: #7603

Since this bug report is specifically about the non time-sync issue, there's another one for the time-sync problem. Please, don't clog this report with NTP-timing issues anymore but you're more than welcome to add your comments in and subscribe to #9633. Thank you.

gab81 commented 3 years ago

Yep bingo, thats it.

This of course when all is working, as the past days with the surge in users wasnt even possible with Gab's fix hehe

Sent from Android

On Sun, 17 Jan 2021, 19:24 Narayan, notifications@github.com wrote:

For now i will do manual fix: ring once put down, call again. It works usually

Well, this fits with my own experience: After failing to connect, I used to call the other party on WhatsApp or GSM, and tell them that I would be calling them again. This took a few seconds at most. After that, I used to call the same party on Signal. This time my call went through. (But then I ran into another bug, where the "Accept" and "Reject" buttons on the screen are unresponsive.)

After reading this workaround, I tried it. Sure enough, the second call goes through.

So the following method works indeed:

make a dummy call to the same party, and let it ring at least once.

Cut the line (the other party does not receive a ring at all)

Call the same party again. This time the called party gets the ring.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/signalapp/Signal-Android/issues/7733#issuecomment-761857076, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM75AF7U764PP4N2AUKGJU3S2MTPPANCNFSM4E4N37RQ .

szotsaki commented 3 years ago

Guys, please, don't spam this thread with "Me too", "Please fix", "Totally agree 100%", "Bingo", and any other messages which don't add value to the discussion from developers' perspective.

For user help-out, please use the thread at https://community.signalusers.org/t/make-signal-calls-reliably-ring-on-the-receiver-side/18510

Also, the NTP/clock sync issue has a separate bug ticket, feel free to subscribe there: https://github.com/signalapp/Signal-Android/issues/9633 (and please keep any time sync comment out of this thread since they belong there).

gab81 commented 3 years ago

You are right but we are tired of not addressing this very basic functionality of doing an audio call!

Sent from Android

On Sun, 17 Jan 2021, 20:03 szotsaki, notifications@github.com wrote:

Guys, please, don't spam this thread with "Me too", "Please fix", "Bingo", and any other messages which don't add value to the discussion from developers' perspective.

For user help-out, please use the thread at https://community.signalusers.org/t/make-signal-calls-reliably-ring-on-the-receiver-side/18510

Also, the NTP/clock sync issue has a separate bug ticket, feel free to subscribe there: #9633 https://github.com/signalapp/Signal-Android/issues/9633 (and please keep any time sync comment out of this thread since they belong there).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/signalapp/Signal-Android/issues/7733#issuecomment-761862637, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM75AF3S4QNG4DN6PJI2P5DS2MX67ANCNFSM4E4N37RQ .

strugee commented 3 years ago

@gab81 GitHub issues are not a discussion forum. If you don't have any new information to share on this issue, please don't comment. The only thing that does is generate more email for the developers and anybody else subscribed to this issue because they're interested in following progress on it. GitHub does not show how many people are subscribed to an issue but it does show how many people are watching this repository, so I would like to remind you that every time you drop a comment here you're generating emails to over nine hundred people.

Please follow the rules. If you don't, a Signal developer will likely come and lock this issue.

mr-brunes commented 3 years ago

Some info that may be of use - when someone has tried to call me, my desktop Signal (Windows 1.39.5-beta1) says "Incoming audio call..." but my Android app has no indication until the incoming call fails and only then do I see a Missed call notification.

https://debuglogs.org/4a12df1520380ca62ae0a0ad19c712b2cdf241c8430c291e60a9af4839001213 Incoming call estimated about 16:04 (call log doesn't show absolute time on recent calls) on 18-Jan-21.

loxK commented 3 years ago

If that can help, for me too. The desktop app (linux) sometimes rings long before the phone does. Of course Signal is excluded from battery optimization on phone.

r1w1s1 commented 3 years ago

when I call a friend (android phone - xioami) algo doe not ring, just show a call lost.

mr-brunes commented 3 years ago

Some diag info for a failed call this morning to my mother. Beforehand I'd disabled Signal under Optimise Battery Usage on my S10e (Android 10). On my mother's S7 (Android 8) Power Saving mode was Off and Signal was listed under Unmonitored Apps.

On 19-Jan-21 my call to her failed at 10:46. It showed as Missed Call on her end, Then she msgsd me. Then I called her back successfully.

My log https://debuglogs.org/95835987f298755f7efb1dda970d871e336f7f0384ed08f0c445e481d7179530 Her log https://debuglogs.org/c4d69c0ba87a8ed694c469320fe3ba01669a4aabb8a08c2efd20772d579f1e69

gab81 commented 3 years ago

latest Signal version, updated recently on both phones and the usual issue keeps happening.

call once with phone fresh from airplane mode all night > network failed, and other end shows missed call
call back right away and connects OK and call is stable and works fine

i am going to donate some euros now, i really hope this kind of things can help and you can get more developers one day to help solve this issue that is annoying lots of people. Yet as someone said you need to seize the momentum and fix this otherwise it will always remain an app for geeks. Older generation and people that don't care will switch. we really like Signal!

MoctezumaDev commented 3 years ago

There are a few tickets related to the same problem.

https://github.com/signalapp/Signal-Android/issues/10680

https://github.com/signalapp/Signal-Android/issues/9813

https://github.com/signalapp/Signal-Android/issues/8302

https://github.com/signalapp/Signal-Android/issues/8072

I think this ticket should be tag as critical, i think this is an important feature.

Some mention problems related to the clock, I think in my case it might be related to time zones differences. I confirmed it by calling people in my city in Europe without any issues and tried by calling few relatives in North America and no one gets a ring.

StephaneAdeso commented 3 years ago

I have reinstalled the application, synchronized my phone with the current time, and I have done the same with my partner's phone. so in my case it is not clock synchronization problem. calls don't work. my brother has an iPhone and he have the same problem. the really disheartening thing is that this bug has been around since 2018. It's sad to see that Signal absolutely doesn't cares about solving a critical bug in such essential functionality.

BytesOfBinary commented 3 years ago

Can confirm replication of the problem. Calls always show as missed (on the phone [Android 11/Signal 5.3.3]). However, for a call today, it showed up on Signal Desktop, which I accepted on desktop. While on call, the 'missed call' notification popped up on my phone.

BytesOfBinary commented 3 years ago

Follow up to my previous comment: today the missed call notification popped up on my phone first, and then I could see the incoming call notification on the desktop. I accepted and the call went through normally.

Champion0081 commented 3 years ago

Please attach debug logs from both sides so the developers have some inout they can work with.

pon., 25 sty 2021, 20:45 użytkownik Debadatta Bose notifications@github.com napisał:

Follow up to my previous comment: today the missed call notification popped up on my phone first, and then I could see the incoming call notification on the desktop. I accepted and the call went through normally.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/signalapp/Signal-Android/issues/7733#issuecomment-767068791, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIMCQTYYXZ725M6N3VI6H7DS3XC6XANCNFSM4E4N37RQ .

major-mayer commented 3 years ago

I would be more than happy if anyone of the developers would reply to this issue at all (which I don't think they have yet).

There have been posted so many debug logs by various people with different devices, so either this debug logs contain no valuable information, which I doubt, or they have not been reviewed yet. I could understand this, but this issue is so old already and it's a really fundamental one, so a statement would be a great sign that this problem is known to the devs.

ascendingSun commented 3 years ago

Hello Devs,

I have found a reliable way to reproduce this issue using an Android Virtual Device(AVD) and my phone. I will be creating a PR with much more technical details. My PR seems to fix this issue, but there might be wider implications.

Following is a quick list of steps for repro: For this test FCM should be enabled.(All notifications are enabled for app)

Run the latest code in AVD and wait for app launch
Make a test call from a phone to AVD. This call should ring on the AVD as expected.
Press the power button on AVD to push app to background
After some time websockets are disconnected (since FCM is enabled). This usually takes ~ 1 min.
Make a test call from a phone to AVD. You will see 'Network Failed!' on your phone
Now try to call again. This time the AVD receives a missed call notification and phone never rings

After my fix, I still get the 'Network Failed!' error, but on the second attempt the AVD always rings.

mr-brunes commented 3 years ago

Many tx aS for looking at this. However your reproduction of "this issue" does not match my issue. Your post-fix symptoms match my current symptoms i.e. the first call rings then I see Network Failed. The called party sees no ring then sees a Missed Call notification. A second call to them always rings at their end and they answer. This is what others have reported also.

E2A I have seen some improvements in recent days which I've reported in the forum thread above to save cluttering up this tracker.

ascendingSun commented 3 years ago

@mr-brunes In my case the first call goes to Network Failed straight away. The callee does not receive any notification. What you are describing might indded be a separate bug. Seems like there are several factors at play here. I hope my PR can provide a starting point for deeper investigation.

AsamK commented 3 years ago

I just opened another ticket #10870, related to android background restrictions and noticed this issue looks similar. Can you check if you see the following in adb logcat output (it's not visible in the signal debug log ...): Service.startForeground() not allowed due to bg restriction: service org.thoughtcrime.securesms/.service.WebRtcCallService

xyz0o commented 3 years ago

I have samsung s10, recently installed signal on, so did my peers, so technically it is updated. I am not using firewall and when someone calls me there is no pop up call on my phone nor is there any answering button inside the app when I open it! I jus hear the rington from nowhere!! It's so inconvenient that Im thinking of going back to whatsapp just because of signal's impractiaclity. it shouldnt be too difficult to fix this issue as all other apps have this feature easy pisy, right?

Champion0081 commented 3 years ago

In signal for android 5.3.12 release notes we can read about fix regarding missed calls. Can amyone test and confirm if it is fixed? Which issue number was that? Where i can find more information on this?

trochdewei commented 3 years ago

In signal for android 5.3.12 release notes we can read about fix regarding missed calls. Can amyone test and confirm if it is fixed? Which issue number was that? Where i can find more information on this?

Just tried it - nothing has changed. Just display lights up for a few seconds on incoming call - ring still missed.

cawauk commented 3 years ago

Sadly not fixed. I saw the release notes too. Was excited about it. Updated immediately. All my calls still missed.

AsamK commented 3 years ago

The fix in 5.3.12 is for a very specific issue introduced after the outage a few weeks ago: https://github.com/signalapp/Signal-Android/issues/10787#issuecomment-770400688 @trochdewei @cawauk can you provide debug logs (from caller and callee side) and the time when the call started?

K-g-R commented 3 years ago

After update 5.3.12 Signal still missing calls, but only when I'm on mobile network (without wifi).

gab81 commented 3 years ago

Sadly, we have 5.3.12 9 on our phone and this still persists in 2021.

First call no sound didnt ring Called back immediately and works as usual

Seriously, cant you guys copy what whatsapp and telegram are doing? They work every time.

Sent from Android

On Sun, 7 Feb 2021, 15:04 K-g-R, notifications@github.com wrote:

After update 5.3.12 Signal still missing calls, but only when I'm on mobile network (without wifi).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/signalapp/Signal-Android/issues/7733#issuecomment-774679658, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM75AFZEFDSYIOOBXKPUCH3S52MX7ANCNFSM4E4N37RQ .

szotsaki commented 3 years ago

Please, add only information to this ticket which is useful for developers. For any other comments use the forum thread at https://community.signalusers.org/t/make-signal-calls-reliably-ring-on-the-receiver-side/18510.

gab81 commented 3 years ago

Yes what is useful to know is that it does not work and calls do not connect right off the bat, still!!

Sent from Android

On Fri, 12 Feb 2021, 19:35 szotsaki, notifications@github.com wrote:

Please, add only information to this ticket which is useful for developers. For any other comments use the forum thread at https://community.signalusers.org/t/make-signal-calls-reliably-ring-on-the-receiver-side/18510 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/signalapp/Signal-Android/issues/7733#issuecomment-778368635, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM75AFYZZGTPSJZL3JXRTWDS6VYHVANCNFSM4E4N37RQ .

szotsaki commented 3 years ago

I know that this situation is irritating and, as usual with bugs which affect us, you would like it to be fixed as soon as possible. This bug report is open for three years, I know the feeling.

However, adding rant and unnecessary noise into this ticket will not make it fixed faster; you achieve only that it'll be closed and locked from further input. Many people are following this thread for further developments in this topic, therefore please, use the forum for the end-user discussion. I'd like to ask you to post your reply there, many of us are online there as well. Thank you.

doughobbs commented 3 years ago

szotsaki its all well and good stating that:-

"I know that this situation is irritating and, as usual with bugs which affect us, you would like it to be fixed as soon as possible. This bug report is open for three years, I know the feeling."

However this issue is completely fundamental to the app being usable, its far more than just a 'bug' and if Signal are serious about wanting to grow and rival any other platforms out there or indeed ensure themselves any kind of long term survival it needs focus over any other tweak or enhancement, imagine a car manufacturer claiming they will fix the issue of "most of the engines in all our new cars not starting' at some point yet still continuing to sell cars despite new owners complaining!

gab81 commented 3 years ago

Installed latest version available on both phones, release 5.4.7 - same issue as usual.

Trojgarb commented 3 years ago

After update 5.3.12 Signal still missing calls, but only when I'm on mobile network (without wifi).

The same. On my Wiko View there is no problem with receiving calls when WiFi connected, but while being on cellular data there is no calling screen until Signal is turned on. Checked everything and applied all recommendations from Signal's website. Very frustrating especially that Whatsapp or Threema have instantaneous connections.

gab81 commented 3 years ago

Have to say that it seems good for me for a change.

Today didnt use signal yet, so the time sync thing didnt even happen etc. Good!

Just called my wife, both on mobile 4g+ and call worked flawlessly. Tested both phones calling each other, no issue.

It previously happened that on a fresh phone in the morning (we leave airplane mode all night) you would get the missed call.

We are on 5.4.7 android/S8.

Sent from Android

On Fri, 5 Mar 2021, 09:53 Trojgarb, notifications@github.com wrote:

After update 5.3.12 Signal still missing calls, but only when I'm on mobile network (without wifi).

The same. On my Wiko View there is no problem with receiving calls when WiFi connected, but while being on cellular data there is no calling screen until Signal is turned on. Checked everything and applied all recommendations from Signal's website. Very frustrating especially when Whatsapp or Threema have instantaneous connections.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/signalapp/Signal-Android/issues/7733#issuecomment-791268916, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM75AF3RVOGZCBCROVHCHNDTCCLZVANCNFSM4E4N37RQ .

UserX404 commented 3 years ago

@gab81 @Trojgarb There is a "Help wanted" thread in the forum. If someone of you hasn't posted the logs there please catch up with them. This issue is still under observation and devs are trying to find solutions.

gab81 commented 3 years ago

just wanted to confirm that problem seems fixed for us on 5.4.12 Samsung S8

costaht commented 3 years ago

I read some comments about hour being out of sync. I don't know if that's my case but I trying to contact my family abroad (different time zone) and we Never succeed on the first tries. We have to text each other and tell "I'm gonna call you right now" so they can see the call on the notification bar. Version 5.5.5

cody-signal commented 3 years ago

Hey Folks, thanks for sticking with us. We recently pushed some fixes and hopeful changes to calling in the latest 5.6 beta.

I'm hopeful it'll fix some issues for some of you but I believe gremlins are still lurking in calling. So, after updating to the beta, if you are still encountering the issues above please provide updated debug logs and anything interesting about your calling situation. Examples of things that are interesting: phone has non-standard hardware (like no camera), using bluetooth, in a region that has internet restrictions, using a VPN, etc.

strugee commented 3 years ago

@cody-signal I only occasionally experience missed incoming calls, but I do find that I hit bugs quite a bit when calling other people (especially if those people are on iOS). I'm on the beta but most people I know aren't - given this and the changes you rolled out in 5.6, would you expect improved reliability? Or would both parties need to be on the beta to see improvement?

cody-signal commented 3 years ago

@strugee For the classes of issues we worked on in 5.6, I would hope to see improved reliability regardless of platform or version the other parties are using.

strugee commented 3 years ago

That's absolutely fantastic to hear. Thanks for the response!

StephaneAdeso commented 3 years ago

Try disabling the Google Voice assistant ("Hey google"). When I was in the car, and the phone connected with the bluetooth handsfree, I had audio problems with Signal and WhatsApp. Since I deactivated it, it works perfect for me. I have also noticed an improvement in Signal's missed call issues. But that may be my impressions.

loxK commented 3 years ago

@Osolemio44 I have Google Voice assistant disabled and I have the call not ringing issue.

cody-signal commented 3 years ago

I have the call not ringing issue.

@loxK Could you update to the latest beta and share a debug log after experiencing the issue?

https://community.signalusers.org/t/beta-feedback-for-the-upcoming-android-5-6-release/30590 or 5.7

herrvebah commented 3 years ago

I've had this issue consistently for months and it just happened again 10 minutes ago.

Signal is active, notifications are enabled, no power saving on, active wifi connection. My colleague tells me in Slack he's gonna call. A few minutes later I get a missed call notification from Signal, but there was never an incoming call.

Device info Device: Samsung Galaxy S10

Android version: Tmobile/Samsung Android 11

Signal version: 5.5.5

App state Signal messages and calls registered, SMS disabled, all notifications enabled

Link to debug log

https://debuglogs.org/3ca9e81f1ba5986faea350abe0231b540a5054e28ec3c764030dfb1e4b6030fd

cody-signal commented 3 years ago

I've had this issue consistently for months and it just happened again 10 minutes ago.

Thanks for the report @herrvebah and the debug logs, it looks like in your case the message there was a delay in delivering/processing the push notifications indicating you were receiving a call. Would you be willing to submit additional logs via the instructions in https://community.signalusers.org/t/help-needed-share-an-android-bug-report-to-help-debug-notifications/27739 ?

mr-brunes commented 3 years ago

Just seen this issue again but not had it for ages. Callee's phone did not ring first time round. Will attempt to obtain android bug report too. https://debuglogs.org/0bbb9d4827c3236eeee7b703d08e34b74e401e94902d877ae4b14b10ffdf2479

E2A android bug report sent to greyson-signal as per above instructions.

cody-signal commented 3 years ago

Just seen this issue again but not had it for ages. Callee's phone did not ring first time round. Will attempt to obtain android bug report too.

These logs are from 5.5.5, try updating now that 5.6.x is available in production anyone should be able to get the version. Also know if the logs are from the caller or callee is helpful to know :)

mr-brunes commented 3 years ago

Ok I'll ask my mother (the callee) to update the app manually. The logs and bug report are from her phone (S7 SM-G930F). I've submitted logs before (S10e SM-G970F).

costaht commented 3 years ago

Here are my logs with two lost calls. We are in different timezones, so the event happened at 20:14 on the caller phone and 21:14 on the callee phone

Caller https://debuglogs.org/f948d54643eba9c83e3ac406159a090e5ba5c17ae34870353944ade7a4c4848d

Callee https://debuglogs.org/57b3574a38580a571f35b87fd2790677f2bae37479a503675bf03f135a7b0dba

I hope it helps.

cody-signal commented 3 years ago

I hope it helps.

Thanks, these are very helpful.

signalapp / Signal-Android