signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.54k stars 6.12k forks source link

Duplicate emoji in emoji list. #7749

Closed Edu4rdSHL closed 2 years ago

Edu4rdSHL commented 6 years ago

Bug description

In the emoji list there are several repeated emojis.

Steps to reproduce

Actual result: There are some repeated emojis Expected result: Don't repeated emojis

Screenshots

photo_2018-04-30_14-41-37 photo_2018-04-30_14-41-33

Device info

Device: Samsung Galaxy SM-G570M Android version: 7.0 Signal version: 4.19.3

Link to debug log

I think that it don't need debug log.

link2xt commented 6 years ago

These are not duplicate, but generic/male/female. The problem is, male and generic are the same. See, for example: https://emojipedia.org/swimmer/ https://emojipedia.org/man-swimming/ and https://emojipedia.org/woman-swimming/

Edu4rdSHL commented 6 years ago

Thank @labdsf. Anyways i think that generic emojis aren't necessary and can cause confusion, Signal is the only app in which I am experiencing that.

link2xt commented 6 years ago

I would say that "male"/"female" emojis are not necessary and leave the generic one instead. The fact that it is the same image as "male" on most platforms is not the application problem. "Male swimmer" is a combination of "swimmer" and "male sign", after all. Telegram also supports "skin tone" modifiers, available on long press, and Signal doesn't, by the way.

In any case, the problem is identified, I am going to stick with ASCII emojis.

Edu4rdSHL commented 6 years ago

@labdsf thank you for explain me. We can wait for the opinions of the developers.

johanw666 commented 6 years ago

How about this flag that is double: signal

link2xt commented 6 years ago

These are https://emojipedia.org/flag-for-us-outlying-islands/ and https://emojipedia.org/flag-for-united-states/

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

link2xt commented 2 years ago

This stale bot is annoying, second time it annoys me in a week.

alex-signal commented 2 years ago

These sheets are auto-generated via a script. I can see what the others think of deduping things but it's likely something we'd need to do manually and might be a pain to maintain. (imagine if they altered some variant to look different from generic, and we'd never really have a way of knowing besides people noticing and complaining.)

link2xt commented 2 years ago

Non-system NB emojis are grey instead of blue now, so maybe the problem is solved already, at least the original one. No idea about the US flag.

alex-signal commented 2 years ago

The US flag is actually 2 separate flags for 2 separate places, they just look the same. Since the problem is solved, I'll close this out.