cannot update standalone signal apk

ijackson commented 6 years ago

[x] I have searched open and closed issues for duplicates
[x] I am submitting a bug report for existing functionality that does not work as intended
[x] I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
[x] This isn't a feature request or a discussion topic

Bug description

My Signal, which I installed from the APK on the signal.org website, does not update. It displays a notification saying a new version is available, but tapping on the notification does nothing.

Steps to reproduce

obtain a Fairphone 2 and put Fairphone Open OS on it (so, no Google Play etc.)
go back in time 6 months and install Signal from the signal.org website
do at least one Signal update, so now running 4.19.3
now observe that Signal knows it wants to update but is able to do so

Actual result: Notification about update is displayed, Tapping it does nothing. No way to get rid of the notificiation AFAICT.

Expected result: Tapping the notification should update Signal. Dismissing the notification should make it go away for a while at lest.

Device info

Device: Fairphone 2 Android version: 6.0.1, FPOOS 18.04.1 Signal version: 4.19.3

Link to debug log

https://debuglogs.org/87122f89047138d9a773947e97591d313ed0c3aa9007dfe3db2fc3479f5cfc3c

jtn20 commented 6 years ago

I'm experiencing the same issue (with a very similar setup).

I don't see any obvious network traffic at the point when I tap the "A new version of Signal is available, tap to update" notification, for what it's worth.

ijackson commented 6 years ago

This undismissable pointless notification is quite a nuisance; particularly, the way that from the lock screen it is indistinguishable from receiving an actual message. If I don't hear to the contrary in the next few days, I intend to update my Signal from the website apk. That will mean, I think, that I will no longer be a test case for this bug.

jtn20 commented 6 years ago

The following output in "adb logcat" appears correlated with me tapping the update notification; don't know if it sheds any light.

...
06-28 10:13:28.943  7979  7979 D StatusBar: Clicked on content of 0|org.thoughtcrime.securesms|666|null|10075
06-28 10:13:28.948  6826  8877 I ActivityManager: START u0 {act=android.intent.action.VIEW dat=content://org.thoughtcrime.securesms.fileprovider/external_files/signal-update-1.apk typ=application/vnd.android.package-archive flg=0x10000001} from uid 10075 on display 0
06-28 10:13:28.960  6826 13699 W InputMethodManagerService: Window already focused, ignoring focus gain of: com.android.internal.view.IInputMethodClient$Stub$Proxy@85937d7 attribute=null, token = android.os.BinderProxy@e35ae08
06-28 10:13:29.418  7979  7979 D PhoneStatusBar: disable: < expand icons* alerts system_info* back home recent clock search quick_settings >
...

ijackson commented 6 years ago

FTR, I updated by downloading the apk from the website and now (as expected) the undismissable notifcation is gone. I guess I will see if it comes back next time there is a Signal update.

alxndr42 commented 6 years ago

It's still there. I updated manually to 4.21.6 the last time and I just started to see the broken notification again.

jtn20 commented 6 years ago

My Signal app, still on 4.19.3, continued the same behaviour I described before. Today it progressed to displaying a new message in the main app:

Your version of Signal is outdated Your version of Signal will expire in 9 days. Tap to update to the most recent version.

Needless to say, tapping didn't work, but it did display a toast "No such app found." whenever I tapped it.

logcat says the following when I tap this new notification:

07-16 08:40:52.450  7737 22061 I ActivityManager: START u0 {act=android.intent.action.VIEW dat=market://details?id=org.thoughtcrime.securesms cmp=org.fdroid.fdroid/.views.main.MainActivity} from uid 10075 on display 0
07-16 08:40:52.467 11511 11511 W PassphraseRequiredActionBarActivity: onPause()
07-16 08:40:52.479 11511 11511 W KeyCachingService: onStartCommand, org.thoughtcrime.securesms.service.action.ACTIVITY_STOP_EVENT
07-16 08:40:52.479 11511 11511 W KeyCachingService: Decrementing activity count...
07-16 08:40:52.479 11511 11511 W MessageRetrievalService: Active Count: 0
07-16 08:40:52.512  7737  9569 I ActivityManager: START u0 {cmp=org.fdroid.fdroid/.AppDetails2 (has extras)} from uid 10060 on display 0
07-16 08:40:52.548  7737  8928 W ActivityManager: Duplicate finish request for ActivityRecord{a939036 u0 org.fdroid.fdroid/.AppDetails2 t831 f}
07-16 08:40:52.555 11511 11511 W PassphraseRequiredActionBarActivity: onResume()
07-16 08:40:52.611  7737 16691 W InputMethodManagerService: Window already focused, ignoring focus gain of: com.android.internal.view.IInputMethodClient$Stub$Proxy@87eb609 attribute=null, token = android.os.BinderProxy@ff42826
07-16 08:40:52.611 11511 11511 W KeyCachingService: onStartCommand, org.thoughtcrime.securesms.service.action.ACTIVITY_START_EVENT
07-16 08:40:52.611 11511 11511 W KeyCachingService: Incrementing activity count...
07-16 08:40:52.613 11511 11511 W MessageRetrievalService: Active Count: 1

This device has F-Droid installed as an app store (which doesn't have Signal, of course), and doesn't have Google Play or any other app-store-like thing installed, so I guess the invocation of a "market:" type URI isn't going to go well.

I don't want my Signal to expire, so I have now given up waiting for someone to show interest in the state of this device; I've upgraded to the current APK (4.23.4) by hand, and will continue with such upgrades if the problem persists.

stspdotname commented 6 years ago

Same problem seen here, also with Fairphone 2 running the 'Fairphone Open Source OS'.

neeels commented 6 years ago

I'm seeing the same thing; also on FP2 with open OS. Only way to update is to again and again install the website apk whenever there is an update, very annoying ... and presumably unsafe? (Would welcome to see signal in F-Droid instead, just saying without having investigated the reason for it not being in F-Droid.)

alxndr42 commented 6 years ago

Updates to installed APKs have to be signed with the same key, AFAIK. But it sure is annoying to manually download each update. F-Droid is not happening thanks to Moxie.

johnmanko commented 6 years ago

I couldnt find an APK on the Signal site. Perhaps they are just hiding it very well.

@7adietri Can you explain "F-Droid is not happening thanks to Moxie"?

neeels commented 6 years ago

On Sat, Oct 13, 2018 at 06:01:32PM -0700, John Manko wrote:

I couldnt find an APK on the Signal site. Perhaps they are just hiding it very well.

Don't ask me how I found it: https://signal.org/android/apk/

~N

stspdotname commented 5 years ago

Thank you very much for your work @greyson-signal ! Very much appreciated. Auto-update is working fine again on my FP2.

ialokim commented 5 years ago

Thanks a lot @greyson-signal!

gityeti commented 5 years ago

Thanks for your great work! Till now I had no problems. This time : I cannot update : Notification about update is displayed, tapping it does nothing. 4.31.7 --> 4.31.8 FP2 Android 8.1.0 LineageOS 15.1-20190107-microG-FP2

chrisdane commented 4 years ago

Same here on FP2 Android 7.1.2 Fairphone Open 19.02.1: If I click on "update" it says No such app found and nothing happens. Had to download the .apk and install manually to Signal 4.50.5.

signalapp / Signal-Android