Received vcards are not imported to contacts

signalapp / Signal-Android

A private messenger for Android.

https://signal.org

GNU Affero General Public License v3.0

25.62k stars 6.15k forks source link

Received vcards are not imported to contacts #8560

Closed tosborne1215 closed 2 years ago

tosborne1215 commented 5 years ago

[x] I have searched open and closed issues for duplicates
[x] I am submitting a bug report for existing functionality that does not work as intended
[x] I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
[x] This isn't a feature request or a discussion topic

Bug description

vcards are not properly handled within the Signal Android app.

Steps to reproduce

Receive a vcard. Note that there is no way to import it to your contacts.

Actual result: Displays the vcard format in plain text Expected result: Prompt to import contact

Device info

Device: Pixel XL 3 Android version: 9.0.0 Signal version: 4.32.8

A9G-Data-Droid commented 5 years ago

I have been using Signal since the early TextSecure days. It has come a long way since then and I would expect this to have been handled by now. Every time I get a VCARD I come to check if there is progress. Is there a clear technical reason that it is not handled? Or is it just a matter of somebody write some code?

tosborne1215 commented 5 years ago

I'm pretty sure there is not a technical issue. I did find an old issue that was closed which indicated someone had built this in a fork but it was never made ready for merge.

A9G-Data-Droid commented 5 years ago

@tosborne1215 Can you find the fork? We could extract the code, review it, and make a PR. I would help if you can find the code.

mlissner commented 5 years ago

See also: #535, #922, #1407, #2504, #4205, #5612, #6520. Wow.

Skimming through all of the issues, it doesn't look like there's any reason not to do this that's been voiced. It's just a matter of it needing to get done somehow.

Mountaineer1024 commented 5 years ago

@tosborne1215 Can you find the fork? We could extract the code, review it, and make a PR. I would help if you can find the code.

Here's the other guys branch, but it's 5 years out of date: https://github.com/payload/TextSecure/tree/sharing-contact-1407

A9G-Data-Droid commented 5 years ago

Thanks @Mountaineer1024. That leads to this PR: https://github.com/signalapp/Signal-Android/pull/1695

Looks like it may have been close but not entirely ready for merge.

cpholt commented 4 years ago

Came here to say that this issue, now open and unresolved for years, has kept me from recommending Signal to others. And it's now aggravating enough that I have reached my own limit of tolerance for it.

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

A9G-Data-Droid commented 2 years ago

This was closed by #9667 which wasn't merged by GitHub so this issue wasn't automatically closed. It is safe to close now. Thank you.

EDIT: The commit is here https://github.com/signalapp/Signal-Android/commit/1116502bc0900763e0194be574908325471e00d2