Inconsistent display of date labels (landscape - portrait switching) - Githubissues

signalapp / Signal-Android

A private messenger for Android.

https://signal.org

GNU Affero General Public License v3.0

25.53k stars 6.12k forks source link

Inconsistent display of date labels (landscape - portrait switching) #8583

Closed pankarlox closed 5 years ago

pankarlox commented 5 years ago

[ x] I have searched open and closed issues for duplicates
[ ] I am submitting a bug report for existing functionality that does not work as intended
[x ] I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
[ x] This isn't a feature request or a discussion topic

Bug description

When I click on a conversation with one of my contacts in Signal, the message dates are displayed correctly in the middle of the screen. After switching to landscape mode the dates are displayed on the side of the screen. If I return to portrait mode, the dates 'escape' from the screen.

This issue has already been described here. Unfortunately, nothing has changed since then and the error still exists.

Screenshots

I open conversations. Date is displayed correctly.

signal-attachment2

I turn my phone into landscape mode. The date is in the wrong place.

signal-attachment3

When I return to portrait mode the date 'escapes' from the screen.

signal-attachment

Device info

Device: Samsung Galaxy S9 Android version: 9.0 Signal version: 4.32.8

AND

Device info

Device: Samsung Galaxy A5 2016 Android version: 7.0 Signal version: 4.33.0 (beta)

C-Higgins commented 5 years ago

Can reproduce this on Galaxy S8, Signal 4.32.8, Android 8.0

greyson-signal commented 5 years ago

Fixed this in the next release branch. Thanks!

siccovansas commented 5 years ago

Great! Does this also fix #7846 (and the pull request and issue mentioned there)?