signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.63k stars 6.15k forks source link

Messages with audio attachments can't be selected by tapping the audio player #8702

Open Herohtar opened 5 years ago

Herohtar commented 5 years ago

Bug description

When a Signal message contains an audio attachment, the message can only be selected by long-pressing outside the audio player; anywhere within the bounds of the audio player will be ignored. Furthermore, this also prevents selection during multi-select mode -- if you tap inside the audio player, the tap is completely ignored and the message will not be selected. This presents as more of a problem if the message contains only an audio attachment and no text, in which case the only valid area is the blank space outside the chat bubble.

Steps to reproduce

OR

Actual result: Long-press or taps are ignored when inside the audio player Expected result: Message is selected when long-pressing the audio player, or multi-selected when tapping the audio player with another message already selected

Device info

Device: Pixel 2 XL Android version: 9.0 Signal version: 4.35.3

Link to debug log

N/A

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Herohtar commented 2 years ago

This is partially resolved: when you are in multi-select mode you can tap anywhere to select/deselect audio messages, but you still can't initiate a select by long pressing on the audio player.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Herohtar commented 2 years ago

Still not fully resolved.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Herohtar commented 2 years ago

So the current state of the issue is, long pressing on the audio play button will bring up the context menu, so that's an improvement, but long pressing on the audio waveform does not, even though the entire message "sinks" like it is being tapped. I guess this is so that you can scrub the audio player, but if that is the intended design, then the message bubble needs to not play the "sinking" animation that indicates it is being pressed.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Herohtar commented 2 years ago

Still an issue.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Herohtar commented 2 years ago

Also still an issue.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Herohtar commented 1 year ago

Still an issue, as described here: https://github.com/signalapp/Signal-Android/issues/8702#issuecomment-1145091871

cody-signal commented 1 year ago

I've made an internal ticket for us to take a look at this.