search

signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.65k stars 6.16k forks source link

YouTube link previews not loading. #9086

Closed schmeat closed 3 years ago

schmeat commented 5 years ago

Bug description

Link preview fails to load every time a youtube video is pasted in.

Steps to reproduce

Copy a youtube link and wait for preview to fail loading.

Screenshots

https://gfycat.com/wateryunhappycommabutterfly

Device info

Time : 1570681676210 Device : samsung SM-G975W (beyond2qltecs) Android : 9 (G975WVLS2ASI6, PPR1.180610.011.G975WVLS2ASI6) ABIs : arm64-v8a, armeabi-v7a, armeabi Memory : 68M (23.08% free, 512M max) Memclass : 256 OS Host : 21HHAD01 First Version: 530 App : Signal 4.48.16 (5452)

Link to debug log

https://debuglogs.org/f132028ab42abbc37ed834e8a8b7d276d43d6f970f34db28694284c58186f69a

jgspratt commented 4 years ago

It started happening to WhatsApp users a few days ago, and some of them are finding their way here because they don't know which app they are using.

On Wed, Jul 22, 2020, 12:37 trafenrest notifications@github.com wrote:

This issue is occurring again. Can someone please help debug this.

It was never gone

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/signalapp/Signal-Android/issues/9086#issuecomment-662558871, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI63K4EVBDZDDRUOFVGMJDR44IS7ANCNFSM4I7HW5VA .

sougatc commented 4 years ago

It started happening to WhatsApp users a few days ago, and some of them are finding their way here because they don't know which app they are using.

On Wed, Jul 22, 2020, 12:37 trafenrest notifications@github.com wrote:

This issue is occurring again. Can someone please help debug this.

It was never gone

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/signalapp/Signal-Android/issues/9086#issuecomment-662558871, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI63K4EVBDZDDRUOFVGMJDR44IS7ANCNFSM4I7HW5VA .

I dropped a tweet to the Head of Products at YouTube and Whatsapp in hope that they might notice but it didn't yield any attention unfortunately. Screenshot_20200722-234045.jpg

an0n7mous3 commented 4 years ago

This isn't the place to talk about Whatsapp.

This issue is still ongoing on Signal. Could I suggest giving users the option to source link previews from their own IP, rather than the Signal proxy which hasn't worked for over 10 months now?

ioistired commented 4 years ago

@an0n7mous3 this has been discussed before

an0n7mous3 commented 4 years ago

@an0n7mous3 this has been discussed before

I'm aware, I read through this thread. This reply rebuts that stance quite well. Giving users the option to source previews locally could easily come with a privacy disclaimer. I don't see how it could be an issue.

asbjornu commented 4 years ago

@iomintz, it has also been strongly rebutted before: https://github.com/signalapp/Signal-Android/issues/9086#issuecomment-620171884. The argumentation has no technical merit and in the end should be a user choice.

mueller-ma commented 4 years ago

This can be closed now. Link previews don't use the proxy anymore that caused this issue.

trafenrest commented 4 years ago

When will this be effective? I don't see any change yet and propose to close it when the effect is visible.

nanowinner commented 4 years ago

It has finally happened!

Screenshot_20200821_152754_org thoughtcrime securesms

Ralms commented 4 years ago

It has finally happened!

What OS and Signal version is that? I've checked both Windows and Android and the issue persists.

Ralms commented 4 years ago

Ok, had an update for Android, I can confirm that it's working on Signal version 4.69.4 on Android. On Windows Desktop still waiting on the update, works receiving previews from Youtube, but other websites doesn't work receiving on Windows Desktop.

nanowinner commented 4 years ago

It has finally happened!

What OS and Signal version is that? I've checked both Windows and Android and the issue persists.

Screenshot_20200821_160739_org thoughtcrime securesms

mueller-ma commented 4 years ago

AFAIK support for link previews of all pages is in

ioistired commented 4 years ago

Hopefully YouTube specifically doesn't break again.

ioistired commented 4 years ago

@iomintz, it has also been strongly rebutted before: #9086 (comment). The argumentation has no technical merit and in the end should be a user choice.

I gave it some more thought and I agree with you. Ultimately it's better for the user this way. I noticed that if I wanted to send someone a link to e.g. a Twitter post , given the choice between telegram and signal I picked the less private option. For a lot of people I imagine it's the same. Anyway thanks for your arguments 👍

Mhowser commented 4 years ago

YouTube preview are not working again Signal version 4.72.5 IMG_20201019_160629 IMG_20201019_160950

I still think we should have the option to load the preview locally, with a privacy disclaimer. Help us casual users out!

ioistired commented 4 years ago

They are loaded locally now @Mhowser. It didn't work for you because SMS doesn't support link previews at all.

Mhowser commented 4 years ago

Wow didn't know that, thanks for clearing that up.

sougatc commented 3 years ago

Hi The issue seems pop up again. Found this on twitter it seems the issue is at Whatsapp end. 20201214_001028.jpg

Ralms commented 3 years ago

Hi The issue seems pop up again. Found this on twitter it seems the issue is at Whatsapp end. 20201214_001028.jpg

LOOOOL and what does WhatsApp bugs have to do with Signal?

trafenrest commented 3 years ago

I have no problems with that on signal. I don't use whatsapp. This isn't the place to talk about Whatsapp.

Ralms commented 3 years ago

Probably you should go through the thread to understand what is being discussed.

You clearly need to do that, as you are clearly very confused on how software works. This issue doesn't happen anymore in Signal for a few months since the apps where updated with a new implementation.

On top of that, Signal and WhatsApp have NOTHING to do with each other, they are completely independent applications.

Sorry of these couple lines was too much for your understanding.

sougatc commented 3 years ago

Probably you should go through the thread to understand what is being discussed.

You clearly need to do that, as you are clearly very confused on how software works. This issue doesn't happen anymore in Signal for a few months since the apps where updated with a new implementation.

On top of that, Signal and WhatsApp have NOTHING to do with each other, they are completely independent applications.

Sorry of these couple lines was too much for your understanding.

I have removed the post. Hope that helps. For future, a word of advice, you could have conveyed the same in your first response rather than making fun. But I guess it's too much to ask for !

sougatc commented 3 years ago

I have no problems with that on signal. I don't use whatsapp. This isn't the place to talk about Whatsapp.

Have removed the post. Apologies for the inconvenience. Hope that helps

Ralms commented 3 years ago

Probably you should go through the thread to understand what is being discussed.

You clearly need to do that, as you are clearly very confused on how software works. This issue doesn't happen anymore in Signal for a few months since the apps where updated with a new implementation. On top of that, Signal and WhatsApp have NOTHING to do with each other, they are completely independent applications. Sorry of these couple lines was too much for your understanding.

I have removed the post. Hope that helps. For future, a word of advice, you could have conveyed the same in your first response rather than making fun. But I guess it's too much to ask for !

And I did, I asked what does WhatsApp has to do with Signal. Remember what your reply was? As I was the one confused.

greyson-signal commented 3 years ago

I believe the original issue has been resolved.

quad-u commented 1 month ago
image

This is still occurring on iOS, Android and the macOS app.