signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.67k stars 6.16k forks source link

Override Do Not Disturb doesn't work for Calls. #9297

Open ghost opened 4 years ago

ghost commented 4 years ago

Bug description

Override Do Not Disturb doesn't work for calls. No vibration during call. For messages everything work fine.

Steps to reproduce

Actual result: Call starts, but without vibration or sound. Expected result: Call starts with vibration and sound.

Screenshots

Device info

Device: Xiaomi Redmi Note 4x Android version: 9.0 Signal version: 4.52.4

Link to debug log

https://debuglogs.org/9996396016ef7a34575215d7cc783c8ed788614b0cdb927ae9a48a4fca91015f

longspell commented 3 years ago

I having the same issue, enabling "override do not disturb" does not work, when phone is set to ring there is no ring and when set to vibrate there is no vibration.

Signal 5.3.10 Pixel 4 XL Android 11

Debug logs: https://debuglogs.org/9035130bdcfa52a19ffe8e6cbbc8583c9d4e2631f03e1fa0b4a7ab5e1351c42f

fschlatt commented 3 years ago

Same issue, exceptions for messages and calls are activated in the do not disturb settings. Messages vibrate, calls completely silent. With do not disturb off calls work fine.

Signal 5.14.5 Pixel 4 Android 11

Screenshot (Jun 25, 2021 21:42:52)

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

longspell commented 2 years ago

This is still revelant. Setting the calls notification to override Do Not Disturb doesn't work and the notification is is silent. Disabling DND the notification comes in with the configured sound.

Pixel 6 Pro, android 12, January update (build SQ1D.220105.007)

mboruta1 commented 2 years ago

Encountering the same issue with Signal 5.30.6 on an LG v20 running 8.0.0.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

longspell commented 2 years ago

Can confirm this is still happening. Noticed today when do not disturb is disabled that the ring tone selected in system notification settings is not the one that plays, there is a separate configuration in the app with another sound for calls that is played.

Pixel 6 Pro on Android 12 (5 April security patch), signal version 5.35.3.

tobiscode commented 2 years ago

Happening here as well, Pixel 6, Android 12, (5 April security, 1 January Google Play updates), Signal 5.40.4 (although this hasn't worked for me at anytime in the past that I remember).

holocronweaver commented 2 years ago

Affecting me as well.

Device: Pixel 4 XL Android: 12; June 5, 2022 (also did not work on 11 iirc) Signal: 5.40.4

As others mentioned, Signal message notifications can get through if permitted under Android DoNotDisturb, but not call notifications. Have tried both allow all call notifications in DND settings as well as allowing "highlighted conversations" (all of which Signal conversations), neither allowed incoming call notifications.

This should be a high priority item, regularly results in missed calls on Android for anyone who uses DND (e.g., most working people and activists with Android phones).

samsapti commented 2 years ago

When can we expect this to be fixed?

tobiscode commented 2 years ago

Since it just happened to me again, here's a debug log: https://debuglogs.org/android/5.49.4/4d297599a938df770cdcf9bd0a9cc99db1a2b8ddcb49723ce525a5085df4198a

voxelv commented 2 years ago

I've only ever had this issue. It's not intermittent.

medakk commented 1 year ago

Happens to me all of the time, but it vibrates once (doesn't ring) when I receive a call

Signal 6.5.6, Pixel 6a with Android 13 Dec 2022 update

cody-signal commented 1 year ago

Hi folks, the reason for this is we don't use the notification to play the ringtone or vibrate. We do it manually. We have to do this so we can play different ringtones for different callers.

We've talked about changing this behavior and essentially creating call channels for every contact you customize but it's not something we have scheduled to work on. However, given this and other issues we've encountered recently we may have to go that route.

samsapti commented 1 year ago

@cody-signal AFAIK that's the way the AOSP SMS app does it when you customize notifications for a contact, so that sounds like a sensible idea. Thanks for working on this!

graywolf-at-work commented 1 year ago

Is there some workaround in the mean time? Even if I allow all notification times for the Signal app, it still does not ring. Is the only option currently to turn off the DND mode?

AmirGamilDev commented 1 year ago

Same here.

Device: Samsung Galaxy A52s 5G Android version: 13 Signal version: 6.13.7

Other apps seem to handle it well. Google Meet works exactly as expected accounting for contacts only/favourites only and repeat callers. WhatsApp handles it less well then Meet but still not bad. Would love to see Signal handle this the best 😉

tobiscode commented 1 year ago

Cross-referencing this post: https://github.com/signalapp/Signal-Android/issues/7733#issuecomment-1529811508

@nicholas-signal @cody-signal how will dropping the telecom component affect this issue? Can we hope that dropping telecom will free up resources to address the DND malfunction?

tobiscode commented 1 year ago

Any update on this?

(I can't believe how old this issue is - does it just not affect everyone or is my use case that niche?)

graywolf-at-work commented 1 year ago

Any update on this?

(I can't believe how old this issue is - does it just not affect everyone or is my use case that niche?)

If nothing else, I am affected as well, but based on an age of this issue, I somehow think that pinging "me too" here will do no good anyway, so I just suffer in silence.

But the suffering is decreasing over time, since people learned to not call me over signal (since I do not pick up due to this bug), but instead via the regular phone call. ¯\_(ツ)_/¯

AmirGamilDev commented 1 year ago

Still happening for me too. Other apps seem to handle it okay. Perhaps a similar approach could be done?

silly-rabbit-tricks commented 1 year ago

If nothing else, I am affected as well, but based on an age of this issue, I somehow think that pinging "me too" here will do no good anyway, so I just suffer in silence.

A bit dramatic, but I like it. For what it's worth, I'm also anxiously waiting for this to be fixed.

holocronweaver commented 1 year ago

@cody-signal If it comes down to ringtone per contact vs. not missing a call, I hope reliability triumphs over aesthetic. For a communication app, reliability should be priority 1.

silly-rabbit-tricks commented 1 year ago

If I'm understanding correctly, if Signal were to use Android system notification channels, then Signal contacts would still have custom ringtones based off the system contacts.

True, you couldn't set custom, Signal specific tones, but contacts would still have their own tones based off their system contact settings. Seems more streamlined doing it that way anyways not to mention having DND work properly...

maxonb commented 1 year ago

Im having the same issue.

It seems that signal app is checking dnd settings and then in addition to this checks ringer mode which is set to silence automatically if dnd is enabled (due to weird android api design). This blocks the ring sound and vibration.

Phone: Samsung s22+ Android version: 13 Signal version: 6.26.4

maxonb commented 1 year ago

Hi folks, the reason for this is we don't use the notification to play the ringtone or vibrate. We do it manually. We have to do this so we can play different ringtones for different callers.

We've talked about changing this behavior and essentially creating call channels for every contact you customize but it's not something we have scheduled to work on. However, given this and other issues we've encountered recently we may have to go that route.

It seems that NotificationManagerCompat supports displaying notifications with custom individual sounds. It maybe an alternative solution to per contact channels.

cody-signal commented 1 year ago

Hi folks, still on our radar, made a note to chat about this at our next sync session.

silly-rabbit-tricks commented 1 year ago

Do forgive our (or maybe just my) impatience... are there any updates here? :-)

Edit: Actually asking about a 3.5+ year old issue may not qualify as impatience.... maybe. (Mild humor - but seriously, thank you for all the work you guys put in to this project.)

cody-signal commented 1 year ago

No update, still on our radar.

amrbekhit commented 10 months ago

Hi, just wanted to confirm this is still an issue. Running Signal 6.42.3 on Android 13.

voxelv commented 8 months ago

The failure to fix this issue for 4 years leads me to believe Signal is less than "fun, dependable, and available to everyone."

AmirGamilDev commented 8 months ago

Better than WhatsApp. It doesn't respect DND setting and there's no option to do anything about it! Annoying in a different way.

I agree this bug deserves some attention though.


Sent from my phone. Please excuse typos.

On Tue 5 Mar 2024, 06:43 voxelv, @.***> wrote:

The failure to fix this issue for 4 years leads me to believe Signal is less than "fun, dependable, and available to everyone."

— Reply to this email directly, view it on GitHub https://github.com/signalapp/Signal-Android/issues/9297#issuecomment-1978064595, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALOUG5M7KB2ZH6I62PO2V5DYWVSP3AVCNFSM4J6KS3X2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJXHAYDMNBVHE2Q . You are receiving this because you commented.Message ID: @.***>

tobiscode commented 6 months ago

Well I didn't think I'd get to this topic in this way but here we are: Now I've experienced two situations where with DND on and Signal not in the list of approved exceptions, I've got calls ringing loudly. Did anything change in the codebase that shifted this behavior? I didn't see anything mentioned in the changelogs but obviously this is just as wrong than the original behavior...

If I remember correctly, Signal uses some sort of media player API for calls - if that is for ringing as well, maybe it went through DND because Android thought it was a media sound like from a game or video? I might have time to test this hypothesis in the coming days but wanted to check in here first in case there were changes I missed.

Nojevah commented 3 weeks ago

I've just experimented that strange behavior. With DND enabled and no exception, phone ringed loudly and screen stayed off. Super weird situation. First time I had an app not respecting DND. Only "Alarms" and "Media sound" are authorized, so I guess Signal used one of these ("Alarms" I guess), without waking screen, so strange.