signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.59k stars 6.14k forks source link

Signal/Android Contact App does no longer"correctly" link "special contacts number" with special characters ("-", " ") to a phone contact #9877

Closed Linkinsoldier closed 3 years ago

Linkinsoldier commented 4 years ago

Bug description

First of all: thank you for the App! I have used Signal for many years now and one of the major plus points was, that it could correctly "link" "special contacts" (e.g. SMS from my bank, and so on) to a real contact in my adressbook and therefore it will display the contact picture. Aside from the fact that this really looks nicer (especially in the notification bar) it is also an added layer of "security" for me, that not someone else is sending me an SMS in the context of my bank, ... of course someone could "missuse" this by using the same sender name, but still :)

It still works fine for normal contacts and phone numbers, but for example banks (in Germany for example "BSK-Hall, HB-Secure, and so on) or other companies (e.g. o2 is using "o2 Team" with a space) use a "special contact number" which signal used to work fine - but now it doesnt anymore. I guess this is linked to the - in the display name in Signal (or some space " "). See "steps to reproduce"

Steps to reproduce

Actual result: the "special contact number" (e.g. BSK-Hall, HB-Secure, ...) will be display in the "phone number" section, but after storing the contact it is not "linked" correctly to the thread and therefore the contact picture is not shown. Redoing the steps makes it possible to add the "special contact number" again and again, but it will not work either way.

Expected result: the "special contact number" (e.g. BSK-Hall, HB-Secure, ...) is correctly linked to the conversation and after switching back to the signal app it will show the contact picture of the selected contact. I have done this for many companys and it worked with several banks, DHL, ... you name it. About a year ago it stopped working and I hope this issue tracker will bring it back. It looks like the contact app does not store special characters like - or " " in the number (or signal does not forward it correctly?) and this seems to be the problem - because it always deletes the special character when going from signal to the contact app. When I manually add those characters in my Nextcloud App, the contact app just ignores it (still displays BSKHall instead of BSK-Hall), but after resyncing/refresh of the contacts ("german: aktualisieren") in Signal it displays (BSK-Hall) and the connection works - so Signal seems to handle it correctly, at least in one direction :)

The Nextcloud Workaround seem to work for me, but maybe there is better way for other customers? If nextcloud could add it regardless of the contact app disregarding the "symentic", maybe Signal could too? Or maybe Signal could check for a phone number with or without those special characters?

Screenshots

Screenshot_20200726-201643_Contacts(1)_copy Screenshot_20200726-201409_Signal(1)_copy

Device info

tried may devices and it stopped working without changing the phone. Device: Samsung S10e (G970F) Contacts on Nextcloud - Sync via Davdroid Android version: 10, July security patch Signal version:** 4.67.1

Link to debug log

necessary? Debug log seems fairly detailed, while this is quite simply reproduceable

Linkinsoldier commented 3 years ago

Problem ist mit neuer Signalversion gefixt