Signal doesn't scroll all the way down in a conversation when sending a message and the other person is typing

Nisc3d commented 4 years ago

[x] I have searched open and closed issues for duplicates
[x] I am submitting a bug report for existing functionality that does not work as intended
[x] I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
[x] This isn't a feature request or a discussion topic

Bug description

In certain scenarios Signal doesn't scroll all the way down when sending a message and the other person is typing. That means you miss when the other person types. That is not so good, because you might think the other person ended the conversation.

Steps to reproduce

Tell another Signal User to write long messages every 10 seconds and keep typing
Send short messages to the other user

Actual result: Sometimes it doesn't scroll all the way down after sending a message Expected result: It should scroll all the way down everytime

Screenshots

I recorded the Bug on Video: https://drive.google.com/file/d/1z1aC_sYFFNIu1HfOkovPAGJo444_ZtXH/view?usp=sharing

Device info

Device: Asus Zenfone 6 Android version: 10 Signal version: 4.68.8

Link to debug log

https://debuglogs.org/c12fa05fc8f950225009fdcbce85ca8dd300125e507eb590a2e1f225bcf82811

Nisc3d commented 4 years ago

This may be related: I noticed sometimes you get a notification if you are in a chat and and the other person sent a message. You have to scroll up a bit and then down to the bottom again to make the notification go away. Of course you can also clear your notifications, but you really shouldn't get one in the first place if you are actively chatting and staying in the chat. This happens randomly and not every time.

vertigo220 commented 3 years ago

I have this happen fairly often even when (AFAIK) the other person isn't typing. I'll send a message and think it didn't send, then scroll down and it's there.

chaoscommander commented 3 years ago

This (or some variant of it) also occurs frequently on Signal 5.1.8, Android 9.

chaoscommander commented 3 years ago

It has gotten worse. Now the conversation often just doesn't scroll at all when I send a message. It stays at the last received one. I have to manually scroll down to the bottom after I send a message. This does not correlate with the other person typing. So far I don't know with what it does correlate.

ravtakhar commented 3 years ago

I am manually having to scroll down quite often as well when having a conversation. At times I miss messages because it appears as if someone has not sent a follow-up message (app marks as read) and I close out.

ravtakhar commented 3 years ago

Hey team, wondering if there any update on this. I don't think it's happening only when the other person is typing. Starting to get super annoying because missing a lot of messages and is a reason why a lot of my contacts are starting to go back to WhatsApp 🤐

I wonder if it makes a difference but we are all for the most part running Google Pixel devices. (My device; Google PIxel 5)

ravtakhar commented 3 years ago

Here is a debug log of right after this occurs:

https://debuglogs.org/b0edc3041eb3915ac53c8d256da87194c145983e015cffe5530229bb72ab6dbd

ubergeek77 commented 3 years ago

This never happened to me until a recent update, where there seems to be some kind of "smooth" animation for the chat bubbles whenever either party sends a message.

Messages used to pop up instantly with no animation, but as of a recent update (within the last week), messages now appear smoothly, but this behavior seems to have (re)introduced this bug.

ravtakhar commented 3 years ago

I can't seem to get across on the Signal Community page. My posts are hidden almost immediately when posted, but here is another debug log on the latest version. The issue has gotten a lot worse:

https://debuglogs.org/828f4cc1ee2ab943c65ff4df05ee58b456936c8c39f0994e49eb957b05adfe4b

ravtakhar commented 3 years ago

Noticed this is happening with larger conversations. I use Signal extensively throughout the day and it's happening with all of my mutual contacts at this point. Very annoying and a lot of people are resorting back to SMS/RCS

ravtakhar commented 2 years ago

@alex-signal is there anyway to take a look at this issue. I hate to bother but it continues to progressively get worse day to day. Uninstalling/clearing data seems to be a temporary fix 👎

alex-signal commented 2 years ago

I'll take a look. Sounds like something broke with scrolling when we introduced some of the new animations.

alex-signal commented 2 years ago

@ravtakhar

Looks like, from your debug log, you're on 5.25.4

I see this commit in a later version 2427c226a "Disable message animations when scrolling" which I believe was introduced to fix this issue. I believe that the latest released app on the play store should be 5.25.8. Could you please upgrade and see if the issue persists?

ravtakhar commented 2 years ago

@alex-signal I am on version 5.26.10 and it's still happening.

alex-signal commented 2 years ago

@ravtakhar Thanks! I'll take a closer look. Is this only happening in groups, or all sorts of conversations? (I've been hammering away between my device and a test device and can't reproduce so far, so I'm hoping to get some more info)

ravtakhar commented 2 years ago

@alex-signal this is happening for all conversations. It seems to be happening once the conversations get larger in scale. That is why when I delete data it goes back to normal until the conversations hit a certain scale (length).

We are using Signal for a tremendous amount of communication 1:1 and group chats.

EDIT: Is there anyway I can report how many messages are in a particular convo where this is happening?

alex-signal commented 2 years ago

@ravtakhar Not really.

It's curious that it's happening with a certain scale though. Are you scrolling way back through the convo and then entering a new message or just entering when you're scrolled to the latest messages? (Wondering if it's some kind of paging issue)

ravtakhar commented 2 years ago

@alex-signal It's happening when the conversation is scrolled all the way to bottom. I have tried not touching the scroll at all even when entering a conversation. The only time the scrolling works correctly is when the conversation is in bubble mode.

alex-signal commented 2 years ago

The only time the scrolling works correctly is when the conversation is in bubble mode.

That's the other strange part, but now I'm wondering if it's due to the piece of code that tries to check the height of the display.

Thanks for the information! I'm sorry this issue is annoying. I think my first step though is to get some additional logging into the next beta cycle to try to track down whats happening.

ravtakhar commented 2 years ago

@alex-signal let me know when the logging is present and I'll shoot my debug logs once I am on the version required.

Thanks!

ravtakhar commented 2 years ago

@alex-signal I did some additional testing on my end and I think it may have to do with DPI settings on the OS level.

When my Pixel 5 is set to "Display Size" normal the issue no longer persists. It's when the display size is set to "small" the issue presents itself.

I hope this helps!

alex-signal commented 2 years ago

Huh, yeah, that should at least help reproduce the issue!

On Wed, Nov 17, 2021 at 7:10 PM Rav Takhar @.***> wrote:

@alex-signal https://github.com/alex-signal I did some additional testing on my end and I think it may have to do with DPI settings on the OS level.

When my Pixel 5 is set to "Display Size" normal the issue no longer persists. It's when the display size is set to "small" the issue presents itself.

I hope this helps!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/signalapp/Signal-Android/issues/9937#issuecomment-972243832, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM7NP4XXNIUXKKX52Y3TLEDUMQY5LANCNFSM4QFNOWXQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

ravtakhar commented 2 years ago

@alex-signal wondering if any progress has been made on this issue. Switched devices and experiencing the exact same issue when moving the display size slider to 'small'

alex-signal commented 2 years ago

Nothing concrete yet. I'll update this issue once it's resolved. Thanks for the help diagnosing!

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

hillbicks commented 2 years ago

I had this issue fo some time, it then disappeared only to surface again recently. I haven't cleaned any messages during the time it was working.

It happens in the android app on my pixel 5 as well as the desktop version on a Linux laptop (arch).

So I would say it is still relevant dear stale bot 😁

chaoscommander commented 2 years ago

I have noticed this "from afar" a lot lately. When I send someone multiple messages in a row while in an active conversation (as in, both have their phone in front of their face and are looking at the conversation), I sometimes see that not all my messages get marked as read. The lower ones don't, suggesting that the other person has not scrolled down (and neither has the conversation done so automatically). But at least the messages don't get marked as read just by opening the conversation, unless they've actually been seen! I didn't know that feature existed.

loosemoose613 commented 2 years ago

I have also been experiencing this issue on my largest conversation for at least a year now.

I too can confirm it happens with or without the other person actively typing. Thinking it might be related to the typing animations though, I tried disabling the "typing indicators" feature, but it still happens.

I also tried increasing the font size on my device (Galaxy S10e) after reading about ravtakhar's success, but with no luck.

I thought it could be related to screen size since my S10e is relatively small compared to other devices, but other users in this thread reported the issue on a Pixel 5 and a Zenfone 6, so I don't know.

One other comment, I normally use AnySoftKeyboard which allows you to set a custom keyboard height. Thinking this might be the issue, I did try switching back to the default Samsung keyboard (although it also allows a custom height, which I left default), yet the problem still occurred.

Edit: I want to add one more observation. I usually notice this happening when I'm sending multiple messages in a row. Specifically when the sent/delivered icon and timestamp disappear from the previous sent message and appear on the latest one.

Nisc3d commented 2 years ago

I am the original author of the bug report and I think it also changed. It is no longer dependent on the other person typing. I have a debug log: https://debuglogs.org/android/5.33.2/295a73ff09a810a6ec267fbc31679dd1848beba42b88f98a19c5d47fc0a19220

Situation: one unread messages in a group chat. I opened the group chat and sent a message. It didn't scroll down. After that I captured the debug log.

Kobnar commented 2 years ago

I have the same issue and it's been driving me nuts for months.

OnePlus 8 Android 11.0.7.9.IN55CB Signal 5.35.3

tehnatural1 commented 2 years ago

This issue has recently surfaced for me as well on a Pixel 6 Pro with Signal version 5.35.3.

I will receive a new message but when I open the chat, the window does not scroll down to show the message. As others have stated the chat history is quite lengthy for all the chats I have noticed the issue in.

alex-signal commented 2 years ago

Q, when you left the chat previously, were you scrolled to the bottom? I'm wondering if our "last seen" position is bugged.

Kobnar commented 2 years ago

This still happens when I'm scrolled all the way to the bottom as I leave a chat. Also, if I return to the chat by clicking on a notification or navigating from the window of chat threads, it appears to start scrolled all the way to the bottom.

Last night I also noticed that the animation for a new message is bugged sometimes. I think this is related b/c of earlier comments. Sometimes, the scrolling animation will start for a fraction of a second (1-3 mm on screen), but then snap back to the pervious position. Most of the time, this doesn't appear to happen and the chat simply doesn't scroll.

Most of my contacts communicate in bursts of short text messages. I have to constantly swype my screen to make sure I'm scrolled to the bottom, since there's almost never a visual cue that a new message has arrived.

P.S. If it helps, I've also noticed this problem is most acute when my girlfriend is upset about something and my responses are 3-6 messages out of date 🤪

greyson-signal commented 2 years ago

I used to be able to repro, but I haven't been able to in the 5.37 candidate branch. Please let me know if you still encounter this when it goes to beta early next week.

chaoscommander commented 2 years ago

5.38 is public by now and I just tried to reproduce this bug in one conversation where it used to reliably occur. It doesn't now, Signal scrolls down when I send a message. What about you other people who commented above?

Kobnar commented 2 years ago

I've still noticed the bug, but I'll pay closer attention.

ktml commented 2 years ago

I have similar issue with Signal (5.38) on iPad (iPadOS 15.5), here are my findings:

On landscape: every time I switch away and back to Signal app, the conversation gets scrolled up about 100px
On portrait: the opposite happens, every time I switch away and back to Signal app, the conversation gets scrolled down about 100px
Happens to all conversations
Doesn't happen on iPhone

Edit: sorry, post this in the wrong repo, got too excited.

alex-signal commented 2 years ago

@ktml If you are experiencing the issue on an Apple device, it would be best to report the issue on the Signal-iOS issue tracker. It is a completely different codebase than Android.

ktml commented 2 years ago

@alex-signal ah didn't notice this is for Android code base only, I thought Android and iOS shared some code. Thanks!

alex-signal commented 2 years ago

@ktml There are some rust components for crypto that are shared but the UI, database layer, and other components are completely native.

loosemoose613 commented 2 years ago

5.38 is public by now and I just tried to reproduce this bug in one conversation where it used to reliably occur. It doesn't now, Signal scrolls down when I send a message. What about you other people who commented above?

I am still having the issue on 5.44.3

edit: Actually it's been worse than ever now :(

OlivierNY commented 1 year ago

Still experiencing the issue on 6.16.2 on Samsung S23+. Anyone else? Any solution?

alex-signal commented 1 year ago

Hi, no. The code around handling these scroll events is quite complex. I'm taking a fresh look at the entire conversation screen (to see if I can't modernize it and speed it up) and this is something that I'll definitely need to address. Hopefully, I can think of a more stable method for this.

chaoscommander commented 1 year ago

The issue has returned in Signal 6.22.8, but differently. When I tap a notification for a new message, the conversation opens, but it doesn't scroll down to the new message. It remains at the last one I sent.

I also observed weird behavior that may be related: upon sending a message, the conversation sometimes jumps backwards in the message history by a substantial amount (at least tens of messages) and then scrolls back down to the end very quickly.

signalapp / Signal-Android