search

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.66k stars 2.67k forks source link

Leaving groups affects desktop only partially and inconsistently #1044

Open jkopczyn opened 7 years ago

jkopczyn commented 7 years ago

Bug description

When users leave a group chat through the Android app, they continue to receive messages from that group, and are still able to send them, on the desktop client.

Steps to reproduce

Actual result: The user who has left the group continues to get some but not all messages (and notifications) on the desktop client, and any message they attempt to send goes through to the whole group. Expected result: The user receives no messages from the group and is not capable of sending them to the group.

Screenshots

Platform info

Signal version: Newest

nightpool commented 7 years ago

Someone I was chatting with was having this problem on Desktop too. I can ask them for more information if necessary.

janvlug commented 7 years ago

Maybe this is the same issue as described in #1115

jkopczyn commented 7 years ago

@janvlug Yes, that seems likely. The situation in #1115 was happening for the members of the group chat using iOS clients at the same time.

rannbaron commented 7 years ago

Any progress on this? It's a major security issue. I keep on having to make new groups every time someone leaves, as they keep getting messages.

liliakai commented 7 years ago

Can't reproduce. If you can do so consistently, please capture debug logs immediately afterwards, preferably from all the desktop/mobile clients involved, or as many as you can.

catilac commented 7 years ago

This happened to me on iOS

scottnonnenberg commented 7 years ago

@catilac Was this recently? Did you capture logs?

catilac commented 7 years ago

@scottnonnenberg unfortunately no logs. this happened between 1-1.5 months back.

otherbanu commented 7 years ago

https://gist.github.com/anonymous/7ba49f892e663a15b54b34f0c98ac24d --> still getting messages from a few members (6?) of a 60ish person group text on desktop signal but not on ios

scottnonnenberg commented 7 years ago

@otherbanu Can you talk about the scenario that led up to the log you submitted? I'm assuming that you're getting messages from a group you tried to leave? From only some of the group members?

otherbanu commented 7 years ago

@scottnonnenberg yeah, exactly - i left a large group about a month ago. since then, i sporadically receive messages, but only to desktop, not to my phone. i get messages from certain phone numbers/contacts in what seems like a fairly consistent way—i'd gamble that i'm getting every single message that those group members are sending, just because there are so many every day.

janvlug commented 7 years ago

@scottnonnenberg In the past I also tried to describe a scenario that can lead to still receiving messages while you 'left' the group: https://whispersystems.discoursehosting.net/t/large-groups-tend-to-become-unusable-over-time/952

ecawthon commented 6 years ago

I have another anecdote that I'm unable to reproduce:

  1. Android Alice, Steve Bobs (iOS), and Eva(ndroid), are in a Signal group.
  2. Eva leaves the group.
  3. Alice and Bobs continue to send messages via iOS and Android apps. Eva does not see them, as expected.
  4. Alice opens Signal on desktop, and sends a message to the same group (same group name and icon). Bobs and Eva both receive this message. It turns out Eva is still listed as a group member on Alice's desktop, but not on Android.
  5. 3 and 4 can be repeated in any order.

I think this is possibly a security issue - if the group membership lists are out of sync, they should show as separate groups - that way, when Alice checks her phone, she can see that something has gone wrong. When the two groups (with and without Eva) show up as the same thread, Alice gets no indication that Eva is still receiving her messages.

I wasn't able to reproduce this with just three participants in a new group, but I still have the original group chat (with more members) where I observed this behavior (as Alice), and can continue to reproduce 3 and 4. Both devices have been rebooted since Eva left the group, so I don't think I can get debug info from when Eva originally left, but if there is anything Eva and I can do with the group chat that continues to exhibit this behavior, we can follow instructions and provide debug logs if that would still be useful.

fabianbur commented 5 years ago

Exactly the same happens to me in a group of 6 members in which two came out. Is there any hope that they will fix it? I think it's a major security breach

fabianbur commented 5 years ago

As an information, I just fixed it by deleting all the data from the Signal Desktop application in Linux Ubuntu 18.04, deleting the chat with the person who was still receiving the messages in the Android app and in Desktop.

It is clear that this is a bug, and serious, synchronization between desktop and mobile clients.

It is a bug that any developer can reproduce.

It is a bug that has been reported several times for years.

It is a bug that has no one assigned to investigate and solve it.

It is a bug that should be given the necessary importance in an application that is interested in security

xanoni commented 1 year ago

Related: