Pictures failing to load to desktop client

RealPariah commented 7 years ago

[x ] I have searched open and closed issues for duplicates

Bug description

MMS messages used to show up fine on desktop client. Today I was sent 2 MMS back to back with pictures in them. They load fine on the phone, but nothing at all shows on desktop client. I was using desktop to communicate with another Signal user so normal SMS seems to continue to work just fine, but I know I have had MMS show up fine (and have even sent them from the dektop which I always thought was neat the rare times I actually use MMS).

Steps to reproduce

using hyphens as bullet points
list the steps
that reproduce the bug
Send MMS message to a signal user
See MMS on phone
See Nothing on Desktop Client Actual result: No MMS images seen on desktop client (or even like a blank placeholder box it's like they are completely filtered out from the desktop side now) Expected result: I expect to see the MMS image in both the phone and desktop clients. I am betting this may relate to the newest arbitrary file types sends that were recently enabled as this probably required an overhaul of the file/image handling mechanisms within Signal which may have messed with hooks or something else related to the desktop client
Screenshots

Seems redundant, I have an image on my phone, and I do not on the desktop client. As I stated not even a placeholder so it is like the desktop client is completely blind to MMS messages now.

Platform info

Operating System: Windows 7 Pro Browser: My Browser Chrome 58.0.3029.96 (64-bit)

Signal version: 0.38.2

Link to debug log

https://gist.github.com/a0fd3089cc3be1f1974a846742d26924

jeremymasters commented 7 years ago

Do you mean signal message? Neither SMS nor MMS is supported by the desktop client.

liliakai commented 7 years ago

SMS and MMS are features specific to the Android app. Signal-Desktop only supports Signal messages/contacts. When the text entry field in Android says "Signal message" and not "Unsecured MMS/SMS" it will sync to desktop. Please contact support@whispersystems.org if you need further assistance.

RealPariah commented 7 years ago

liliakai seems to maybe have it out for me I mean a picture message received from another signal user using signal to my signal clients on my phone and desktop.

jeremymasters commented 7 years ago

@RealPariah I think since you used a specific protocol, MMS, it had to be assumed it was really MMS you were talking about.

liliakai commented 7 years ago

We need more information here.

First, make sure this is consistently reproducible. Have someone else send you some messages. Include some text-only messages, image-only messages, and images with text included. Immediately after you have generated a thread that is clearly missing some, but not all messages on desktop, collect as many of the following as you can:

Debug log from the sender's device
Android log from the recipient
Debug log from the recipient
Screen shots of threads from desktop, android, and sender
last 3 digits of the phone numbers involved

You can submit things privately to support@whispersystems.org if you don't want to post it here.

Dyras commented 7 years ago

Not sure if this is the exact same issue I just experienced but I'm trying here before making a new issue.

A friend of mine sent me a picture with the message "W.. TF.." and a picture attached. The picture shows up as clear as day on my phone but it doesn't show up in the chat on Signal-Desktop. On Signal-Desktop only the message is shown, which caused some confusion to say the least.

Here's a log: https://gist.github.com/anonymous/2ba53051c15316a33b96de80d1b8b523 Last 3 digits of my friend's phone number is 323

An interesting thing to note is that if I click the message, the picture shows up under the message info Pictures: https://nup.pw/yWQtZu.png https://nup.pw/8BxCri.png

liliakai commented 7 years ago

@Dyras I suspect you were probably seeing separate and more recent issue, which was fixed in f38d8eb.

Dyras commented 6 years ago

@scottnonnenberg This happened for me just now with two pictures sent in a row, using the Electron app. https://gist.github.com/anonymous/4e855b7f43a52b42f5a0e202300434d0 One picture eventually arrived, 2 minutes late: https://gist.github.com/anonymous/d3bdf803cf28d195d0c3f3eaf420eb51

No signs of the second picture so far.

Android debug log: https://gist.github.com/anonymous/ae525f656d2bd08ff2f3b9a3a622f23c

scottnonnenberg commented 6 years ago

@Dyras Yep, it looks like those attachments are taking a long time to download. The first one took over two minutes to finish downloading, and the other one hadn't finished by the time you capture the log you provided. Looks like this is a general issue with how we handle attachments - they block the processing of other, more recent messages, even though they might take a long time to download. It's on the list!

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been closed due to inactivity.

signalapp / Signal-Desktop