search

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.7k stars 2.69k forks source link

Problems running signal electron client #1382

Closed hennjo closed 7 years ago

hennjo commented 7 years ago

Bug description

I'm trying to run the electron client on both windows 10 and ubuntu 16.04 like it is described for the Quickstart dummy app provided here.

I also posted my issue in the community forum here but there was no hint so far. Maybe someone around here knows if this is even the right way.

Steps to reproduce

Actual result: I get the following errors: windows 10: see screenshot signal

ubuntu:

Error: Cannot find module 'electron-updater'
at Module._resolveFilename (module.js:470:15)
at Function.Module._resolveFilename (/home/jochenn/Downloads/electron/resources/electron.asar/common/reset-search-paths.js:35:12)
at Function.Module._load (module.js:418:25)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at Object. (/home/jochenn/Downloads/Signal-Desktop-electron/app/auto_update.js:1:176)
at Object. (/home/jochenn/Downloads/Signal-Desktop-electron/app/auto_update.js:78:3)
at Module._compile (module.js:571:32)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:488:32)
A JavaScript error occurred in the main process
Uncaught Exception:
Error: Cannot find module 'electron-updater'
at Module._resolveFilename (module.js:470:15)
at Function.Module._resolveFilename (/home/jochenn/Downloads/electron/resources/electron.asar/common/reset-search-paths.js:35:12)
at Function.Module._load (module.js:418:25)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at Object. (/home/jochenn/Downloads/Signal-Desktop-electron/app/auto_update.js:1:176)
at Object. (/home/jochenn/Downloads/Signal-Desktop-electron/app/auto_update.js:78:3)
at Module._compile (module.js:571:32)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:488:32)

Expected result: Signal desktop client shoud be functional when started this way.

Screenshots

Platform info

Operating System: Windows 10 education 64 bit and Ubuntu 16.04 in a VM Browser: /

Signal version: electron branch from last week

Link to debug log

scottnonnenberg commented 7 years ago

Hi there, @hennjo. The full directions for running electron are:

  1. pull down the repo, check out the electron branch
  2. install node.js (nvm is good if you're on OSX or Linux)
  3. npm install -g yarn
  4. yarn install
  5. yarn run dist-prod (not necessarily required, but you need this for spell check. requires a couple other build tools present on your machine)
  6. yarn run start

Lemme know how that goes for you!

If you'd like to jump onto our small beta, I can give you the links to install the beta versions of Electron we've been using internally for a while.

hennjo commented 7 years ago

Thanks for the reply.

I did get it to run this time! There were some warnings and errors during yarn install but yarn run start did the job in windows 10.

yarn install v0.27.5 [1/5] Resolving packages... [2/5] Fetching packages... warning 7zip-bin-linux@1.1.0: The platform "win32" is incompatible with this module. info "7zip-bin-linux@1.1.0" is an optional dependency and failed compatibility check. Excluding it from installation. warning 7zip-bin-mac@1.0.1: The platform "win32" is incompatible with this module. info "7zip-bin-mac@1.0.1" is an optional dependency and failed compatibility check. Excluding it from installation. [3/5] Linking dependencies... [4/5] Building fresh packages... [1/5] ⢀ spellchecker: info using node@6.11.1 | win32 | x64 [2/5] ⢀ electron [3/5] ⢀ phantomjs-prebuilt [4/5] ⠠ node-sass error D:\Downloads\Signal-Desktop-electron\Signal-Desktop-electron\node_modules\spellchecker: Command failed. Exit code: 1 Command: C:\WINDOWS\system32\cmd.exe Arguments: /d /s /c node-gyp rebuild Directory: D:\Downloads\Signal-Desktop-electron\Signal-Desktop-electron\node_modules\spellchecker Output: D:\Downloads\Signal-Desktop-electron\Signal-Desktop-electron\node_modules\spellchecker>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\....\node_modules\node-gyp\bin\node-gyp.js" rebuild ) else (node "" rebuild ) gyp info it worked if it ends with ok gyp info using node-gyp@3.4.0 gyp info using node@6.11.1 | win32 | x64 gyp ERR! configure error gyp ERR! stack Error: Can't find Python executable "python", you can set the PYTHON env variable. gyp ERR! stack at failNoPython (C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\configure.js:449:14) gyp ERR! stack at C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\configure.js:404:11 gyp ERR! stack at C:\Program Files\nodejs\node_modules\npm\node_modules\graceful-fs\polyfills.js:264:29 gyp ERR! stack at FSReqWrap.oncomplete (fs.js:123:15) gyp ERR! System Windows_NT 10.0.15063 gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild" gyp ERR! cwd D:\Downloads\Signal-Desktop-electron\Signal-Desktop-electron\node_modules\spellchecker gyp ERR! node -v v6.11.1 gyp ERR! node-gyp -v v3.4.0 gyp ERR! not ok info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

After it starts up i tried to link it to my mobile phone, but just ended up with either "no device found" or network error on the signal android client. My windows firewall was turned off at the time.

I don't have an extra phone number to set it up as standalone nor do i have a chrome export. Although if you let me know how i could create one and test it that way. But i guess i still have to link it to my android client right?

Sure I'd like to test your beta version.

scottnonnenberg commented 7 years ago

Just one more step and you should be able to use it. By default it runs on our staging servers. You can create a file like this at config/local-development.json:

{
  "serverUrl": "https://textsecure-service-ca.whispersystems.org"
}
scottnonnenberg commented 7 years ago

You can reach out to me directly and I can get you access to the beta. :0)

FilLuge commented 7 years ago

Tried this on Mac OS X 10.11.6. On executing yarn run dist-prod I've got these errors:

Running "getExpireTime" task
Warning: Cannot read property 'branch' of undefined Use --force to continue.

Aborted due to warnings.

npm ERR! Darwin 15.6.0
npm ERR! argv "/Users/fil/.nvm/versions/node/v6.11.2/bin/node" "/Users/fil/.nvm/versions/node/v6.11.2/bin/npm" "run" "generate"
npm ERR! node v6.11.2
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! signal-desktop@1.0.22 generate: `npm run icon-gen && grunt`
npm ERR! Exit status 3
npm ERR! 
npm ERR! Failed at the signal-desktop@1.0.22 generate script 'npm run icon-gen && grunt'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the signal-desktop package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run icon-gen && grunt
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs signal-desktop
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls signal-desktop
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/fil/Desktop/Signal-Desktop-electron/npm-debug.log

npm ERR! Darwin 15.6.0
npm ERR! argv "/Users/fil/.nvm/versions/node/v6.11.2/bin/node" "/Users/fil/.nvm/versions/node/v6.11.2/bin/npm" "run" "dist"
npm ERR! node v6.11.2
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! signal-desktop@1.0.22 dist: `npm run generate && npm run build`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the signal-desktop@1.0.22 dist script 'npm run generate && npm run build'.

yarn run start opens the application. When I try to import from Chrome app with "choose directory" no window opens and I get following error in console:

Uncaught TypeError: Cannot read property 'getDirectoryForImport' of undefined
    at child.onImport (import_view.js:102)
    at HTMLDivElement.dispatch (components.js:4409)
    at HTMLDivElement.elemData.handle (components.js:4095)
onImport @ import_view.js:102
dispatch @ components.js:4409
elemData.handle @ components.js:4095

Any hints to solve this are welcome.

scottnonnenberg commented 7 years ago

@FilLuge It looks like your grunt tasks aren't completing successfully. Are you sure that the yarn install command really got everything installed? What happens when you just try to run the grunt command? (you might need a yarn global add -g grunt-cli first)

FilLuge commented 7 years ago

This was the output from yarn install:

$ yarn install
yarn install v0.27.5
info No lockfile found.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Saved lockfile.
Done in 1.84s.
$ yarn global add -g grunt-cli
yarn global v0.27.5
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
Done in 0.37s.

Seems there is some path missing:

$ grunt
-bash: grunt: command not found

There are several grunt binaries below Signal-Desktop-electron/

node_modules/.bin/grunt
node_modules/grunt
node_modules/grunt/bin/grunt
node_modules/grunt/lib/grunt
node_modules/grunt/node_modules/.bin/grunt
node_modules/grunt-cli/bin/grunt
node_modules/grunt-contrib-concat/node_modules/.bin/grunt
node_modules/grunt-contrib-connect/node_modules/.bin/grunt
node_modules/grunt-contrib-jshint/node_modules/.bin/grunt
node_modules/grunt-exec/node_modules/.bin/grunt
node_modules/grunt-gitinfo/node_modules/.bin/grunt
node_modules/grunt-sass/node_modules/.bin/grunt
node_modules/grunt-saucelabs/grunt
node_modules/grunt-saucelabs/node_modules/.bin/grunt
$ node_modules/grunt/bin/grunt
Running "concat:components" (concat) task
Running "concat:libtextsecurecomponents" (concat) task
Running "concat:test" (concat) task
Running "concat:libtextsecure" (concat) task
Running "concat:libtextsecuretest" (concat) task
Running "sass:dev" (sass) task
Running "gitinfo" task
Running "getExpireTime" task
Warning: Cannot read property 'branch' of undefined Use --force to continue.

Aborted due to warnings.
scottnonnenberg commented 7 years ago

Ah, you know what? I just noticed that your output says 'no lockfile found' when you do a yarn install. I don't think you're on the right branch. The first step in the list of steps I provided above is to check out the electron branch. Like this: git checkout electron

FilLuge commented 7 years ago

I thought downloading the branch from GitHub with a browser and working with this would do the task. But it seems the git installation was broken on my test machine. After copying a working repo from my production machine it builds with only a code signing certificate warning. Signal starts without errors but when I try to link it to my iPhone after scanning the QRcode I get

Linking Device Failed Request failed: not found (404)

scottnonnenberg commented 7 years ago

It's connecting to the staging servers in development mode. The last step is mentioned above: https://github.com/WhisperSystems/Signal-Desktop/issues/1382#issuecomment-323210473

FilLuge commented 7 years ago

Shame on me, must have been blind. It is working now. Many thanks!