search

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.6k stars 2.66k forks source link

Windows 7: Notifications sometimes contain additional text "\r" #2287

Open AlfonsoMuskedunder opened 6 years ago

AlfonsoMuskedunder commented 6 years ago

Bug description

Sometimes, notifications contain, next to the text entered by the conversation partner, additional information, namely "\r"; see the screenshot below. The depicted message came from an iPhone.

Could this be information about a deliberate line break?

Screenshots

signaldesktopnotifications

Platform info

Signal version: v1.8.0-beta.1 Operating System: Windows 7 64-bit Linked device version: 4.19.1

Link to debug log

https://debuglogs.org/9967025f3feaa12ed3f67cbf1b1ead2bb8a368a5cb186417f72fbea6a125a7bd

I think this is the message that produced the above notification:

INFO  2018-04-25T11:05:50.665Z data message from +[REDACTED]538.1 1524654310693
gasi-signal commented 6 years ago

This may or may not be fixed by the upcoming #2330 as we’re moving away from tray bubbles (the fallback notifications seen above).

gasi-signal commented 6 years ago

Looks like this will be fixed with #2330.

AlfonsoMuskedunder commented 6 years ago

Whoop whoop! (Ignoring the fact that the screenshot suggests that the first linebreak is honored while the second one is being ignored... :smirk:)

gasi-signal commented 6 years ago

@AlfonsoMuskedunder: the screenshot suggests that the first linebreak is honored while the second one is being ignored...

Indeed, that seems to be default behavior of the Electron notifications API on Windows 7. Hopefully not having \r is an improvement that overshadows that shortcoming of the API.

AlfonsoMuskedunder commented 6 years ago

Of course! I didn't mean to complain, I was just curious. Thanks a lot!

gasi-signal commented 6 years ago

Of course! I didn't mean to complain, I was just curious. Thanks a lot!

No worries, it’s all good! Now that I have Windows 7 set up in a VM on my machine, we should be able to better investigate Windows 7 issues in the future. Thanks for being an active participant in making Signal better on Windows 7 ❤️