signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.59k stars 2.66k forks source link

Linux: Received image are sometimes all black #2735

Open Wasseranomalie opened 6 years ago

Wasseranomalie commented 6 years ago

Bug description

A received image shows only black instead of the true image. Unfortunately I don't have steps to reproduce.

Edit: My Linux-instance received and shows the image without problems.

Screenshots

Desktop: grafik Android: grafik This should be the original image: 3e8rjz38cvl11

Platform info

Signal version: 1.16.0

Operating System: Windows 10

Linked device version: 4.25.10 (Android)

Link to debug log

https://debuglogs.org/35c3a4cc8d1cda9631883b394b3e5dbd11bf6b974a3cdfd2815d6e61b938fb1d The attachment-download starts at 2018-09-13T07:41:38.893Z

EvanHahn-Signal commented 2 years ago

Is this still a problem that people are running into on the latest version (5.32.0)? If so, I'll investigate with those detailed reproduction steps.

indutny-signal commented 2 years ago

@protist we have upgraded Electron once more. Are you able to reproduce it on 5.33.0 or 5.34.0-beta.1?

protist commented 2 years ago

Sorry for the delay @indutny-signal and @EvanHahn-Signal. I tested with the latest version 5.33.0, and I can still reproduce as per the steps above. Again, it doesn't fail every time, but perhaps fails more reproducibly if you give more time (e.g. 15 seconds) between steps 3 and 4. FWIW I used my (Android) phone to complete step 3.

I can't remember if it's been posted above in this long thread, but I only observe the corruption on specific systems. i.e. my second computer shows the attachments fine. On the system where I do observe corruption, the final two tests are shown below. Again, they are often fully black, but here they have other artefacts.

image

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

protist commented 2 years ago

Still happens. Detailed reproduction steps provided and checked multiple times as requested.

scottnonnenberg-signal commented 2 years ago

@protist Have you ever had it happen when using the --disable-gpu flag?

protist commented 2 years ago

@scottnonnenberg-signal I just tested as per above with --disable-gpu, and it worked fine on four occasions. In the middle, I tested without the flag, and it was a black image again. When it failed (without the flag), I ran it in the terminal and got the following output.

[1030966:0601/102046.166600:ERROR:shared_context_state.cc(845)] SharedContextState context lost via ARB/EXT_robustness. Reset status = GL_UNKNOWN_CONTEXT_RESET_KHR
[1030966:0601/102046.166719:ERROR:gpu_service_impl.cc(977)] Exiting GPU process because some drivers can't recover from errors. GPU process will restart shortly.
[1030860:0601/102046.174421:ERROR:gpu_process_host.cc(975)] GPU process exited unexpectedly: exit_code=8704
[1031201:0601/102046.270347:ERROR:vaapi_wrapper.cc(1136)] vaQuerySurfaceAttributes failed, VA error: invalid parameter
[1031201:0601/102046.270466:ERROR:vaapi_wrapper.cc(1083)] FillProfileInfo_Locked failed for va_profile VAProfileH264Main and entrypoint VAEntrypointVLD
[1031201:0601/102046.270571:ERROR:vaapi_wrapper.cc(1136)] vaQuerySurfaceAttributes failed, VA error: invalid parameter
[1031201:0601/102046.270667:ERROR:vaapi_wrapper.cc(1083)] FillProfileInfo_Locked failed for va_profile VAProfileH264High and entrypoint VAEntrypointVLD
scottnonnenberg-signal commented 2 years ago

@protist And what version did you use for those tests?

protist commented 2 years ago

@protist And what version did you use for those tests?

5.44.1

scottnonnenberg-signal commented 2 years ago

@protist Thanks - that tells us that this change didn't address it like we thought it would: https://github.com/signalapp/Signal-Desktop/commit/bdc4f53e91d77b01cae8feb30c3c92df998591a4