signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.5k stars 2.63k forks source link

URL with ® or ™ character breaks hyperlink #2814

Open petecooper opened 5 years ago

petecooper commented 5 years ago

Bug description

URL with ® or character breaks automatic hyperlink generation for that URL.

Steps to reproduce

  1. Post message including a URL that contains ® or character.
  2. Note broken URL.

Actual result:

URL is partially generated, but the first instance of ® or prevents the full URL being recognised.

Example URL (safe for work, PDF): https://assets.bose.com/content/dam/Bose_DAM/Web/pro/global/discontinued_products/loudspeakers/Panaray_Acoustic_Wave®_Cannon™_Loudspeaker/td_panaray_awcs.pdf

screen shot 2018-10-21 at 14 11 00

Note the black ® or characters where the text should be white. Note the underlined hyperlink stops before the first ®.

Expected result:

The URL is valid, and should be detected then generated appropriately. The ® or characters should not block the generation.

Screenshots

Original discovery:

screen shot 2018-10-21 at 14 11 00

Three tests - replicate original discovery, then remove the first blocking character, then the second:

screen shot 2018-10-21 at 14 15 32

iOS working as intended:

img_4988

Platform info

Signal version:

1.16.3

Operating System:

macOS 10.12.6

Linked device version:

iOS 12.0.1

Link to debug log

https://debuglogs.org/9f3a9d990db8775ec17b2ea516423f5db37843fa22b4e948bcadd49f5dd07295

dsernst commented 1 month ago

Related to, but slightly different: https://github.com/signalapp/Signal-Desktop/issues/6674