30 bit color depth giving wrong colors

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.

https://signal.org/download

GNU Affero General Public License v3.0

14.61k stars 2.66k forks source link

30 bit color depth giving wrong colors #3546

Open mabod opened 5 years ago

mabod commented 5 years ago

[X] I have searched open and closed issues for duplicates

Bug Description

I have a Lenovo X1 Carbon laptop with Intel UHD 620 GPU and a high resolution WQHD display. The default color depth with Linux Xorg is 24 bit. No issue with that. But when I change it to 30 bit color depth the Signal user interface is displayed in completely wrong and odd colors. With almost unreadable contact list due to low contrast. Everything is more "baby rosa".

Other apps like gimp, firefox or my cinnamon desktop display just fine and do not have that issue.

Steps to Reproduce

Switch to 30 bit color depth by editing xorg.conf
Open signal UI

Actual Result:

Screenshots

Platform Info

Signal Version: v1.26.2

Operating System: Linux 5.2.8-1-MANJARO #1 SMP PREEMPT Fri Aug 9 19:34:20 UTC 2019 x86_64 GNU/Linux

Linked Device Version:

Link to Debug Log

mabod commented 5 years ago

Here is a screenshot.

I left firefox in the background so that you can see that the display is correct otherwise.

I have blurred the text parts in the signal window for privacy reasons. But the picture shown in the chat windows has not be altered. It is indeed displayed that bad originally.

test

kenpowers-signal commented 5 years ago

Does this issue occur in Chrome/Chromium for you? How about other Electron-based applications?

mabod commented 5 years ago

Yes. With Chromium as well.

kenpowers-signal commented 5 years ago

Based on information I've seen around the web and the information you've provided I'd say this is a bug which needs an upstream fix from Chromium / Electron.

Here's another example in the wild: https://community.brave.com/t/wrong-color-rendering-on-30-bit-displays-on-linux-possibly-on-other-platforms/50266

kenpowers-signal commented 5 years ago

@mabod One more question for you -- what version of Chromium were you trying? If you felt so inclined, you could also try the latest public beta of Signal which upgrades Electron by two major versions, though I suspect if your Chromium is recent then the problem will persist.

mabod commented 5 years ago

The Chromium version is 76.0.3809.132-0

mabod commented 5 years ago

I tested with signal-desktop-beta-bin 1.27.1beta.7-1 and there is no difference. Same bad UI.

kenpowers-signal commented 5 years ago

I opened an issue with Electron over at: https://github.com/electron/electron/issues/20032

bhlevca commented 4 years ago

Chromium has bin fixed since version 81. It is only Electron that dos not follow suit. I don' understand what takes them that long. The bug in Chromium has been fixed for almost one year.