signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.59k stars 2.66k forks source link

macOS picked emoji don't display in message composition. #3551

Open Billfred opened 5 years ago

Billfred commented 5 years ago

Bug Description

When composing a message in macOS, some emoji show up as a Unicode smiley face rather than the emoji itself. The message sends with the original selected emoji.

Steps to Reproduce

  1. Start composing a message (you don't have to type anything first).
  2. Invoke macOS emoji picker (Control-Command-Space)
  3. there's no step three Select ☺️. (There may be other emoji that do this, but I know this one does. It explicitly doesn't do it with, among others, πŸ™‚πŸ˜˜πŸ˜‰πŸ˜β€οΈπŸ’―πŸ™ƒπŸ€”πŸ€πŸ˜³πŸ‘€πŸ˜ŽπŸ€–πŸ––)
  4. Observe the composition box, then send the message.

Actual Result:

The composition box displays a Unicode ☺︎ instead of ☺️

Expected Result:

The composition box should just display ☺️

Screenshots

image

Platform Info

Signal Version: 1.26.2

Operating System: macOS 10.14.6

Linked Device Version: iOS 12.4

Link to Debug Log

https://debuglogs.org/bb3578bc3436716660a8634962087d4144d0b01292040a55a4bf7f467fcbf3e4

clesleycode commented 4 years ago

Potential first-time contributor here - I think I want to take this bug on :)

Thinking this could be a source of the bug? I also noticed that I reproduced this on other websites, like gmail's rich text editor, google chat, and chrome - fixing their font-weight to 200 fixed the issue, so i imagine the same will be true here.

scottnonnenberg-signal commented 4 years ago

@lesley2958 No, that's likely not the problem here. We replace all emoji with our own custom images. If anything, we need to go look at our emoji data providers, see if we need to upgrade them to support newer emoji like this.