signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.28k stars 2.59k forks source link

Windows 10 desktop not syncing with Android conversations #3616

Closed darmbrust closed 4 years ago

darmbrust commented 4 years ago

@KerbalSpike

I'm going to close this. We need people who encounter anything like this to open new bugs.

Originally posted by @scottnonnenberg-signal in https://github.com/signalapp/Signal-Desktop/issues/2298#issuecomment-534182381

I'm sorry, and what would the point be of opening a new bug, when all you did on this one was ignore it, not ask for additional info when it was offered, and then close it without referencing any possible fix?

scottnonnenberg-signal commented 4 years ago

Perhaps you didn't see my comment?

@KerbalSpike do you use Android for SMS? If so, Desktop will only sync messages with your contacts with Signal accounts.

scottnonnenberg-signal commented 4 years ago

The reason we ask for new bugs is the issue template. Which you also didn't follow when you opened this new bug. Debug logs and additional detail.

darmbrust commented 4 years ago

The previous bug was filed with an issue template, and debug logs, and additional info..., from multiple people, and then ignored for over a year. Then closed, disallowing further comments or information. Its not a very collaborative way to run a project. So you can understand that peoples patience to gather information, and reproduce an issue gets a little thin, when history shows it will just be ignored.

My issue was not with the Android SMS. I attempt to use Signal on my phone for all SMS, and on my linux desktop, and on my windows laptop.

Anytime I don't start signal on my laptop for some time, message sync fails in several ways on the next start... as detailed in the other bug.

I can certainly update the versions of signal to latest, and see if its still happening... but lacking even a referenced to some change in the source that may have addressed it, its hard to see it as being worth my time.

darmbrust commented 4 years ago

For a simple test, I just started signal on my laptop for the first time in months. It came up as "unlinked" for whatever reason, even though I never unlinked it, and my phone still showed it as linked. I upgraded it to current - 1.27.2. I upgraded my phone version to whatever is current in the app store for android. And then I relinked. It linked, put up the screen saying it was syncing, and eventually, comes up for use... and has synced nothing. For people that I was talking to today on my phone (and on my linux install) - the newly linked instance on my laptop still shows my last conversation as having been in June.

Sync is still completely broken and unusable. Same as it has been for a year.

The debug log on windows is full of messages about "Got empty Sync Message" I also see the debug bug log on windows being full of these:

INFO  2019-09-24T04:01:31.806Z refreshSenderCertificate: Getting new certificate...
INFO  2019-09-24T04:01:31.806Z GET https://textsecure-service.whispersystems.org/v1/certificate/delivery
ERROR 2019-09-24T04:01:32.039Z GET https://textsecure-service.whispersystems.org/v1/certificate/delivery 401 Error
ERROR 2019-09-24T04:01:32.039Z refreshSenderCertificate: Get failed. Trying again in two minutes... HTTPError: promiseAjax: error response; code: 401
    at HTTPError ([REDACTED]\app.asar\js\modules\web_api.js:379:13)
    at [REDACTED]\app.asar\js\modules\web_api.js:335:13
    at processTicksAndRejections (internal/process/task_queues.js:89:5)
Original stack:
Error
    at _outerAjax ([REDACTED]\app.asar\js\modules\web_api.js:373:19)
    at _ajax ([REDACTED]\app.asar\js\modules\web_api.js:476:14)
    at Object.getSenderCertificate ([REDACTED]\app.asar\js\modules\web_api.js:531:14)
    at run ([REDACTED]\app.asar\js\modules\refresh_sender_certificate.js:65:44)
    at runWhenOnline ([REDACTED]\app.asar\js\modules\refresh_sender_certificate.js:88:7)
INFO  2019-09-24T04:01:32.043Z GET https://textsecure-service.whispersystems.org/v1/profile/+[REDACTED]852 (unauth)
INFO  2019-09-24T04:01:32.266Z GET https://textsecure-service.whispersystems.org/v1/profile/+[REDACTED]852 200 Success
INFO  2019-09-24T04:01:32.267Z Setting sealedSender to ENABLED for conversation +[REDACTED]852
INFO  2019-09-24T04:01:32.268Z GET https://cdn.signal.org/profiles/-81SnyskpGTOPEGpPlyM2Q
ERROR 2019-09-24T04:01:32.467Z GET https://cdn.signal.org/profiles/-81SnyskpGTOPEGpPlyM2Q 403 Error
INFO  2019-09-24T04:02:06.763Z Sending a keepalive message
INFO  2019-09-24T04:03:01.832Z Sending a keepalive message
INFO  2019-09-24T04:03:32.049Z refreshSenderCertificate: Getting new certificate...
INFO  2019-09-24T04:03:32.049Z GET https://textsecure-service.whispersystems.org/v1/certificate/delivery
ERROR 2019-09-24T04:03:32.272Z GET https://textsecure-service.whispersystems.org/v1/certificate/delivery 401 Error
ERROR 2019-09-24T04:03:32.272Z refreshSenderCertificate: Get failed. Trying again in two minutes... HTTPError: promiseAjax: error response; code: 401
    at HTTPError ([REDACTED]\app.asar\js\modules\web_api.js:379:13)
    at [REDACTED]\app.asar\js\modules\web_api.js:335:13
    at processTicksAndRejections (internal/process/task_queues.js:89:5)
Original stack:
Error
    at _outerAjax ([REDACTED]\app.asar\js\modules\web_api.js:373:19)
    at _ajax ([REDACTED]\app.asar\js\modules\web_api.js:476:14)
    at Object.getSenderCertificate ([REDACTED]\app.asar\js\modules\web_api.js:531:14)
    at run ([REDACTED]\app.asar\js\modules\refresh_sender_certificate.js:65:44)
    at runWhenOnline ([REDACTED]\app.asar\js\modules\refresh_sender_certificate.js:88:7)
INFO  2019-09-24T04:03:32.276Z GET https://textsecure-service.whispersystems.org/v1/profile/+[REDACTED]852 (unauth)
INFO  2019-09-24T04:03:32.499Z GET https://textsecure-service.whispersystems.org/v1/profile/+[REDACTED]852 200 Success
INFO  2019-09-24T04:03:32.499Z Setting sealedSender to ENABLED for conversation +[REDACTED]852
INFO  2019-09-24T04:03:32.500Z GET https://cdn.signal.org/profiles/-81SnyskpGTOPEGpPlyM2Q
ERROR 2019-09-24T04:03:32.698Z GET https://cdn.signal.org/profiles/-81SnyskpGTOPEGpPlyM2Q 403 Error

I can't imagine this is helpful to the overall issue....

I'm happy to do tests and add logs and additional info if someone is actually planning on looking into this bug now (if there really is some trick to reproducing it that the devs haven't been able to replicate...)

scottnonnenberg-signal commented 4 years ago

@darmbrust Sadly, what you've described in your latest report is by design. If your desktop instance is offline for an extended period, we will unlink it automatically. And when a desktop is unlinked, its queue of pending messages will be deleted. When that happens, you will only get new messages sent after you've relinked your desktop..

darmbrust commented 4 years ago

That's a strange design... I thought I remembered it syncing some messages when I first installed it, and linked it. I don't know why it would have a different behaviour when it is re-linked.

I don't care about getting all of the messages, but it would sure be nice if it would at least get the last 100 or something reasonable, so you had some context...

Maybe I'm misremembering.

I'll let it sit for a week or two, and see if it fails sync again. What is the time period for the automatic delink?

Either way, some of the errors above seem odd.

KerbalSpike commented 4 years ago

I have to agree with Dan here that this kind of sync behaviour feels odd. I too remember the desktop client syncing (downloading) some messages when I first used it, but maybe my memory is clouded as well.

From a technical standpoint I don't understand how/why showing new messages in both the desktop client and the mobile app is not compromising encryption, but (assumption) synching older messages is somehow problematic?

The whatsapp web client does it all the time and while I know that it can't be trusted to be as secure as signal, I thought that whatsapp was using the same encryption protocoll as signal?

@ Scott I guess your question about using the Android SMS app is irrelevant now? Either way: yes, I'm using this. I use signal only for signal contacts.

On Wed, Sep 25, 2019 at 5:29 AM Dan Armbrust notifications@github.com wrote:

That's a strange design... I thought I remembered it syncing some messages when I first installed it, and linked it. I don't know why it would have a different behaviour when it is re-linked.

I don't care about getting all of the messages, but it would sure be nice if it would at least get the last 100 or something reasonable, so you had some context...

Maybe I'm misremembering.

I'll let it sit for a week or two, and see if it fails sync again. What is the time period for the automatic delink?

Either way, some of the errors above seem odd.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/signalapp/Signal-Desktop/issues/3616?email_source=notifications&email_token=AEJSFCCBSDUBQW5PYLTJQF3QLLLKRA5CNFSM4IZNH4S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7QPBFA#issuecomment-534835348, or mute the thread https://github.com/notifications/unsubscribe-auth/AEJSFCCKF2SKOTYQWGNCJXDQLLLKRANCNFSM4IZNH4SQ .

scottnonnenberg-signal commented 4 years ago

@KerbalSpike Funny enough, the WhatsApp desktop app is actually just a frontend for your mobile phone's stored data. It's not a separate app like Signal Desktop is.

I can assure you, the way Signal Desktop works hasn't changed. When you link it as a new device, it will only get messages sent to it after that link happens.