search

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.65k stars 2.67k forks source link

not properly displayed messages & impeded replying on linux #3722

Closed ssgromov closed 5 years ago

ssgromov commented 5 years ago

Bug Description

After one before the last update, Signal-Desktop on my openSUSE machine has an annoying bug. In conversations when other side is currently replying (three blinking dots) messages often disappear (not redrawn) until you switch to another contact and then back. Also, after the messages are not drawn, reply is not sent hitting Enter first, only after the second time.

Steps to Reproduce

  1. Start a chat with someone. One-way typing (when the other is just receiving and maybe reading) looks OK.

Screenshot_20191105_141840

  1. When on the other side someone starts to reply, three blinking dots appear. When an answer comes, messages window is redrawn, but no messages are shown.

Screenshot_20191105_141934

  1. Type an answer in this empty window, and first attempt to send will not go. Similarly, answering while your contact is actively typing will not work from first time and messages list will disappear.

  2. In order to see the messages again, only switching to another conversation and back helps.

Screenshots

Platform Info

Signal Version: v1.27.3

Operating System: openSUSE Leap 15.1 ( 4.12.14-lp151.28.20-default )

Linked Device Version: 4.49.15 (actual on Google Play), Android 9 Stock

Link to Debug Log

No log.

scottnonnenberg-signal commented 5 years ago

Please provide a debug log after you've gone through this scenario again. View -> Debug Log.

Also, how did you install the app? It may be that the mechanism you used to install it didn't assemble the package appropriately. Lastly, v1.27.4 is the latest. Please update to it.

ssgromov commented 5 years ago

Ahm... here is perhaps the problem!

It's a custom build from a community repo, version: 1.27.3-lp151.124.1

The latest "Experimental" (i.e. better "accepted" by the official openSUSE distro) build is v. 1.25.3, but it is not guaranteed to be bug-free, too. But perhaps I can try that one.

The log of the scenario is below, full today's log is attached).


>> ----- somewhere after here I click the conversation -------

INFO  2019-11-05T13:18:35.938Z open inbox
INFO  2019-11-05T13:18:35.955Z unloading conversation +[REDACTED]668 due to: model trigger - opened another conversation
INFO  2019-11-05T13:18:35.975Z GET https://textsecure-service.whispersystems.org/v1/profile/+[REDACTED]320 (unauth)
INFO  2019-11-05T13:18:35.976Z Cycling agent for type -unauth
INFO  2019-11-05T13:18:35.980Z SQL channel job 5038 (getConversationById) succeeded in 20ms
INFO  2019-11-05T13:18:35.982Z SQL channel job 5039 (getOlderMessagesByConversation) succeeded in 22ms
INFO  2019-11-05T13:18:35.983Z SQL channel job 5040 (getMessageMetricsForConversation) succeeded in 20ms
INFO  2019-11-05T13:18:35.983Z SQL channel job 5041 (getOlderMessagesByConversation) succeeded in 13ms
INFO  2019-11-05T13:18:36.389Z GET https://textsecure-service.whispersystems.org/v1/profile/+[REDACTED]320 200 Success
INFO  2019-11-05T13:18:36.389Z Setting sealedSender to ENABLED for conversation +[REDACTED]320
INFO  2019-11-05T13:18:36.390Z GET https://cdn.signal.org/profiles/J9aUZGC1nQ_0G3g0ofn1nw
INFO  2019-11-05T13:18:36.390Z Cycling agent for type -auth
ERROR 2019-11-05T13:18:36.790Z GET https://cdn.signal.org/profiles/J9aUZGC1nQ_0G3g0ofn1nw 403 Error
INFO  2019-11-05T13:18:45.710Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]320 (unauth)
INFO  2019-11-05T13:18:45.799Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]320 200 Success
INFO  2019-11-05T13:18:50.172Z SQL channel job 5063 (getConversationById) succeeded in 14ms
INFO  2019-11-05T13:18:50.945Z SQL channel job 5068 (updateConversation) succeeded in 14ms
INFO  2019-11-05T13:18:55.705Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]320 (unauth)
INFO  2019-11-05T13:18:55.797Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]320 200 Success
INFO  2019-11-05T13:19:00.213Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]320 (unauth)
INFO  2019-11-05T13:19:00.303Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]320 200 Success
INFO  2019-11-05T13:19:03.801Z Sending a keepalive message
INFO  2019-11-05T13:19:33.440Z Worker job 203 (arrayBufferToStringBase64) succeeded in 1ms
INFO  2019-11-05T13:19:33.446Z queueing envelope 921c4bd7-9067-4d2c-9b21-33ceec8a063b
INFO  2019-11-05T13:19:33.447Z received unidentified sender message
INFO  2019-11-05T13:19:33.451Z New remote ephemeral key
INFO  2019-11-05T13:19:33.454Z Deleting chain closed at 1572255448330
ERROR 2019-11-05T13:19:33.492Z Model caught error triggering change event: TypeError: this.cellSizeCache.clearPlus is not a function
    at Timeline.resize ([REDACTED]/app.asar/ts/components/conversation/Timeline.js:82:36)
    at Timeline.componentDidUpdate ([REDACTED]/app.asar/ts/components/conversation/Timeline.js:510:18)
    at Vh ([REDACTED]/app.asar/node_modules/react-dom/cjs/react-dom.production.min.js:216:296)
    at Zh ([REDACTED]/app.asar/node_modules/react-dom/cjs/react-dom.production.min.js:220:182)
    at [REDACTED]/app.asar/node_modules/react-dom/cjs/react-dom.production.min.js:250:268
    at Object.exports.unstable_runWithPriority ([REDACTED]/app.asar/node_modules/scheduler/cjs/scheduler.production.min.js:18:163)
    at Fi ([REDACTED]/app.asar/node_modules/react-dom/cjs/react-dom.production.min.js:250:203)
    at Di ([REDACTED]/app.asar/node_modules/react-dom/cjs/react-dom.production.min.js:249:383)
    at Yh ([REDACTED]/app.asar/node_modules/react-dom/cjs/react-dom.production.min.js:248:144)
    at Xh ([REDACTED]/app.asar/node_modules/react-dom/cjs/react-dom.production.min.js:245:332)
INFO  2019-11-05T13:19:33.492Z SQL channel job 5107 (getUnprocessedById) succeeded in 33ms
INFO  2019-11-05T13:19:33.492Z SQL channel job 5108 (removeUnprocessed) succeeded in 32ms
INFO  2019-11-05T13:19:33.496Z Worker job 204 (arrayBufferToStringBase64) succeeded in 3ms
INFO  2019-11-05T13:19:34.394Z Worker job 205 (arrayBufferToStringBase64) succeeded in 1ms
INFO  2019-11-05T13:19:34.400Z queueing envelope 4f339fc6-7da3-4b91-8271-868d1000097a
INFO  2019-11-05T13:19:34.400Z received unidentified sender message
INFO  2019-11-05T13:19:34.409Z data message from +[REDACTED]320.1 1572959972271 (4f339fc6-7da3-4b91-8271-868d1000097a)
INFO  2019-11-05T13:19:34.412Z Starting handleDataMessage for message +[REDACTED]320.1 1572959972271 in conversation +[REDACTED]320
INFO  2019-11-05T13:19:34.427Z Worker job 206 (arrayBufferToStringBase64) succeeded in 16ms
INFO  2019-11-05T13:19:34.428Z SQL channel job 5116 (getItemById) succeeded in 17ms
INFO  2019-11-05T13:19:34.428Z SQL channel job 5117 (getItemById) succeeded in 16ms
INFO  2019-11-05T13:19:34.440Z SQL channel job 5119 (updateUnprocessedWithData) succeeded in 13ms
INFO  2019-11-05T13:19:34.441Z SQL channel job 5120 (createOrUpdateSession) succeeded in 11ms
INFO  2019-11-05T13:19:34.461Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]320 (unauth)
INFO  2019-11-05T13:19:34.551Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]320 200 Success
INFO  2019-11-05T13:19:34.585Z Remove all notifications
INFO  2019-11-05T13:19:41.595Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]320 (unauth)
INFO  2019-11-05T13:19:41.686Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]320 200 Success
INFO  2019-11-05T13:19:48.132Z Send pre-checks took 5 milliseconds
INFO  2019-11-05T13:19:48.133Z Sending message to conversation +[REDACTED]320 with timestamp 1572959988133
INFO  2019-11-05T13:19:48.146Z SQL channel job 5154 (getConversationById) succeeded in 11ms
INFO  2019-11-05T13:19:48.161Z SQL channel job 5156 (updateConversation) succeeded in 15ms
INFO  2019-11-05T13:19:48.182Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]320 (unauth)
INFO  2019-11-05T13:19:48.273Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]320 200 Success
INFO  2019-11-05T13:19:48.299Z SQL channel job 5167 (getItemById) succeeded in 13ms
INFO  2019-11-05T13:19:48.299Z SQL channel job 5168 (getItemById) succeeded in 13ms
INFO  2019-11-05T13:19:48.309Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]793
INFO  2019-11-05T13:19:48.665Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]793 200 Success
INFO  2019-11-05T13:19:51.360Z Worker job 207 (arrayBufferToStringBase64) succeeded in 0ms
INFO  2019-11-05T13:19:51.366Z queueing envelope 50502713-6d48-47a6-903a-a302f083fb16
INFO  2019-11-05T13:19:51.366Z received unidentified sender message
INFO  2019-11-05T13:19:51.369Z New remote ephemeral key
INFO  2019-11-05T13:19:51.372Z Deleting chain closed at 1572255465758
INFO  2019-11-05T13:19:51.378Z read receipt +[REDACTED]320 1572959988133
INFO  2019-11-05T13:19:51.379Z Worker job 208 (arrayBufferToStringBase64) succeeded in 1ms
INFO  2019-11-05T13:19:51.388Z onProgress: Message count is 100
INFO  2019-11-05T13:19:51.928Z Worker job 209 (arrayBufferToStringBase64) succeeded in 0ms
INFO  2019-11-05T13:19:51.933Z queueing envelope cc07f4ab-d8da-4ed7-8c53-0aa327b1a3a8
INFO  2019-11-05T13:19:51.933Z received unidentified sender message
INFO  2019-11-05T13:19:51.942Z delivery receipt from +[REDACTED]320.1 1572959988133
INFO  2019-11-05T13:19:51.942Z Worker job 210 (arrayBufferToStringBase64) succeeded in 0ms
INFO  2019-11-05T13:19:52.758Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]320 (unauth)
INFO  2019-11-05T13:19:52.848Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]320 200 Success
INFO  2019-11-05T13:19:56.769Z Send pre-checks took 1 milliseconds
INFO  2019-11-05T13:19:56.770Z Sending message to conversation +[REDACTED]320 with timestamp 1572959996769
INFO  2019-11-05T13:19:56.792Z SQL channel job 5223 (saveMessage) succeeded in 11ms
INFO  2019-11-05T13:19:56.794Z SQL channel job 5224 (updateConversation) succeeded in 12ms
INFO  2019-11-05T13:19:56.815Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]320 (unauth)
INFO  2019-11-05T13:19:56.906Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]320 200 Success
INFO  2019-11-05T13:19:56.927Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]793
INFO  2019-11-05T13:19:57.019Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]793 200 Success
INFO  2019-11-05T13:20:00.288Z Worker job 211 (arrayBufferToStringBase64) succeeded in 0ms
INFO  2019-11-05T13:20:00.292Z queueing envelope d34b2feb-f509-4a0f-8b29-247bece3c1dd
INFO  2019-11-05T13:20:00.292Z received unidentified sender message
INFO  2019-11-05T13:20:00.295Z New remote ephemeral key
INFO  2019-11-05T13:20:00.297Z Deleting chain closed at 1572255476984
INFO  2019-11-05T13:20:00.303Z read receipt +[REDACTED]320 1572959996769
INFO  2019-11-05T13:20:00.303Z Worker job 212 (arrayBufferToStringBase64) succeeded in 0ms
INFO  2019-11-05T13:20:00.335Z SQL channel job 5259 (updateConversation) succeeded in 12ms
INFO  2019-11-05T13:20:01.673Z Worker job 213 (arrayBufferToStringBase64) succeeded in 0ms
INFO  2019-11-05T13:20:01.678Z queueing envelope ffcf9335-3be4-4699-86d9-8540fa62af3f
INFO  2019-11-05T13:20:01.679Z received unidentified sender message
INFO  2019-11-05T13:20:01.687Z delivery receipt from +[REDACTED]320.1 1572959996769
INFO  2019-11-05T13:20:01.688Z Worker job 214 (arrayBufferToStringBase64) succeeded in 1ms
INFO  2019-11-05T13:20:02.769Z open inbox
INFO  2019-11-05T13:20:02.778Z unloading conversation +[REDACTED]320 due to: model trigger - opened another conversation
INFO  2019-11-05T13:20:02.797Z GET https://textsecure-service.whispersystems.org/v1/profile/+[REDACTED]668 (unauth)
INFO  2019-11-05T13:20:02.800Z SQL channel job 5272 (getConversationById) succeeded in 17ms
INFO  2019-11-05T13:20:02.801Z SQL channel job 5273 (getOlderMessagesByConversation) succeeded in 17ms
INFO  2019-11-05T13:20:02.801Z SQL channel job 5274 (getMessageMetricsForConversation) succeeded in 16ms
INFO  2019-11-05T13:20:02.927Z GET https://textsecure-service.whispersystems.org/v1/profile/+[REDACTED]668 200 Success
INFO  2019-11-05T13:20:02.959Z Setting sealedSender to ENABLED for conversation +[REDACTED]668
INFO  2019-11-05T13:20:03.853Z open inbox
INFO  2019-11-05T13:20:03.861Z unloading conversation +[REDACTED]668 due to: model trigger - opened another conversation
INFO  2019-11-05T13:20:04.390Z SQL channel job 5291 (getNextExpiringMessage) succeeded in 18ms
INFO  2019-11-05T13:20:04.392Z SQL channel job 5292 (getNextTapToViewMessageToAgeOut) succeeded in 19ms
INFO  2019-11-05T13:20:04.396Z Sending 1 read receipts
INFO  2019-11-05T13:20:04.403Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]793
INFO  2019-11-05T13:20:04.495Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]793 200 Success
INFO  2019-11-05T13:20:04.511Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]320 (unauth)
INFO  2019-11-05T13:20:04.600Z PUT https://textsecure-service.whispersystems.org/v1/messages/+[REDACTED]320 200 Success
INFO  2019-11-05T13:20:16.146Z open inbox
INFO  2019-11-05T13:20:16.156Z unloading conversation +[REDACTED]320 due to: model trigger - opened another conversation
INFO  2019-11-05T13:20:29.692Z open inbox
INFO  2019-11-05T13:20:29.700Z unloading conversation +[REDACTED]668 due to: model trigger - opened another conversation
INFO  2019-11-05T13:20:56.673Z Sending a keepalive message
INFO  2019-11-05T13:21:51.761Z Sending a keepalive message
INFO  2019-11-05T13:22:01.685Z getAllFromCache
INFO  2019-11-05T13:22:01.688Z getAllFromCache loaded 0 saved envelopes
INFO  2019-11-05T13:22:46.849Z Sending a keepalive message
INFO  2019-11-05T13:23:35.977Z GET https://textsecure-service.whispersystems.org/v1/profile/+[REDACTED]320 (unauth)
INFO  2019-11-05T13:23:35.978Z Cycling agent for type -unauth
INFO  2019-11-05T13:23:36.362Z GET https://textsecure-service.whispersystems.org/v1/profile/+[REDACTED]320 200 Success
INFO  2019-11-05T13:23:36.362Z Setting sealedSender to ENABLED for conversation +[REDACTED]320
INFO  2019-11-05T13:23:36.363Z GET https://cdn.signal.org/profiles/J9aUZGC1nQ_0G3g0ofn1nw
ERROR 2019-11-05T13:23:36.516Z GET https://cdn.signal.org/profiles/J9aUZGC1nQ_0G3g0ofn1nw 403 Error
INFO  2019-11-05T13:23:41.937Z Sending a keepalive message
INFO  2019-11-05T13:24:37.025Z Sending a keepalive message
INFO  2019-11-05T13:25:02.797Z GET https://textsecure-service.whispersystems.org/v1/profile/+[REDACTED]668 (unauth)
INFO  2019-11-05T13:25:03.186Z GET https://textsecure-service.whispersystems.org/v1/profile/+[REDACTED]668 200 Success
INFO  2019-11-05T13:25:03.187Z Setting sealedSender to ENABLED for conversation +[REDACTED]668
INFO  2019-11-05T13:25:03.773Z Rotating signed prekey...
INFO  2019-11-05T13:25:03.813Z Saving new signed prekey 10
INFO  2019-11-05T13:25:03.814Z PUT https://textsecure-service.whispersystems.org/v2/keys/signed
INFO  2019-11-05T13:25:03.814Z Cycling agent for type -auth
INFO  2019-11-05T13:25:04.261Z PUT https://textsecure-service.whispersystems.org/v2/keys/signed 204 Success
INFO  2019-11-05T13:25:04.261Z Confirming new signed prekey 10
INFO  2019-11-05T13:25:04.267Z Most recent signed key: 10
INFO  2019-11-05T13:25:04.267Z Most recent confirmed signed key: 10
INFO  2019-11-05T13:25:04.267Z Total signed key count: 6 - 6 confirmed
INFO  2019-11-05T13:25:04.268Z Removing confirmed signed prekey: 5 with timestamp: 2019-10-27T14:45:47.076Z
INFO  2019-11-05T13:25:04.269Z Next signed key rotation scheduled for 2019-11-07T13:25:04.268Z

>> ----- somewhere here I have reported the issue

INFO  2019-11-05T13:25:32.112Z Sending a keepalive message
INFO  2019-11-05T13:26:27.200Z Sending a keepalive message
INFO  2019-11-05T13:27:22.288Z Sending a keepalive message
INFO  2019-11-05T13:28:12.866Z Remove all notifications
scottnonnenberg-signal commented 5 years ago

Yep, I was correct. The message this.cellSizeCache.clearPlus is not a function means that our react-virtualized package patches were not applied. You can see them applied during our Travis builds: https://travis-ci.org/signalapp/Signal-Desktop/builds/605732735

$ yarn install --frozen-lockfile
yarn install v1.17.3
[1[secure]6] Validating package.json...
[2[secure]6] Resolving packages...
success Already up-to-date.
$ patch-package && electron-builder install-app-deps && rimraf node_modules[secure]dtrace-provider
patch-package 6.1.2
Applying patches...
app-builder-lib@21.2.0 ✔
react-virtualized@9.21.0 ✔