search

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.59k stars 2.66k forks source link

Attachment saving dialogue always opens home folder #3961

Open kallekruse opened 4 years ago

kallekruse commented 4 years ago

Bug Description

When repeatedly saving images or videos received via Signal Desktop app on Ubuntu I have to manually select the appropriate folder for each individual attachment. The attachment saving dialogue always opens the default location (home folder). Having to select the same location for each attachment is cumbersome.

I seem to remember that until some time ago the app had remembered the last selected location. I do not recall at which version this behaviour has changed.

Steps to Reproduce

  1. Save an attachment to some location on your computer which is not your home folder. In my case this location is usually a folder somewhere multiple levels below my home folder with no symlinks in between.
  2. Try to save another (or the same) attachment.

Actual Result:

Attachment saving dialogue opens at the default location (home folder).

Expected Result:

App remembers the last selected location. Or at least - on Ubuntu - provides a menu entry like 'Recent' in the attachment saving dialogue which makes finding the last selected location quick and easy.

Platform Info

Signal Version: v1.31.0

Operating System: Ubuntu 18.04

Linked Device Version: Ubports "Axolotl Beta" app version 0.7.5

Link to Debug Log

No entries get written on saving attachments.

maysara commented 4 years ago

It would be great if we could define a "default location" on the command line, I'm using signal within docker, and I actually want to map a docker volume to a path where to find my saved files, but I need that location to be predictable, and it currently tries to save in / ; not even in the home directory of the current user.

CaviaPorcellus commented 4 years ago

Shouldn't the initial default directory for Signal's downloads be whatever default is defined by the OS? On Ubuntu and variants, normally that's ~/Downloads, but it is user configurable, so it should only be home if the user has defined home as their download directory. (I have the same issue with Ubuntu 16.04 (Unity) and Kubuntu 20.04.)

Whether or not Signal should remember the last saved directory is sort of tangential, I think, though obviously if the user set it once it would essentially solve this issue.

gromeck commented 2 years ago

The same is true for the dialog to attach files in the chat. It also doesn't remember the last location, which is really annoying.

chronos000 commented 1 year ago

I have Signal installed in Linux with flatpak, and I can see the same behaviour. Signal version 6.7.0

CaviaPorcellus commented 1 year ago

Signal now (version 6.19.0, tested on Kubuntu 23.04) remembers the last directory used, so I think this is solved.

Edit: I spoke too soon. While the user selection is persistent after restarting Signal, oddly the change is only persistent over a single session: once I log out, then it resets to the (apparently new) default of ~/Documents.

gromeck commented 1 year ago

Negative -- I tested with Signal 6.21.0 on Debian 11.7 (Updates of Signal coming from "https://updates.signal.org/desktop/apt xenial main").

Same as before, means that no directory (upload or download of media) is remembered.

chronos000 commented 1 year ago

I can also confirm seeing this behavior on Signal 6.24.0. Installed with flatpak (via flathub), and running on up-to-date Pop!_OS 22.04

KiaraGrouwstra commented 11 months ago

i'm experiencing this with an installation thru Nix(OS) as well